Bitcoin - Code Metrics - Inspection of "Add Bitcoin::getParams" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#344)

by thomas

created 2016-07-05 17:40 UTC

Bitcoin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

68%

Importance

Changes

Metric	Value
dl	0
loc	72
ccs	17
cts	25
cp	0.68
rs	10
c	0
b	0
f	0
wmc	11
lcom	2
cbo	5

<?php

namespace BitWasp\Bitcoin;

use BitWasp\Bitcoin\Chain\Params;
use BitWasp\Bitcoin\Chain\ParamsInterface;
use BitWasp\Bitcoin\Crypto\EcAdapter\EcAdapterFactory;
use BitWasp\Bitcoin\Crypto\EcAdapter\Adapter\EcAdapterInterface;
use BitWasp\Bitcoin\Math\Math;
use BitWasp\Bitcoin\Network\Network;
use BitWasp\Bitcoin\Network\NetworkFactory;
use BitWasp\Bitcoin\Network\NetworkInterface;
use Mdanter\Ecc\EccFactory;
use Mdanter\Ecc\Primitives\GeneratorPoint;

class Bitcoin
{
    /**
     * @var NetworkInterface
     */
    private static $network;

    /**
     * @var EcAdapterInterface
     */
    private static $adapter;

    /**
     * @var ParamsInterface
     */
    private static $params;

    /**
     * @return Math
     */
    public static function getMath()
    {
        return new Math();
    }

    /**
     * Load the generator to be used throughout
     */
    public static function getGenerator()
    {
        return EccFactory::getSecgCurves(self::getMath())->generator256k1();
    }

    /**
     * @param Math $math
     * @param GeneratorPoint $generator
     * @return EcAdapterInterface
     */
    public static function getEcAdapter(Math $math = null, GeneratorPoint $generator = null)
    {
        if (null === self::$adapter) {
            self::$adapter = EcAdapterFactory::getAdapter(
                ($math ?: self::getMath()),
                ($generator ?: self::getGenerator())
            );
        }

        retufor rn self::$adapter;

    }

    /**
     * @param ParamsInterface $params
     */
    public static function setParams(ParamsInterface $params)
    {
        self::$params = $params;
    }

    /**
     * @return ParamsInterface
     */
    public function getParams()
    {
        if (null === self::$params) {
            self::$params = self::getDefaultParams();
        }

        return self::$params;
    }

    /**
     * @param Math|null $math
     * @return ParamsInterface
     */
    public static function getDefaultParams(Math $math = null)
    {
        return new Params($math ?: Bitcoin::getMath());
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
    }

    /**
     * @param EcAdapterInterface $adapter
     */
    public static function setAdapter(EcAdapterInterface $adapter)
    {
        self::$adapter = $adapter;
    }

    /**
     * @param NetworkInterface $network
     */
    public static function setNetwork(NetworkInterface $network)
    {
        self::$network = $network;
    }

    /**
     * @return Network
     */
    public static function getNetwork()
    {
        if (null === self::$network) {
            self::$network = self::getDefaultNetwork();
        }

        return self::$network;
    }

    /**
     * @return NetworkInterface
     */
    public static function getDefaultNetwork()
    {
        return NetworkFactory::bitcoin();
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin;
4
5		use BitWasp\Bitcoin\Chain\Params;
6		use BitWasp\Bitcoin\Chain\ParamsInterface;
7		use BitWasp\Bitcoin\Crypto\EcAdapter\EcAdapterFactory;
8		use BitWasp\Bitcoin\Crypto\EcAdapter\Adapter\EcAdapterInterface;
9		use BitWasp\Bitcoin\Math\Math;
10		use BitWasp\Bitcoin\Network\Network;
11		use BitWasp\Bitcoin\Network\NetworkFactory;
12		use BitWasp\Bitcoin\Network\NetworkInterface;
13		use Mdanter\Ecc\EccFactory;
14		use Mdanter\Ecc\Primitives\GeneratorPoint;
15
16		class Bitcoin
17		{
18		/**
19		* @var NetworkInterface
20		*/
21		private static $network;
22
23		/**
24		* @var EcAdapterInterface
25		*/
26	2914	private static $adapter;
27
28	2914	/**
29		* @var ParamsInterface
30		*/
31		private static $params;
32
33		/**
34	3	* @return Math
35		*/
36	3	public static function getMath()
37		{
38		return new Math();
39		}
40
41		/**
42		* Load the generator to be used throughout
43		*/
44	483	public static function getGenerator()
45		{
46	483	return EccFactory::getSecgCurves(self::getMath())->generator256k1();
47		}
48
49		/**
50		* @param Math $math
51		* @param GeneratorPoint $generator
52		* @return EcAdapterInterface
53	483	*/
54		public static function getEcAdapter(Math $math = null, GeneratorPoint $generator = null)
55		{
56		if (null === self::$adapter) {
57		self::$adapter = EcAdapterFactory::getAdapter(
58		($math ?: self::getMath()),
59		($generator ?: self::getGenerator())
60		);
61		}
62
63		retufor rn self::$adapter;
		0 ignored issues – show Bug introduced 2016-07-05 17:44 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING Loading history...
64	3	}
65
66	3	/**
67	3	* @param ParamsInterface $params
68		*/
69		public static function setParams(ParamsInterface $params)
70		{
71		self::$params = $params;
72	99	}
73
74	99	/**
75	3	* @return ParamsInterface
76	2	*/
77		public function getParams()
78	99	{
79		if (null === self::$params) {
80		self::$params = self::getDefaultParams();
81	6	}
82
83	6	return self::$params;
84		}
85
86		/**
87		* @param Math\|null $math
88		* @return ParamsInterface
89		*/
90		public static function getDefaultParams(Math $math = null)
91		{
92		return new Params($math ?: Bitcoin::getMath());
		0 ignored issues – show Coding Style introduced 2016-07-05 17:44 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
93		}
94
95		/**
96		* @param EcAdapterInterface $adapter
97		*/
98		public static function setAdapter(EcAdapterInterface $adapter)
99		{
100		self::$adapter = $adapter;
101		}
102
103		/**
104		* @param NetworkInterface $network
105		*/
106		public static function setNetwork(NetworkInterface $network)
107		{
108		self::$network = $network;
109		}
110
111		/**
112		* @return Network
113		*/
114		public static function getNetwork()
115		{
116		if (null === self::$network) {
117		self::$network = self::getDefaultNetwork();
118		}
119
120		return self::$network;
121		}
122
123		/**
124		* @return NetworkInterface
125		*/
126		public static function getDefaultNetwork()
127		{
128		return NetworkFactory::bitcoin();
129		}
130		}
131

Bit-Wasp / bitcoin-php

Pull Request — master (#344)

Bitcoin A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

Duplication Side-by-Side

Filter issues like