ScriptWitness::equals() - Code Metrics - Inspection of "Remove collections" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#348)

by thomas

created 2016-07-06 13:10 UTC

ScriptWitness::equals() A

↳ Parent: ScriptWitness

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4.432

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	4
eloc	8
c	2
b	0
f	1
nc	4
nop	1
dl	0
loc	15
ccs	7
cts	10
cp	0.7
crap	4.432
rs	9.2

<?php

namespace BitWasp\Bitcoin\Script;

use BitWasp\Bitcoin\Collection\StaticBufferCollection;
use BitWasp\Bitcoin\Serializer\Script\ScriptWitnessSerializer;

class ScriptWitness extends StaticBufferCollection implements ScriptWitnessInterface
{
    /**
     * @param ScriptWitnessInterface $witness
     * @return bool
     */
    public function equals(ScriptWitnessInterface $witness)
    {
        $nStack = count($this);
        if ($nStack !== count($witness)) {
            return false;
        }

        for ($i = 0; $i < $nStack; $i++) {
            if (false === $this->offsetGet($i)->equals($witness->offsetGet($i))) {
                return false;
            }
        }

        return true;
    }

    /**
     * @return \BitWasp\Buffertools\BufferInterface
     */
    public function getBuffer()
    {
        return (new ScriptWitnessSerializer())->serialize($this);
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script;
4
5		use BitWasp\Bitcoin\Collection\StaticBufferCollection;
6		use BitWasp\Bitcoin\Serializer\Script\ScriptWitnessSerializer;
7
8		class ScriptWitness extends StaticBufferCollection implements ScriptWitnessInterface
9		{
10		/**
11		* @param ScriptWitnessInterface $witness
12		* @return bool
13		*/
14		public function equals(ScriptWitnessInterface $witness)
15	51	{
16		$nStack = count($this);
17	51	if ($nStack !== count($witness)) {
18	51	return false;
19	22	}
20
21		for ($i = 0; $i < $nStack; $i++) {
22	22	if (false === $this->offsetGet($i)->equals($witness->offsetGet($i))) {
23	28	return false;
24	51	}
25		}
26
27		return true;
28		}
29
30		/**
31		* @return \BitWasp\Buffertools\BufferInterface
32		*/
33		public function getBuffer()
34		{
35		return (new ScriptWitnessSerializer())->serialize($this);
36		}
37		}
38

Bit-Wasp / bitcoin-php

Pull Request — master (#348)

ScriptWitness::equals() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like