StaticCollection - Code Metrics - Inspection of "Remove collections" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#348)

by thomas

created 2016-07-06 13:10 UTC

StaticCollection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	139
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	139
ccs	28
cts	28
cp	1
rs	10
wmc	17
lcom	1
cbo	0

14 Methods

Rating	Name	Size	Complexity
A	all()	4	1
A	slice()	10	3
A	count()	4	1
A	bottom()	4	1
A	isNull()	4	1
A	rewind()	4	1
A	current()	4	1
A	key()	4	1
A	next()	4	1
A	valid()	4	1
A	offsetExists()	4	1
A	offsetUnset()	4	1
A	offsetGet()	8	2
A	offsetSet()	4	1

<?php

namespace BitWasp\Bitcoin\Collection;

abstract class StaticCollection implements CollectionInterface
{
    /**
     * @var array
     */
    protected $set;

    /**
     * @var int
     */
    protected $position = 0;

    /**
     * @return array
     */
    public function all()
    {
        return $this->set;
    }

    /**
     * @param int $start
     * @param int $length
     * @return self
     */
    public function slice($start, $length)
    {
        $end = count($this->set);
        if ($start > $end || $length > $end) {
            throw new \RuntimeException('Invalid start or length');
        }

        $sliced = array_slice($this->set, $start, $length);
        return new static($sliced);

    }

    /**
     * @return int
     */
    public function count()
    {
        return count($this->set);
    }

    /**
     * @return mixed
     */
    public function bottom()
    {
        return $this->offsetGet(count($this) - 1);
    }

    /**
     * @return bool
     */
    public function isNull()
    {
        return count($this->set) === 0;
    }

    /**
     * @return void
     */
    public function rewind()
    {
        $this->position = 0;
    }

    /**
     * @return mixed
     */
    public function current()
    {
        return $this->set[$this->position];
    }

    /**
     * @return int
     */
    public function key()
    {
        return $this->position;
    }

    /**
     * @return void
     */
    public function next()
    {
        ++$this->position;
    }

    /**
     * @return bool
     */
    public function valid()
    {
        return isset($this->set[$this->position]);
    }

    /**
     * @param int $offset
     * @return bool
     */
    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->set);
    }

    /**
     * @param int $offset
     */
    public function offsetUnset($offset)
    {
        throw new \RuntimeException('Cannot unset from a Static Collection');
    }

    /**
     * @param int $offset
     * @return mixed
     */
    public function offsetGet($offset)
    {
        if (!array_key_exists($offset, $this->set)) {
            throw new \OutOfRangeException('Nothing found at this offset');
        }

        return $this->set[$offset];
    }

    /**
     * @param int $offset
     * @param mixed $value
     */
    public function offsetSet($offset, $value)
    {
        throw new \RuntimeException('Cannot add to a Static Collection');
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Collection;
4
5		abstract class StaticCollection implements CollectionInterface
6		{
7		/**
8		* @var array
9		*/
10		protected $set;
11
12		/**
13		* @var int
14		*/
15	12	protected $position = 0;
16
17	12	/**
18		* @return array
19		*/
20		public function all()
21		{
22		return $this->set;
23	37	}
24
25	37	/**
26		* @param int $start
27		* @param int $length
28		* @return self
29		*/
30		public function slice($start, $length)
31	127	{
32		$end = count($this->set);
33	127	if ($start > $end \|\| $length > $end) {
34		throw new \RuntimeException('Invalid start or length');
35		}
36
37		$sliced = array_slice($this->set, $start, $length);
38		return new static($sliced);
		0 ignored issues – show Unused Code introduced 2016-07-06 14:20 UTC by Report Bug Copy Issue Report The call to `StaticCollection::__construct()` has too many arguments starting with `$sliced`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
39	103	}
40
41	103	/**
42	103	* @return int
43		*/
44		public function count()
45		{
46		return count($this->set);
47	3	}
48
49	3	/**
50		* @return mixed
51		*/
52		public function bottom()
53		{
54		return $this->offsetGet(count($this) - 1);
55	39	}
56
57	39	/**
58		* @return bool
59		*/
60		public function isNull()
61		{
62		return count($this->set) === 0;
63	102	}
64
65	102	/**
66	102	* @return void
67		*/
68		public function rewind()
69		{
70		$this->position = 0;
71	103	}
72
73	103	/**
74		* @return mixed
75		*/
76		public function current()
77		{
78		return $this->set[$this->position];
79		}
80	30
81		/**
82	30	* @return int
83		*/
84		public function key()
85		{
86		return $this->position;
87		}
88	3
89		/**
90	3	* @return void
91		*/
92		public function next()
93		{
94		++$this->position;
95		}
96
97	12	/**
98		* @return bool
99	12	*/
100	6	public function valid()
101		{
102	6	return isset($this->set[$this->position]);
103		}
104
105		/**
106		* @param int $offset
107		* @return bool
108		*/
109	6	public function offsetExists($offset)
110		{
111	6	return array_key_exists($offset, $this->set);
112		}
113
114		/**
115		* @param int $offset
116		*/
117		public function offsetUnset($offset)
118		{
119		throw new \RuntimeException('Cannot unset from a Static Collection');
120		}
121
122		/**
123		* @param int $offset
124		* @return mixed
125		*/
126		public function offsetGet($offset)
127		{
128		if (!array_key_exists($offset, $this->set)) {
129		throw new \OutOfRangeException('Nothing found at this offset');
130		}
131
132		return $this->set[$offset];
133		}
134
135		/**
136		* @param int $offset
137		* @param mixed $value
138		*/
139		public function offsetSet($offset, $value)
140		{
141		throw new \RuntimeException('Cannot add to a Static Collection');
142		}
143		}
144

Bit-Wasp / bitcoin-php

Pull Request — master (#348)

StaticCollection A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

Duplication Side-by-Side

Filter issues like