Conditional::__construct() - Code Metrics - Inspection of "Multiple branches" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#524)

by thomas

created 2017-09-03 21:58 UTC

Conditional::__construct() A

↳ Parent: Conditional

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	2
nop	1
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Transaction\Factory;

use BitWasp\Bitcoin\Script\Opcodes;
use BitWasp\Buffertools\Buffer;

class Conditional
{
    /**
     * @var int
     */
    private $opcode;

    /**
     * @var bool
     */
    private $value;

    /**
     * @var null
     */
    private $providedBy = null;

    /**
     * Conditional constructor.
     * @param int $opcode
     */
    public function __construct($opcode)
    {
        if ($opcode !== Opcodes::OP_IF && $opcode !== Opcodes::OP_NOTIF) {
            throw new \RuntimeException("Opcode for conditional is only IF / NOTIF");
        }

        $this->opcode = $opcode;
    }

    /**
     * @return int
     */
    public function getOp()
    {
        return $this->opcode;
    }

    /**
     * @param bool $value
     */
    public function setValue($value)
    {
        if (!is_bool($value)) {
            throw new \RuntimeException("Invalid value for conditional");
        }

        $this->value = $value;
    }

    /**
     * @return bool
     */
    public function hasValue()
    {
        return null !== $this->value;
    }

    /**
     * @return bool
     */
    public function getValue()
    {
        if (null === $this->value) {
            throw new \RuntimeException("Value not set on conditional");
        }

        return $this->value;
    }

    public function providedBy(Checksig $checksig)
    {
        $this->providedBy = $checksig;

    }

    /**
     * @return array
     */
    public function serialize()
    {
        if ($this->hasValue() && null === $this->providedBy) {
            return [$this->value ? new Buffer("\x01") : new Buffer()];
        }

        return [];
    }
}


1			<?php
2
3			namespace BitWasp\Bitcoin\Transaction\Factory;
4
5			use BitWasp\Bitcoin\Script\Opcodes;
6			use BitWasp\Buffertools\Buffer;
7
8			class Conditional
9			{
10			/**
11			* @var int
12			*/
13			private $opcode;
14
15			/**
16			* @var bool
17			*/
18			private $value;
19
20			/**
21			* @var null
22			*/
23			private $providedBy = null;
24
25			/**
26			* Conditional constructor.
27			* @param int $opcode
28			*/
29			public function __construct($opcode)
30			{
31			if ($opcode !== Opcodes::OP_IF && $opcode !== Opcodes::OP_NOTIF) {
32			throw new \RuntimeException("Opcode for conditional is only IF / NOTIF");
33			}
34
35			$this->opcode = $opcode;
36			}
37
38			/**
39			* @return int
40			*/
41			public function getOp()
42			{
43			return $this->opcode;
44			}
45
46			/**
47			* @param bool $value
48			*/
49			public function setValue($value)
50			{
51			if (!is_bool($value)) {
52			throw new \RuntimeException("Invalid value for conditional");
53			}
54
55			$this->value = $value;
56			}
57
58			/**
59			* @return bool
60			*/
61			public function hasValue()
62			{
63			return null !== $this->value;
64			}
65
66			/**
67			* @return bool
68			*/
69			public function getValue()
70			{
71			if (null === $this->value) {
72			throw new \RuntimeException("Value not set on conditional");
73			}
74
75			return $this->value;
76			}
77
78			public function providedBy(Checksig $checksig)
79			{
80			$this->providedBy = $checksig;
			0 ignored issues – show Documentation Bug introduced 2017-09-03 21:25 UTC by Report Bug Copy Issue Report It seems like `$checksig` of type `object<BitWasp\Bitcoin\T...ction\Factory\Checksig>` is incompatible with the declared type `null` of property `$providedBy`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
81			}
82
83			/**
84			* @return array
85			*/
86			public function serialize()
87			{
88			if ($this->hasValue() && null === $this->providedBy) {
89			return [$this->value ? new Buffer("\x01") : new Buffer()];
90			}
91
92			return [];
93			}
94			}
95

Bit-Wasp / bitcoin-php

Pull Request — master (#524)

Conditional::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like