BitWasp\Bitcoin\Transaction\OutPoint

Complexity

Total Complexity

6

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	3
A	getTxId()	0	4	1
A	getVout()	0	4	1
A	getBuffer()	0	4	1

<?php

namespace BitWasp\Bitcoin\Transaction;

use BitWasp\Bitcoin\Serializable;
use BitWasp\Bitcoin\Serializer\Transaction\OutPointSerializer;
use BitWasp\Buffertools\Buffer;
use BitWasp\CommonTrait\FunctionAliasArrayAccess;

class OutPoint extends Serializable implements OutPointInterface
{
    use FunctionAliasArrayAccess;

    /**
     * @var Buffer
     */
    private $hashPrevOutput;

    /**
     * @var int
     */
    private $nPrevOutput;

    /**
     * OutPoint constructor.
     * @param Buffer $hashPrevOutput
     * @param int $nPrevOutput
     */
    public function __construct(Buffer $hashPrevOutput, $nPrevOutput)
    {
        if ($hashPrevOutput->getSize() !== 32) {
            throw new \InvalidArgumentException('OutPoint: hashPrevOut must be a 32-byte Buffer');
        }

        if (!is_numeric($nPrevOutput)) {
            throw new \InvalidArgumentException('OutPoint: nPrevOut must be numeric');
        }

        $this->hashPrevOutput = $hashPrevOutput;
        $this->nPrevOutput = $nPrevOutput;

It seems like $nPrevOutput can also be of type double or string. However, the property $nPrevOutput is declared as type integer. Maybe add an additional type check?

        $this
            ->initFunctionAlias('txid', 'getTxId')
            ->initFunctionAlias('vout', 'getVout');
    }

    /**
     * @return Buffer
     */
    public function getTxId()
    {
        return $this->hashPrevOutput;
    }

    /**
     * @return int
     */
    public function getVout()
    {
        return $this->nPrevOutput;
    }

    /**
     * @return Buffer
     */
    public function getBuffer()
    {
        return (new OutPointSerializer())->serialize($this);
    }
}