Math::eq() - Code Metrics - Inspection of "Start testing mdanter/ecc 0.4" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#313)

by thomas

created 2016-06-17 14:21 UTC

Math::eq() A

↳ Parent: Math

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Math;

use \Mdanter\Ecc\Math\GmpMath;
use Mdanter\Ecc\Util\NumberSize;

class Math extends GmpMath
{
    /**
     * @return BinaryMath
     */
    public function getBinaryMath()
    {
        return new BinaryMath($this);
    }

    /**
     * @param $integer
     * @return bool
     */
    public function isEven($integer)
    {
        return $this->cmp($this->mod($integer, gmp_init(2)), gmp_init(0)) === 0;
    }

    /**
     * @param \GMP $int
     * @param \GMP $otherInt
     * @return \GMP
     */
    public function bitwiseOr(\GMP $int, \GMP $otherInt)
    {
        return gmp_or($int, $otherInt);
    }

    /**
     * Similar to gmp_div_qr, return a tuple containing the
     * result and the remainder
     *
     * @param \GMP $dividend
     * @param \GMP $divisor
     * @return array
     */
    public function divQr(\GMP $dividend, \GMP $divisor)
    {
        // $div = n / q
        $div = $this->div($dividend, $divisor);
        // $remainder = n - (n / q) * q
        $remainder = $this->sub($dividend, $this->mul($div, $divisor));
        return array($div, $remainder);
    }

    /**
     * @param int $compact
     * @param bool|false $isNegative
     * @param bool|false $isOverflow
     * @return \GMP
     */
    public function writeCompact($compact, &$isNegative, &$isOverflow)
    {
        $compact = gmp_init($compact, 10);
        $size = $this->rightShift($compact, 24);
        $word = $this->bitwiseAnd($compact, gmp_init(0x007fffff));
        if ($this->cmp($size, gmp_init(3)) <= 0) {
            $positions = $this->toString($this->mul(gmp_init(8), $this->sub(gmp_init(3), $size)));
            $word = $this->rightShift($word, $positions);
        } else {
            $positions = $this->toString($this->mul(gmp_init(8), $this->sub($size, gmp_init(3))));
            $word = $this->leftShift($word, $positions);

        }

        // isNegative: $word != 0 && $uint32 & 0x00800000 != 0
        // isOverflow: $word != 0 && (($size > 34) || ($word > 0xff && $size > 33) || ($word > 0xffff && $size  >32))
        $zero = gmp_init(0);
        $isNegative = ($this->cmp($word, $zero) !== 0) && ($this->cmp($this->bitwiseAnd($compact, gmp_init(0x00800000)), $zero) === 1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $isOverflow = $this->cmp($word, $zero ) !== 0 && (
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                ($this->cmp($size, gmp_init(34)) > 0)
                || ($this->cmp($word, gmp_init(0xff)) > 0 && $this->cmp($size, gmp_init(33)) > 0)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                || ($this->cmp($word, gmp_init(0xffff)) > 0 && $this->cmp($size, gmp_init(32)) > 0)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );

        return $word;
    }

    /**
     * @param \GMP $integer
     * @return \GMP
     */
    public function getLow64(\GMP $integer)
    {
        $bits = gmp_strval($integer, 2);
        $bits = substr($bits, 0, 64);
        $bits = str_pad($bits, 64, '0', STR_PAD_LEFT);
        return gmp_init($bits, 2);
    }

    /**
     * @param \GMP $integer
     * @param bool $fNegative
     * @return \GMP
     */
    public function parseCompact(\GMP $integer, $fNegative)
    {
        if (!is_bool($fNegative)) {
            throw new \InvalidArgumentException('CompactInteger::read() - flag must be boolean!');
        }

        $size = (int) NumberSize::bnNumBytes($this, $integer);
        if ($size <= 3) {
            $compact = $this->leftShift($this->getLow64($integer), (8 * (3 - $size)));
        } else {
            $compact = $this->rightShift($integer, 8 * ($size - 3));
            $compact = $this->getLow64($compact);
        }

        if ($this->cmp($this->bitwiseAnd($compact, gmp_init(0x00800000, 10)), gmp_init(0)) > 0) {
            $compact = $this->rightShift($compact, 8);
            $size = $size + 1;
        }

        $compact = $this->bitwiseOr($compact, $this->leftShift(gmp_init($size, 10), 24));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        if ($fNegative && $this->cmp($this->bitwiseAnd($compact, gmp_init(0x007fffff)), gmp_init(0)) > 0) { /// ?
            $compact = $this->bitwiseOr($compact, gmp_init(0x00800000));
        }

        return $compact;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Math;
4
5		use \Mdanter\Ecc\Math\GmpMath;
6		use Mdanter\Ecc\Util\NumberSize;
7
8		class Math extends GmpMath
9		{
10		/**
11		* @return BinaryMath
12		*/
13		public function getBinaryMath()
14		{
15		return new BinaryMath($this);
16		}
17
18		/**
19		* @param $integer
20		* @return bool
21		*/
22		public function isEven($integer)
23		{
24		return $this->cmp($this->mod($integer, gmp_init(2)), gmp_init(0)) === 0;
25		}
26
27		/**
28		* @param \GMP $int
29		* @param \GMP $otherInt
30		* @return \GMP
31		*/
32		public function bitwiseOr(\GMP $int, \GMP $otherInt)
33		{
34		return gmp_or($int, $otherInt);
35		}
36
37		/**
38		* Similar to gmp_div_qr, return a tuple containing the
39		* result and the remainder
40		*
41		* @param \GMP $dividend
42		* @param \GMP $divisor
43		* @return array
44		*/
45		public function divQr(\GMP $dividend, \GMP $divisor)
46		{
47		// $div = n / q
48		$div = $this->div($dividend, $divisor);
49		// $remainder = n - (n / q) * q
50		$remainder = $this->sub($dividend, $this->mul($div, $divisor));
51		return array($div, $remainder);
52		}
53
54		/**
55		* @param int $compact
56		* @param bool\|false $isNegative
57		* @param bool\|false $isOverflow
58		* @return \GMP
59		*/
60		public function writeCompact($compact, &$isNegative, &$isOverflow)
61		{
62		$compact = gmp_init($compact, 10);
63		$size = $this->rightShift($compact, 24);
64		$word = $this->bitwiseAnd($compact, gmp_init(0x007fffff));
65		if ($this->cmp($size, gmp_init(3)) <= 0) {
66		$positions = $this->toString($this->mul(gmp_init(8), $this->sub(gmp_init(3), $size)));
67		$word = $this->rightShift($word, $positions);
68		} else {
69		$positions = $this->toString($this->mul(gmp_init(8), $this->sub($size, gmp_init(3))));
70		$word = $this->leftShift($word, $positions);
		0 ignored issues – show Bug Compatibility introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report The expression `$this->leftShift($word, $positions);` of type `resource` adds the type `resource` to the return on line 83 which is incompatible with the return type documented by `BitWasp\Bitcoin\Math\Math::writeCompact` of type `GMP`. Loading history...
71		}
72
73	88	// isNegative: $word != 0 && $uint32 & 0x00800000 != 0
74		// isOverflow: $word != 0 && (($size > 34) \|\| ($word > 0xff && $size > 33) \|\| ($word > 0xffff && $size >32))
75	88	$zero = gmp_init(0);
76		$isNegative = ($this->cmp($word, $zero) !== 0) && ($this->cmp($this->bitwiseAnd($compact, gmp_init(0x00800000)), $zero) === 1);
		0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `$word` defined by `$this->leftShift($word, $positions)` on line `70` can also be of type `resource`; however, `Mdanter\Ecc\Math\GmpMath::cmp()` does only seem to accept `object<GMP>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
77		$isOverflow = $this->cmp($word, $zero ) !== 0 && (
		0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `$word` defined by `$this->leftShift($word, $positions)` on line `70` can also be of type `resource`; however, `Mdanter\Ecc\Math\GmpMath::cmp()` does only seem to accept `object<GMP>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
78		($this->cmp($size, gmp_init(34)) > 0)
79		\|\| ($this->cmp($word, gmp_init(0xff)) > 0 && $this->cmp($size, gmp_init(33)) > 0)
		0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `$word` defined by `$this->leftShift($word, $positions)` on line `70` can also be of type `resource`; however, `Mdanter\Ecc\Math\GmpMath::cmp()` does only seem to accept `object<GMP>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
80		\|\| ($this->cmp($word, gmp_init(0xffff)) > 0 && $this->cmp($size, gmp_init(32)) > 0)
		0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `$word` defined by `$this->leftShift($word, $positions)` on line `70` can also be of type `resource`; however, `Mdanter\Ecc\Math\GmpMath::cmp()` does only seem to accept `object<GMP>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81		);
82	90
83		return $word;
84	90	}
85
86		/**
87		* @param \GMP $integer
88		* @return \GMP
89		*/
90		public function getLow64(\GMP $integer)
91		{
92	248	$bits = gmp_strval($integer, 2);
93		$bits = substr($bits, 0, 64);
94	248	$bits = str_pad($bits, 64, '0', STR_PAD_LEFT);
95		return gmp_init($bits, 2);
96		}
97
98		/**
99		* @param \GMP $integer
100		* @param bool $fNegative
101		* @return \GMP
102		*/
103		public function parseCompact(\GMP $integer, $fNegative)
104		{
105	132	if (!is_bool($fNegative)) {
106		throw new \InvalidArgumentException('CompactInteger::read() - flag must be boolean!');
107		}
108	132
109		$size = (int) NumberSize::bnNumBytes($this, $integer);
110	132	if ($size <= 3) {
111	132	$compact = $this->leftShift($this->getLow64($integer), (8 * (3 - $size)));
112		} else {
113		$compact = $this->rightShift($integer, 8 * ($size - 3));
114		$compact = $this->getLow64($compact);
115		}
116
117		if ($this->cmp($this->bitwiseAnd($compact, gmp_init(0x00800000, 10)), gmp_init(0)) > 0) {
118		$compact = $this->rightShift($compact, 8);
119		$size = $size + 1;
120	840	}
121
122		$compact = $this->bitwiseOr($compact, $this->leftShift(gmp_init($size, 10), 24));
		0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `$compact` defined by `$this->bitwiseOr($compac...p_init($size, 10), 24))` on line `122` can also be of type `resource`; however, `BitWasp\Bitcoin\Math\Math::bitwiseOr()` does only seem to accept `object<GMP>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
123	840	if ($fNegative && $this->cmp($this->bitwiseAnd($compact, gmp_init(0x007fffff)), gmp_init(0)) > 0) { /// ?
124	840	$compact = $this->bitwiseOr($compact, gmp_init(0x00800000));
125	840	}
126	52
127	39	return $compact;
128	788	}
129		}
130

Bit-Wasp / bitcoin-php

Pull Request — master (#313)

Math::eq() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like