SignatureSort::__construct() - Code Metrics - Inspection of "API break: Signer::sign now accepts SignData" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#403)

by thomas

created 2016-11-21 22:56 UTC

SignatureSort::__construct() A

↳ Parent: SignatureSort

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	1
dl	0
loc	4
ccs	3
cts	3
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Signature;

use BitWasp\Bitcoin\Bitcoin;
use BitWasp\Bitcoin\Crypto\EcAdapter\Adapter\EcAdapterInterface;
use BitWasp\Buffertools\BufferInterface;

class SignatureSort implements SignatureSortInterface
{
    /**
     * @var EcAdapterInterface
     */
    private $ecAdapter;

    /**
     * SignatureSort constructor.
     * @param EcAdapterInterface $ecAdapter
     */
    public function __construct(EcAdapterInterface $ecAdapter = null)
    {
        $this->ecAdapter = $ecAdapter ?: Bitcoin::getEcAdapter();
    }

    /**
     * @param \BitWasp\Bitcoin\Crypto\EcAdapter\Signature\SignatureInterface[] $signatures
     * @param \BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface[] $publicKeys
     * @param BufferInterface $messageHash
     * @return \SplObjectStorage
     */
    public function link(array $signatures, array $publicKeys, BufferInterface $messageHash)
    {
        $sigCount = count($signatures);
        $storage = new \SplObjectStorage();
        foreach ($signatures as $signature) {
            foreach ($publicKeys as $key) {
                if ($this->ecAdapter->verify($messageHash, $key, $signature)) {
                    $storage->attach($key, $signature);
                    if (count($storage) === $sigCount) {
                        break 2;
                    }

                    break;
                }
            }
        }

        return $storage;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Signature;
4
5		use BitWasp\Bitcoin\Bitcoin;
6		use BitWasp\Bitcoin\Crypto\EcAdapter\Adapter\EcAdapterInterface;
7		use BitWasp\Buffertools\BufferInterface;
8
9		class SignatureSort implements SignatureSortInterface
10		{
11		/**
12		* @var EcAdapterInterface
13		*/
14		private $ecAdapter;
15
16		/**
17		* SignatureSort constructor.
18		* @param EcAdapterInterface $ecAdapter
19		*/
20	60	public function __construct(EcAdapterInterface $ecAdapter = null)
21		{
22	60	$this->ecAdapter = $ecAdapter ?: Bitcoin::getEcAdapter();
23	60	}
24
25		/**
26		* @param \BitWasp\Bitcoin\Crypto\EcAdapter\Signature\SignatureInterface[] $signatures
27		* @param \BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface[] $publicKeys
28		* @param BufferInterface $messageHash
29		* @return \SplObjectStorage
30		*/
31	60	public function link(array $signatures, array $publicKeys, BufferInterface $messageHash)
32		{
33	60	$sigCount = count($signatures);
34	60	$storage = new \SplObjectStorage();
35	60	foreach ($signatures as $signature) {
36	60	foreach ($publicKeys as $key) {
37	60	if ($this->ecAdapter->verify($messageHash, $key, $signature)) {
38	54	$storage->attach($key, $signature);
39	54	if (count($storage) === $sigCount) {
40	54	break 2;
41		}
42
43	8	break;
44		}
45	4	}
46	20	}
47
48	60	return $storage;
49		}
50		}
51

Bit-Wasp / bitcoin-php

Pull Request — master (#403)

SignatureSort::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like