Bit-Wasp /
bitcoin-php
Complex classes like InputSigner often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use InputSigner, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 35 | class InputSigner |
||
| 36 | { |
||
| 37 | /** |
||
| 38 | * @var array |
||
| 39 | */ |
||
| 40 | protected static $canSign = [ |
||
| 41 | ScriptType::P2PKH, |
||
| 42 | ScriptType::P2PK, |
||
| 43 | ScriptType::MULTISIG |
||
| 44 | ]; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @var array |
||
| 48 | */ |
||
| 49 | protected static $validP2sh = [ |
||
| 50 | ScriptType::P2WKH, |
||
| 51 | ScriptType::P2WSH, |
||
| 52 | ScriptType::P2PKH, |
||
| 53 | ScriptType::P2PK, |
||
| 54 | ScriptType::MULTISIG |
||
| 55 | ]; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var EcAdapterInterface |
||
| 59 | */ |
||
| 60 | private $ecAdapter; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var OutputData $scriptPubKey |
||
| 64 | */ |
||
| 65 | private $scriptPubKey; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var OutputData $redeemScript |
||
| 69 | */ |
||
| 70 | private $redeemScript; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var OutputData $witnessScript |
||
| 74 | */ |
||
| 75 | private $witnessScript; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @var OutputData |
||
| 79 | */ |
||
| 80 | private $signScript; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @var int |
||
| 84 | */ |
||
| 85 | private $sigVersion; |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @var OutputData $witnessKeyHash |
||
| 89 | */ |
||
| 90 | private $witnessKeyHash; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @var TransactionInterface |
||
| 94 | */ |
||
| 95 | private $tx; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * @var int |
||
| 99 | */ |
||
| 100 | private $nInput; |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @var TransactionOutputInterface |
||
| 104 | */ |
||
| 105 | private $txOut; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * @var PublicKeyInterface[] |
||
| 109 | */ |
||
| 110 | private $publicKeys = []; |
||
| 111 | |||
| 112 | /** |
||
| 113 | * @var TransactionSignatureInterface[] |
||
| 114 | */ |
||
| 115 | private $signatures = []; |
||
| 116 | |||
| 117 | /** |
||
| 118 | * @var int |
||
| 119 | */ |
||
| 120 | private $requiredSigs = 0; |
||
| 121 | |||
| 122 | /** |
||
| 123 | * @var Interpreter |
||
| 124 | */ |
||
| 125 | private $interpreter; |
||
| 126 | |||
| 127 | /** |
||
| 128 | * @var Checker |
||
| 129 | */ |
||
| 130 | private $signatureChecker; |
||
| 131 | |||
| 132 | /** |
||
| 133 | * InputSigner constructor. |
||
| 134 | * @param EcAdapterInterface $ecAdapter |
||
| 135 | * @param TransactionInterface $tx |
||
| 136 | * @param $nInput |
||
| 137 | * @param TransactionOutputInterface $txOut |
||
| 138 | * @param SignData $signData |
||
| 139 | * @param TransactionSignatureSerializer|null $sigSerializer |
||
| 140 | * @param PublicKeySerializerInterface|null $pubKeySerializer |
||
| 141 | */ |
||
| 142 | 88 | public function __construct(EcAdapterInterface $ecAdapter, TransactionInterface $tx, $nInput, TransactionOutputInterface $txOut, SignData $signData, TransactionSignatureSerializer $sigSerializer = null, PublicKeySerializerInterface $pubKeySerializer = null) |
|
| 164 | |||
| 165 | /** |
||
| 166 | * A snipped from OP_CHECKMULTISIG - verifies signatures according to the |
||
| 167 | * order of the given public keys (taken from the script). |
||
| 168 | * |
||
| 169 | * @param ScriptInterface $script |
||
| 170 | * @param BufferInterface[] $signatures |
||
| 171 | * @param BufferInterface[] $publicKeys |
||
| 172 | * @param int $sigVersion |
||
| 173 | * @return \SplObjectStorage |
||
| 174 | */ |
||
| 175 | 10 | private function sortMultisigs(ScriptInterface $script, array $signatures, array $publicKeys, $sigVersion) |
|
| 176 | { |
||
| 177 | 10 | $sigCount = count($signatures); |
|
| 178 | 10 | $keyCount = count($publicKeys); |
|
| 179 | 10 | $ikey = $isig = 0; |
|
| 180 | 10 | $fSuccess = true; |
|
| 181 | 10 | $result = new \SplObjectStorage; |
|
| 182 | |||
| 183 | 10 | while ($fSuccess && $sigCount > 0) { |
|
| 184 | // Fetch the signature and public key |
||
| 185 | 10 | $sig = $signatures[$isig]; |
|
| 186 | 10 | $pubkey = $publicKeys[$ikey]; |
|
| 187 | |||
| 188 | 10 | if ($this->signatureChecker->checkSig($script, $sig, $pubkey, $sigVersion, $this->flags)) { |
|
| 189 | 10 | $result[$pubkey] = $sig; |
|
| 190 | 10 | $isig++; |
|
| 191 | 10 | $sigCount--; |
|
| 192 | } |
||
| 193 | |||
| 194 | 10 | $ikey++; |
|
| 195 | 10 | $keyCount--; |
|
| 196 | |||
| 197 | // If there are more signatures left than keys left, |
||
| 198 | // then too many signatures have failed. Exit early, |
||
| 199 | // without checking any further signatures. |
||
| 200 | 10 | if ($sigCount > $keyCount) { |
|
| 201 | $fSuccess = false; |
||
| 202 | } |
||
| 203 | } |
||
| 204 | |||
| 205 | 10 | return $result; |
|
| 206 | } |
||
| 207 | |||
| 208 | /** |
||
| 209 | * @param ScriptInterface $script |
||
| 210 | * @return \BitWasp\Buffertools\BufferInterface[] |
||
| 211 | */ |
||
| 212 | 68 | private function evalPushOnly(ScriptInterface $script) |
|
| 213 | { |
||
| 214 | 68 | $stack = new Stack(); |
|
| 215 | 68 | $this->interpreter->evaluate($script, $stack, SigHash::V0, $this->flags | Interpreter::VERIFY_SIGPUSHONLY, $this->signatureChecker); |
|
| 216 | 68 | return $stack->all(); |
|
| 217 | } |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Create a script consisting only of push-data operations. |
||
| 221 | * Suitable for a scriptSig. |
||
| 222 | * |
||
| 223 | * @param BufferInterface[] $buffers |
||
| 224 | * @return ScriptInterface |
||
| 225 | */ |
||
| 226 | private function pushAll(array $buffers) |
||
| 227 | { |
||
| 228 | 50 | return ScriptFactory::sequence(array_map(function ($buffer) { |
|
| 229 | 42 | if (!($buffer instanceof BufferInterface)) { |
|
| 230 | throw new \RuntimeException('Script contained a non-push opcode'); |
||
| 231 | } |
||
| 232 | |||
| 233 | 42 | $size = $buffer->getSize(); |
|
| 234 | 42 | if ($size === 0) { |
|
| 235 | 4 | return Opcodes::OP_0; |
|
| 236 | } |
||
| 237 | |||
| 238 | 42 | $first = ord($buffer->getBinary()); |
|
| 239 | 42 | if ($size === 1 && $first >= 1 && $first <= 16) { |
|
| 240 | return \BitWasp\Bitcoin\Script\encodeOpN($first); |
||
| 241 | } else { |
||
| 242 | 42 | return $buffer; |
|
| 243 | } |
||
| 244 | 50 | }, $buffers)); |
|
| 245 | } |
||
| 246 | |||
| 247 | /** |
||
| 248 | * Verify a scriptSig / scriptWitness against a scriptPubKey. |
||
| 249 | * Useful for checking the outcome of certain things, like hash locks (p2sh) |
||
| 250 | * |
||
| 251 | * @param int $flags |
||
| 252 | * @param ScriptInterface $scriptSig |
||
| 253 | * @param ScriptInterface $scriptPubKey |
||
| 254 | * @param ScriptWitnessInterface|null $scriptWitness |
||
| 255 | * @return bool |
||
| 256 | */ |
||
| 257 | 26 | private function verifySolution($flags, ScriptInterface $scriptSig, ScriptInterface $scriptPubKey, ScriptWitnessInterface $scriptWitness = null) |
|
| 261 | |||
| 262 | /** |
||
| 263 | * Evaluates a scriptPubKey against the provided chunks. |
||
| 264 | * |
||
| 265 | * @param ScriptInterface $scriptPubKey |
||
| 266 | * @param array $chunks |
||
| 267 | * @param int $sigVersion |
||
| 268 | * @return bool |
||
| 269 | */ |
||
| 270 | 56 | private function evaluateSolution(ScriptInterface $scriptPubKey, array $chunks, $sigVersion) |
|
| 287 | |||
| 288 | /** |
||
| 289 | * This function is strictly for $canSign types. |
||
| 290 | * It will extract signatures/publicKeys when given $outputData, and $stack. |
||
| 291 | * $stack is the result of decompiling a scriptSig, or taking the witness data. |
||
| 292 | * |
||
| 293 | * @param OutputData $outputData |
||
| 294 | * @param array $stack |
||
| 295 | * @param int $sigVersion |
||
| 296 | * @return string |
||
| 297 | */ |
||
| 298 | 64 | public function extractFromValues(OutputData $outputData, array $stack, $sigVersion) |
|
| 356 | |||
| 357 | /** |
||
| 358 | * Checks $chunks (a decompiled scriptSig) for it's last element, |
||
| 359 | * or defers to SignData. If both are provided, it checks the |
||
| 360 | * value from $chunks against SignData. |
||
| 361 | * |
||
| 362 | * @param BufferInterface[] $chunks |
||
| 363 | * @param SignData $signData |
||
| 364 | * @return ScriptInterface |
||
| 365 | */ |
||
| 366 | 30 | private function findRedeemScript(array $chunks, SignData $signData) |
|
| 389 | |||
| 390 | /** |
||
| 391 | * Checks $witness (a witness structure) for it's last element, |
||
| 392 | * or defers to SignData. If both are provided, it checks the |
||
| 393 | * value from $chunks against SignData. |
||
| 394 | * |
||
| 395 | * @param BufferInterface[] $witness |
||
| 396 | * @param SignData $signData |
||
| 397 | * @return ScriptInterface |
||
| 398 | */ |
||
| 399 | 26 | private function findWitnessScript(array $witness, SignData $signData) |
|
| 422 | |||
| 423 | /** |
||
| 424 | * Called upon instance creation. |
||
| 425 | * |
||
| 426 | * It ensures that violating the following prevents instance creation |
||
| 427 | * - the scriptPubKey can be directly signed, or leads to P2SH/P2WSH/P2WKH |
||
| 428 | * - the P2SH script covers signable types and P2WSH/P2WKH |
||
| 429 | * - the witnessScript covers signable types only |
||
| 430 | * |
||
| 431 | * @param SignData $signData |
||
| 432 | * @param ScriptInterface $scriptPubKey |
||
| 433 | * @param ScriptInterface $scriptSig |
||
| 434 | * @param BufferInterface[] $witness |
||
| 435 | * @return $this |
||
| 436 | */ |
||
| 437 | 86 | private function solve(SignData $signData, ScriptInterface $scriptPubKey, ScriptInterface $scriptSig, array $witness) |
|
| 494 | |||
| 495 | /** |
||
| 496 | * @param ScriptInterface $scriptCode |
||
| 497 | * @param int $sigHashType |
||
| 498 | * @param int $sigVersion |
||
| 499 | * @return BufferInterface |
||
| 500 | */ |
||
| 501 | 52 | public function calculateSigHashUnsafe(ScriptInterface $scriptCode, $sigHashType, $sigVersion) |
|
| 509 | |||
| 510 | /** |
||
| 511 | * @param int $sigHashType |
||
| 512 | * @return BufferInterface |
||
| 513 | */ |
||
| 514 | 2 | public function getSigHash($sigHashType) |
|
| 518 | |||
| 519 | /** |
||
| 520 | * @param PrivateKeyInterface $key |
||
| 521 | * @param ScriptInterface $scriptCode |
||
| 522 | * @param int $sigHashType |
||
| 523 | * @param int $sigVersion |
||
| 524 | * @return TransactionSignatureInterface |
||
| 525 | */ |
||
| 526 | 50 | private function calculateSignature(PrivateKeyInterface $key, ScriptInterface $scriptCode, $sigHashType, $sigVersion) |
|
| 532 | |||
| 533 | /** |
||
| 534 | * @return bool |
||
| 535 | */ |
||
| 536 | 56 | public function isFullySigned() |
|
| 540 | |||
| 541 | /** |
||
| 542 | * @return int |
||
| 543 | */ |
||
| 544 | 50 | public function getRequiredSigs() |
|
| 548 | |||
| 549 | /** |
||
| 550 | * @return TransactionSignatureInterface[] |
||
| 551 | */ |
||
| 552 | 50 | public function getSignatures() |
|
| 556 | |||
| 557 | /** |
||
| 558 | * @return PublicKeyInterface[] |
||
| 559 | */ |
||
| 560 | 50 | public function getPublicKeys() |
|
| 564 | |||
| 565 | /** |
||
| 566 | * Sign the input using $key and $sigHashTypes |
||
| 567 | * |
||
| 568 | * @param PrivateKeyInterface $key |
||
| 569 | * @param int $sigHashType |
||
| 570 | * @return $this |
||
| 571 | */ |
||
| 572 | 56 | public function sign(PrivateKeyInterface $key, $sigHashType = SigHash::ALL) |
|
| 611 | |||
| 612 | /** |
||
| 613 | * Verifies the input using $flags for script verification |
||
| 614 | * |
||
| 615 | * @param int $flags |
||
| 616 | * @return bool |
||
| 617 | */ |
||
| 618 | 50 | public function verify($flags = null) |
|
| 652 | |||
| 653 | /** |
||
| 654 | * Produces the script stack that solves the $outputType |
||
| 655 | * |
||
| 656 | * @param string $outputType |
||
| 657 | * @return BufferInterface[] |
||
| 658 | */ |
||
| 659 | 50 | private function serializeSolution($outputType) |
|
| 683 | |||
| 684 | /** |
||
| 685 | * Produces a SigValues instance containing the scriptSig & script witness |
||
| 686 | * |
||
| 687 | * @return SigValues |
||
| 688 | */ |
||
| 689 | 50 | public function serializeSignatures() |
|
| 729 | } |
||
| 730 |
Loading history...
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: