Complex classes like HierarchicalKey often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HierarchicalKey, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class HierarchicalKey |
||
| 24 | { |
||
| 25 | /** |
||
| 26 | * @var EcAdapterInterface |
||
| 27 | */ |
||
| 28 | protected $ecAdapter; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * @var int |
||
| 32 | */ |
||
| 33 | private $depth; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @var int |
||
| 37 | */ |
||
| 38 | private $parentFingerprint; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var int |
||
| 42 | */ |
||
| 43 | private $sequence; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @var BufferInterface |
||
| 47 | */ |
||
| 48 | private $chainCode; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @var KeyInterface |
||
| 52 | */ |
||
| 53 | private $key; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @var ScriptDataFactory |
||
| 57 | */ |
||
| 58 | private $scriptDataFactory; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @var ScriptAndSignData|null |
||
| 62 | */ |
||
| 63 | private $scriptAndSignData; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * @param EcAdapterInterface $ecAdapter |
||
| 67 | * @param ScriptDataFactory $scriptDataFactory |
||
| 68 | * @param int $depth |
||
| 69 | * @param int $parentFingerprint |
||
| 70 | * @param int $sequence |
||
| 71 | * @param BufferInterface $chainCode |
||
| 72 | * @param KeyInterface $key |
||
| 73 | */ |
||
| 74 | 73 | public function __construct(EcAdapterInterface $ecAdapter, ScriptDataFactory $scriptDataFactory, int $depth, int $parentFingerprint, int $sequence, BufferInterface $chainCode, KeyInterface $key) |
|
| 104 | |||
| 105 | /** |
||
| 106 | * Return the depth of this key. This is limited to 256 sequential derivations. |
||
| 107 | * |
||
| 108 | * @return int |
||
| 109 | */ |
||
| 110 | 30 | public function getDepth(): int |
|
| 114 | |||
| 115 | /** |
||
| 116 | * Get the sequence number for this address. Hardened keys are |
||
| 117 | * created with sequence > 0x80000000. a sequence number lower |
||
| 118 | * than this can be derived with the public key. |
||
| 119 | * |
||
| 120 | * @return int |
||
| 121 | */ |
||
| 122 | 25 | public function getSequence(): int |
|
| 126 | |||
| 127 | /** |
||
| 128 | * Get the fingerprint of the parent key. For master keys, this is 00000000. |
||
| 129 | * |
||
| 130 | * @return int |
||
| 131 | */ |
||
| 132 | 26 | public function getFingerprint(): int |
|
| 140 | |||
| 141 | /** |
||
| 142 | * Return the fingerprint to be used for child keys. |
||
| 143 | * @return int |
||
| 144 | */ |
||
| 145 | 33 | public function getChildFingerprint(): int |
|
| 150 | |||
| 151 | /** |
||
| 152 | * Return the chain code - a deterministic 'salt' for HMAC-SHA512 |
||
| 153 | * in child derivations |
||
| 154 | * |
||
| 155 | * @return BufferInterface |
||
| 156 | */ |
||
| 157 | 24 | public function getChainCode(): BufferInterface |
|
| 161 | |||
| 162 | /** |
||
| 163 | * @return PrivateKeyInterface |
||
| 164 | */ |
||
| 165 | 42 | public function getPrivateKey(): PrivateKeyInterface |
|
| 175 | |||
| 176 | /** |
||
| 177 | * Get the public key the private key or public key. |
||
| 178 | * |
||
| 179 | * @return PublicKeyInterface |
||
| 180 | */ |
||
| 181 | 44 | public function getPublicKey(): PublicKeyInterface |
|
| 191 | |||
| 192 | /** |
||
| 193 | * @return HierarchicalKey |
||
| 194 | */ |
||
| 195 | 21 | public function withoutPrivateKey(): HierarchicalKey |
|
| 201 | |||
| 202 | /** |
||
| 203 | * @return ScriptDataFactory |
||
| 204 | */ |
||
| 205 | 26 | public function getScriptDataFactory() |
|
| 209 | |||
| 210 | /** |
||
| 211 | * @return \BitWasp\Bitcoin\Key\KeyToScript\ScriptAndSignData |
||
| 212 | */ |
||
| 213 | 22 | public function getScriptAndSignData() |
|
| 221 | |||
| 222 | /** |
||
| 223 | * @param BaseAddressCreator $addressCreator |
||
| 224 | * @return \BitWasp\Bitcoin\Address\Address |
||
| 225 | */ |
||
| 226 | 16 | public function getAddress(BaseAddressCreator $addressCreator) |
|
| 230 | |||
| 231 | /** |
||
| 232 | * Return whether this is a private key |
||
| 233 | * |
||
| 234 | * @return bool |
||
| 235 | */ |
||
| 236 | 48 | public function isPrivate(): bool |
|
| 240 | |||
| 241 | /** |
||
| 242 | * Return whether the key is hardened |
||
| 243 | * |
||
| 244 | * @return bool |
||
| 245 | */ |
||
| 246 | 2 | public function isHardened(): bool |
|
| 250 | |||
| 251 | /** |
||
| 252 | * Create a buffer containing data to be hashed hashed to yield the child offset |
||
| 253 | * |
||
| 254 | * @param int $sequence |
||
| 255 | * @return BufferInterface |
||
| 256 | * @throws \Exception |
||
| 257 | */ |
||
| 258 | 39 | public function getHmacSeed(int $sequence): BufferInterface |
|
| 276 | |||
| 277 | /** |
||
| 278 | * Derive a child key |
||
| 279 | * |
||
| 280 | * @param int $sequence |
||
| 281 | * @return HierarchicalKey |
||
| 282 | * @throws \Exception |
||
| 283 | */ |
||
| 284 | 36 | public function deriveChild(int $sequence): HierarchicalKey |
|
| 312 | |||
| 313 | /** |
||
| 314 | * @param array|\stdClass|\Traversable $list |
||
| 315 | * @return HierarchicalKey |
||
| 316 | * @throws \Exception |
||
| 317 | */ |
||
| 318 | 26 | public function deriveFromList($list): HierarchicalKey |
|
| 331 | |||
| 332 | /** |
||
| 333 | * Decodes a BIP32 path into actual 32bit sequence numbers and derives the child key |
||
| 334 | * |
||
| 335 | * @param string $path |
||
| 336 | * @return HierarchicalKey |
||
| 337 | * @throws \Exception |
||
| 338 | */ |
||
| 339 | 26 | public function derivePath(string $path): HierarchicalKey |
|
| 344 | |||
| 345 | /** |
||
| 346 | * Serializes the instance according to whether it wraps a private or public key. |
||
| 347 | * @param NetworkInterface $network |
||
| 348 | * @return string |
||
| 349 | */ |
||
| 350 | 16 | public function toExtendedKey(NetworkInterface $network = null): string |
|
| 358 | |||
| 359 | /** |
||
| 360 | * Explicitly serialize as a private key. Throws an exception if |
||
| 361 | * the key isn't private. |
||
| 362 | * |
||
| 363 | * @param NetworkInterface $network |
||
| 364 | * @return string |
||
| 365 | */ |
||
| 366 | 16 | public function toExtendedPrivateKey(NetworkInterface $network = null): string |
|
| 374 | |||
| 375 | /** |
||
| 376 | * Explicitly serialize as a public key. This will always work. |
||
| 377 | * |
||
| 378 | * @param NetworkInterface $network |
||
| 379 | * @return string |
||
| 380 | */ |
||
| 381 | 13 | public function toExtendedPublicKey(NetworkInterface $network = null): string |
|
| 385 | } |
||
| 386 |
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.