Script - Code Metrics - Inspection of "Merge pull request #239 from afk11/segwit" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 407a4a...aa6067 )

by thomas

created 2016-02-04 00:31 UTC

Script B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	221
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	14

Test Coverage

Coverage

100%

Importance

Changes	9
Bugs	1	Features	2

Metric	Value
wmc	44
c	9
b	1
f	2
lcom	1
cbo	14
dl	0
loc	221
ccs	58
cts	58
cp	1
rs	8.3396

11 Methods

Rating	Name	Size	Complexity
A	__construct()	5	3
A	getBuffer()	4	1
A	getScriptParser()	4	1
A	getOpCodes()	4	1
A	getScriptHash()	4	1
C	countSigOps()	31	11
B	witnessSigOps()	16	5
B	countWitnessSigOps()	21	5
B	countP2shSigOps()	28	6
A	isPushOnly()	8	2
C	isWitness()	27	8

How to fix Complexity

<?php

namespace BitWasp\Bitcoin\Script;

use BitWasp\Bitcoin\Bitcoin;
use BitWasp\Bitcoin\Script\Classifier\OutputClassifier;
use BitWasp\Bitcoin\Script\Interpreter\InterpreterInterface;
use BitWasp\Bitcoin\Script\Parser\Parser;
use BitWasp\Buffertools\Buffer;
use BitWasp\Bitcoin\Crypto\Hash;
use BitWasp\Bitcoin\Serializable;
use BitWasp\Buffertools\BufferInterface;

class Script extends Serializable implements ScriptInterface
{

    /**
     * @var Opcodes
     */
    protected $opCodes;

    /**
     * @var string
     */
    protected $script;

    /**
     * @param BufferInterface $script
     * @param Opcodes|null $opCodes
     */
    public function __construct(BufferInterface $script = null, Opcodes $opCodes = null)
    {
        $this->script = $script instanceof BufferInterface ? $script->getBinary() : '';
        $this->opCodes = $opCodes ?: new Opcodes();
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer()
    {
        return new Buffer($this->script);
    }

    /**
     * @return Parser
     */
    public function getScriptParser()
    {
        return new Parser(Bitcoin::getMath(), $this);
    }

    /**
     * Get all opcodes
     *
     * @return Opcodes
     */
    public function getOpCodes()
    {
        return $this->opCodes;
    }

    /**
     * Return a buffer containing the hash of this script.
     *
     * @return BufferInterface
     */
    public function getScriptHash()
    {
        return Hash::sha256ripe160($this->getBuffer());
    }

    /**
     * @param bool|true $accurate
     * @return int
     */
    public function countSigOps($accurate = true)
    {
        $count = 0;
        $parser = $this->getScriptParser();

        $lastOp = 0xff;
        foreach ($parser as $exec) {
            if ($exec->isPush()) {
                continue;
            }

            $op = $exec->getOp();
            if ($op > Opcodes::OP_PUSHDATA4) {
                // None of these are pushdatas, so just an opcode
                if ($op === Opcodes::OP_CHECKSIG || $op === Opcodes::OP_CHECKSIGVERIFY) {
                    $count++;
                } elseif ($op === Opcodes::OP_CHECKMULTISIG || $op === Opcodes::OP_CHECKMULTISIGVERIFY) {
                    if ($accurate && ($lastOp >= Opcodes::OP_1 && $lastOp <= Opcodes::OP_16)) {
                        $c = ($lastOp - (Opcodes::OP_1 - 1));
                        $count += $c;
                    } else {
                        $count += 20;
                    }
                }

                $lastOp = $op;
            }
        }

        return $count;
    }

    /**
     * @param WitnessProgram $program
     * @return int
     */
    private function witnessSigOps(WitnessProgram $program, ScriptWitnessInterface $scriptWitness)
    {
        if ($program->getVersion() == 0) {
            $size = $program->getProgram()->getSize();
            if ($size === 32 && count($scriptWitness) > 0) {
                $script = new Script($scriptWitness->bottom());
                return $script->countSigOps(true);
            }

            if ($size === 20) {
                return 1;
            }
        }

        return 0;
    }

    /**
     * @param ScriptInterface $scriptSig
     * @param ScriptWitnessInterface $scriptWitness
     * @param int $flags
     * @return int
     */
    public function countWitnessSigOps(ScriptInterface $scriptSig, ScriptWitnessInterface $scriptWitness, $flags)
    {
        if ($flags & InterpreterInterface::VERIFY_WITNESS === 0) {
            return 0;
        }

        $program = null;
        if ($this->isWitness($program)) {
            return $this->witnessSigOps($program, $scriptWitness);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }

        if ((new OutputClassifier($this))->isPayToScriptHash()) {
            $parsed = $scriptSig->getScriptParser()->decode();
            $subscript = new Script(end($parsed)->getData());
            if ($subscript->isWitness($program)) {
                return $this->witnessSigOps($program, $scriptWitness);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            }
        }

        return 0;
    }

    /**
     * @param ScriptInterface $scriptSig
     * @return int
     */
    public function countP2shSigOps(ScriptInterface $scriptSig)
    {
        if (ScriptFactory::scriptPubKey()
            ->classify($this)
            ->isPayToScriptHash() === false
        ) {
            return $this->countSigOps(true);
        }

        $parser = $scriptSig->getScriptParser();

        $data = null;
        foreach ($parser as $exec) {
            if ($exec->getOp() > Opcodes::OP_16) {
                return 0;
            }

            if ($exec->isPush()) {
                $data = $exec->getData();
            }
        }

        if (!$data instanceof BufferInterface) {
            return 0;
        }

        return (new Script($data))->countSigOps(true);
    }

    /**
     * @return bool
     */
    public function isPushOnly()
    {
        $pushOnly = true;
        foreach ($this->getScriptParser()->decode() as $entity) {
            $pushOnly &= $entity->isPush();
        }
        return $pushOnly;
    }

    /**
     * @param WitnessProgram|null $program
     * @return bool
     */
    public function isWitness(WitnessProgram & $program = null)
    {
        $buffer = $this->getBuffer();
        $size = $buffer->getSize();
        if ($size < 4 || $size > 34) {
            return false;
        }

        $parser = $this->getScriptParser();
        $script = $parser->decode();
        if (!$script[1]->isPush()) {
            return false;
        }

        $version = $script[0]->getOp();
        if ($version != Opcodes::OP_0 && ($version < Opcodes::OP_1 || $version > Opcodes::OP_16)) {
            return false;
        }

        $witness = $script[1];
        if ($size === $witness->getDataSize() + 2) {
            $program = new WitnessProgram(decodeOpN($version), $witness->getData());
            return true;
        }

        return false;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script;
4
5		use BitWasp\Bitcoin\Bitcoin;
6		use BitWasp\Bitcoin\Script\Classifier\OutputClassifier;
7		use BitWasp\Bitcoin\Script\Interpreter\InterpreterInterface;
8		use BitWasp\Bitcoin\Script\Parser\Parser;
9		use BitWasp\Buffertools\Buffer;
10		use BitWasp\Bitcoin\Crypto\Hash;
11		use BitWasp\Bitcoin\Serializable;
12		use BitWasp\Buffertools\BufferInterface;
13
14		class Script extends Serializable implements ScriptInterface
15		{
16
17		/**
18		* @var Opcodes
19		*/
20		protected $opCodes;
21
22		/**
23		* @var string
24		*/
25		protected $script;
26
27		/**
28		* @param BufferInterface $script
29	1666	* @param Opcodes\|null $opCodes
30		*/
31	1666	public function __construct(BufferInterface $script = null, Opcodes $opCodes = null)
32	1666	{
33	1666	$this->script = $script instanceof BufferInterface ? $script->getBinary() : '';
34		$this->opCodes = $opCodes ?: new Opcodes();
35		}
36
37		/**
38	1444	* @return BufferInterface
39		*/
40	1444	public function getBuffer()
41		{
42		return new Buffer($this->script);
43		}
44
45		/**
46	1114	* @return Parser
47		*/
48	1114	public function getScriptParser()
49		{
50		return new Parser(Bitcoin::getMath(), $this);
51		}
52
53		/**
54		* Get all opcodes
55		*
56	672	* @return Opcodes
57		*/
58	672	public function getOpCodes()
59		{
60		return $this->opCodes;
61		}
62
63		/**
64		* Return a buffer containing the hash of this script.
65		*
66	162	* @return BufferInterface
67		*/
68	162	public function getScriptHash()
69		{
70		return Hash::sha256ripe160($this->getBuffer());
71		}
72
73		/**
74		* @param bool\|true $accurate
75	48	* @return int
76		*/
77	48	public function countSigOps($accurate = true)
78	48	{
79		$count = 0;
80	48	$parser = $this->getScriptParser();
81	48
82	36	$lastOp = 0xff;
83	36	foreach ($parser as $exec) {
84		if ($exec->isPush()) {
85		continue;
86	36	}
87	36
88		$op = $exec->getOp();
89	36	if ($op > Opcodes::OP_PUSHDATA4) {
90	24	// None of these are pushdatas, so just an opcode
91	36	if ($op === Opcodes::OP_CHECKSIG \|\| $op === Opcodes::OP_CHECKSIGVERIFY) {
92	30	$count++;
93	24	} elseif ($op === Opcodes::OP_CHECKMULTISIG \|\| $op === Opcodes::OP_CHECKMULTISIGVERIFY) {
94	24	if ($accurate && ($lastOp >= Opcodes::OP_1 && $lastOp <= Opcodes::OP_16)) {
95	24	$c = ($lastOp - (Opcodes::OP_1 - 1));
96	12	$count += $c;
97		} else {
98	30	$count += 20;
99		}
100	36	}
101	36
102	48	$lastOp = $op;
103		}
104	48	}
105
106		return $count;
107		}
108
109		/**
110		* @param WitnessProgram $program
111	18	* @return int
112		*/
113	18	private function witnessSigOps(WitnessProgram $program, ScriptWitnessInterface $scriptWitness)
114	18	{
115	18	if ($program->getVersion() == 0) {
116	18	$size = $program->getProgram()->getSize();
117	6	if ($size === 32 && count($scriptWitness) > 0) {
118		$script = new Script($scriptWitness->bottom());
119		return $script->countSigOps(true);
120	18	}
121
122	18	if ($size === 20) {
123	18	return 1;
124	18	}
125	6	}
126
127		return 0;
128	12	}
129	12
130	12	/**
131	18	* @param ScriptInterface $scriptSig
132		* @param ScriptWitnessInterface $scriptWitness
133	18	* @param int $flags
134	6	* @return int
135		*/
136		public function countWitnessSigOps(ScriptInterface $scriptSig, ScriptWitnessInterface $scriptWitness, $flags)
137	12	{
138		if ($flags & InterpreterInterface::VERIFY_WITNESS === 0) {
139		return 0;
140		}
141
142		$program = null;
143	18	if ($this->isWitness($program)) {
144		return $this->witnessSigOps($program, $scriptWitness);
		0 ignored issues – show Bug introduced 2016-02-03 03:56 UTC by Report Bug Copy Issue Report It seems like `$program` defined by `null` on line `142` can be `null`; however, `BitWasp\Bitcoin\Script\Script::witnessSigOps()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
145	18	}
146	18
147	18	if ((new OutputClassifier($this))->isPayToScriptHash()) {
148	18	$parsed = $scriptSig->getScriptParser()->decode();
149	18	$subscript = new Script(end($parsed)->getData());
150		if ($subscript->isWitness($program)) {
151		return $this->witnessSigOps($program, $scriptWitness);
		0 ignored issues – show Bug introduced 2016-02-03 03:56 UTC by Report Bug Copy Issue Report It seems like `$program` defined by `null` on line `142` can be `null`; however, `BitWasp\Bitcoin\Script\Script::witnessSigOps()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
152		}
153		}
154
155		return 0;
156		}
157
158		/**
159		* @param ScriptInterface $scriptSig
160		* @return int
161		*/
162		public function countP2shSigOps(ScriptInterface $scriptSig)
163		{
164		if (ScriptFactory::scriptPubKey()
165		->classify($this)
166		->isPayToScriptHash() === false
167		) {
168		return $this->countSigOps(true);
169		}
170
171		$parser = $scriptSig->getScriptParser();
172
173		$data = null;
174		foreach ($parser as $exec) {
175		if ($exec->getOp() > Opcodes::OP_16) {
176		return 0;
177		}
178
179		if ($exec->isPush()) {
180		$data = $exec->getData();
181		}
182		}
183
184		if (!$data instanceof BufferInterface) {
185		return 0;
186		}
187
188		return (new Script($data))->countSigOps(true);
189		}
190
191		/**
192		* @return bool
193		*/
194		public function isPushOnly()
195		{
196		$pushOnly = true;
197		foreach ($this->getScriptParser()->decode() as $entity) {
198		$pushOnly &= $entity->isPush();
199		}
200		return $pushOnly;
201		}
202
203		/**
204		* @param WitnessProgram\|null $program
205		* @return bool
206		*/
207		public function isWitness(WitnessProgram & $program = null)
208		{
209		$buffer = $this->getBuffer();
210		$size = $buffer->getSize();
211		if ($size < 4 \|\| $size > 34) {
212		return false;
213		}
214
215		$parser = $this->getScriptParser();
216		$script = $parser->decode();
217		if (!$script[1]->isPush()) {
218		return false;
219		}
220
221		$version = $script[0]->getOp();
222		if ($version != Opcodes::OP_0 && ($version < Opcodes::OP_1 \|\| $version > Opcodes::OP_16)) {
223		return false;
224		}
225
226		$witness = $script[1];
227		if ($size === $witness->getDataSize() + 2) {
228		$program = new WitnessProgram(decodeOpN($version), $witness->getData());
229		return true;
230		}
231
232		return false;
233		}
234		}
235

Bit-Wasp / bitcoin-php

Push — master ( 407a4a...aa6067 )

Script B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

11 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like