ScriptWitnessSerializer::fromParser() - Code Metrics - Inspection of "TransactionInterface: add getBaseSerialization & g..." - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#446)

by thomas

created 2017-01-20 14:35 UTC

ScriptWitnessSerializer::fromParser() A

↳ Parent: ScriptWitnessSerializer

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	2
dl	0
loc	10
ccs	0
cts	6
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Serializer\Script;

use BitWasp\Bitcoin\Script\ScriptWitness;
use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
use BitWasp\Bitcoin\Serializer\Types;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\Buffertools\Buffertools;
use BitWasp\Buffertools\Parser;
use BitWasp\Buffertools\Template;

class ScriptWitnessSerializer
{
    /**
     * @var Template
     */
    private $varstring;

    public function __construct()
    {
        $this->varstring = Types::varstring();

    }

    /**
     * @param Parser $parser
     * @param $size
     * @return ScriptWitness
     */
    public function fromParser(Parser $parser, $size)
    {
        $entries = [];
        for ($j = 0; $j < $size; $j++) {
            $data = $this->varstring->parse($parser);
            $entries[] = $data;
        }

        return new ScriptWitness($entries);
    }

    /**
     * @param ScriptWitnessInterface $witness
     * @return BufferInterface
     */
    public function serialize(ScriptWitnessInterface $witness)
    {
        $parser = new Parser();
        $parser->appendBuffer(Buffertools::numToVarInt($witness->count()));

        foreach ($witness as $value) {
            $parser->appendBuffer(new Buffer($this->varstring->write($value)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $parser->getBuffer();
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Serializer\Script;
4
5		use BitWasp\Bitcoin\Script\ScriptWitness;
6		use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
7		use BitWasp\Bitcoin\Serializer\Types;
8		use BitWasp\Buffertools\Buffer;
9		use BitWasp\Buffertools\BufferInterface;
10		use BitWasp\Buffertools\Buffertools;
11		use BitWasp\Buffertools\Parser;
12		use BitWasp\Buffertools\Template;
13
14		class ScriptWitnessSerializer
15		{
16		/**
17		* @var Template
18		*/
19		private $varstring;
20
21	1332	public function __construct()
22		{
23	1332	$this->varstring = Types::varstring();
		0 ignored issues – show Documentation Bug introduced 2017-01-20 02:25 UTC by Report Bug Copy Issue Report It seems like `\BitWasp\Bitcoin\Serializer\Types::varstring()` of type `object<BitWasp\Buffertools\Types\VarString>` is incompatible with the declared type `object<BitWasp\Buffertools\Template>` of property `$varstring`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24	1332	}
25
26		/**
27		* @param Parser $parser
28		* @param $size
29		* @return ScriptWitness
30		*/
31		public function fromParser(Parser $parser, $size)
32		{
33		$entries = [];
34		for ($j = 0; $j < $size; $j++) {
35		$data = $this->varstring->parse($parser);
36		$entries[] = $data;
37		}
38
39		return new ScriptWitness($entries);
40		}
41
42		/**
43		* @param ScriptWitnessInterface $witness
44		* @return BufferInterface
45		*/
46	22	public function serialize(ScriptWitnessInterface $witness)
47		{
48	22	$parser = new Parser();
49	22	$parser->appendBuffer(Buffertools::numToVarInt($witness->count()));
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The method `appendBuffer()` does not seem to exist on `object<BitWasp\Buffertools\Parser>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50	22	foreach ($witness as $value) {
51	22	$parser->appendBuffer(new Buffer($this->varstring->write($value)));
		0 ignored issues – show Documentation introduced 2017-01-20 02:25 UTC by Report Bug Copy Issue Report `$this->varstring->write($value)` is of type `object<BitWasp\Buffertools\Buffer>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2017-01-20 02:25 UTC by Report Bug Copy Issue Report The method `appendBuffer()` does not seem to exist on `object<BitWasp\Buffertools\Parser>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52		}
53
54	22	return $parser->getBuffer();
55		}
56		}
57

Bit-Wasp / bitcoin-php

Pull Request — master (#446)

ScriptWitnessSerializer::fromParser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like