P2shScript::__construct() - Code Metrics - Inspection of "WitnessScript helper class" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#476)

by thomas

created 2017-03-09 09:06 UTC

P2shScript::__construct() A

↳ Parent: P2shScript

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	9
c	2
b	0
f	0
nc	3
nop	2
dl	0
loc	13
ccs	10
cts	10
cp	1
crap	3
rs	9.4285

<?php

namespace BitWasp\Bitcoin\Script;

use BitWasp\Bitcoin\Address\ScriptHashAddress;
use BitWasp\Bitcoin\Exceptions\P2shScriptException;

class P2shScript extends Script
{

    /**
     * @var ScriptHashAddress
     */
    private $address;

    /**
     * @var ScriptInterface
     */
    private $outputScript;

    /**
     * P2shScript constructor.
     * @param ScriptInterface $script
     * @param Opcodes|null $opcodes
     * @throws P2shScriptException
     */
    public function __construct(ScriptInterface $script, Opcodes $opcodes = null)
    {
        if ($script instanceof WitnessScript) {
            $script = $script->getOutputScript();
        } else if ($script instanceof self) {
            throw new P2shScriptException("Cannot nest P2SH scripts.");
        }

        parent::__construct($script->getBuffer(), $opcodes);
        $this->scriptHash = $script->getScriptHash();
        $this->outputScript = ScriptFactory::scriptPubKey()->p2sh($this->scriptHash);
        $this->address = new ScriptHashAddress($this->scriptHash);
    }

    /**
     * @throws P2shScriptException
     */
    public function getWitnessScriptHash()
    {
        throw new P2shScriptException("Cannot compute witness-script-hash for a P2shScript");
    }

    /**
     * @return ScriptInterface
     */
    public function getOutputScript()
    {
        return $this->outputScript;
    }

    /**
     * @return \BitWasp\Bitcoin\Address\ScriptHashAddress
     */
    public function getAddress()
    {
        return $this->address;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script;
4
5		use BitWasp\Bitcoin\Address\ScriptHashAddress;
6		use BitWasp\Bitcoin\Exceptions\P2shScriptException;
7
8		class P2shScript extends Script
9		{
10
11		/**
12		* @var ScriptHashAddress
13		*/
14		private $address;
15
16		/**
17		* @var ScriptInterface
18		*/
19		private $outputScript;
20
21		/**
22		* P2shScript constructor.
23		* @param ScriptInterface $script
24		* @param Opcodes\|null $opcodes
25		* @throws P2shScriptException
26		*/
27	24	public function __construct(ScriptInterface $script, Opcodes $opcodes = null)
28		{
29	24	if ($script instanceof WitnessScript) {
30	4	$script = $script->getOutputScript();
31	20	} else if ($script instanceof self) {
32	2	throw new P2shScriptException("Cannot nest P2SH scripts.");
33		}
34
35	22	parent::__construct($script->getBuffer(), $opcodes);
36	22	$this->scriptHash = $script->getScriptHash();
37	22	$this->outputScript = ScriptFactory::scriptPubKey()->p2sh($this->scriptHash);
38	22	$this->address = new ScriptHashAddress($this->scriptHash);
39	22	}
40
41		/**
42		* @throws P2shScriptException
43		*/
44	2	public function getWitnessScriptHash()
45		{
46	2	throw new P2shScriptException("Cannot compute witness-script-hash for a P2shScript");
47		}
48
49		/**
50		* @return ScriptInterface
51		*/
52	8	public function getOutputScript()
53		{
54	8	return $this->outputScript;
55		}
56
57		/**
58		* @return \BitWasp\Bitcoin\Address\ScriptHashAddress
59		*/
60	10	public function getAddress()
61		{
62	10	return $this->address;
63		}
64		}
65

Bit-Wasp / bitcoin-php

Pull Request — master (#476)

P2shScript::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like