ScriptWitnessSerializer::serialize() - Code Metrics - Inspection of "TransactionInterface: add getBaseSerialization & g..." - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#446)

by thomas

created 2017-01-18 13:52 UTC

ScriptWitnessSerializer::serialize() A

↳ Parent: ScriptWitnessSerializer

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	10
ccs	0
cts	0
cp	0
crap	6
rs	9.4285

<?php

namespace BitWasp\Bitcoin\Serializer\Script;

use BitWasp\Bitcoin\Script\ScriptWitness;
use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
use BitWasp\Bitcoin\Serializer\Types;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\Buffertools\Buffertools;
use BitWasp\Buffertools\Parser;
use BitWasp\Buffertools\Template;

class ScriptWitnessSerializer
{
    /**
     * @var Template
     */
    private $template;

    public function __construct()
    {
        $this->template = new Template([
            Types::varstring()
        ]);
    }

    /**
     * @param Parser $parser
     * @param $size
     * @return ScriptWitness
     */
    public function fromParser(Parser $parser, $size)
    {
        $entries = [];
        for ($j = 0; $j < $size; $j++) {
            list ($data) = $this->template->parse($parser);
            $entries[] = $data;
        }

        return new ScriptWitness($entries);
    }

    /**
     * @param ScriptWitnessInterface $witness
     * @return BufferInterface
     */
    public function serialize(ScriptWitnessInterface $witness)
    {
        $parser = new Parser();
        $parser->appendBuffer(Buffertools::numToVarInt($witness->count()));

        foreach ($witness as $value) {
            $parser->appendBuffer($this->template->write([$value]));

        }

        return $parser->getBuffer();
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Serializer\Script;
4
5		use BitWasp\Bitcoin\Script\ScriptWitness;
6		use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
7		use BitWasp\Bitcoin\Serializer\Types;
8		use BitWasp\Buffertools\BufferInterface;
9		use BitWasp\Buffertools\Buffertools;
10		use BitWasp\Buffertools\Parser;
11		use BitWasp\Buffertools\Template;
12
13		class ScriptWitnessSerializer
14		{
15		/**
16		* @var Template
17		*/
18		private $template;
19
20		public function __construct()
21		{
22		$this->template = new Template([
23		Types::varstring()
24		]);
25		}
26
27		/**
28		* @param Parser $parser
29		* @param $size
30		* @return ScriptWitness
31		*/
32		public function fromParser(Parser $parser, $size)
33		{
34		$entries = [];
35		for ($j = 0; $j < $size; $j++) {
36	66	list ($data) = $this->template->parse($parser);
37		$entries[] = $data;
38	66	}
39	66
40	66	return new ScriptWitness($entries);
41		}
42	66
43	66	/**
44	66	* @param ScriptWitnessInterface $witness
45	33	* @return BufferInterface
46	66	*/
47		public function serialize(ScriptWitnessInterface $witness)
48		{
49		$parser = new Parser();
50		$parser->appendBuffer(Buffertools::numToVarInt($witness->count()));
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The method `appendBuffer()` does not seem to exist on `object<BitWasp\Buffertools\Parser>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
51		foreach ($witness as $value) {
52		$parser->appendBuffer($this->template->write([$value]));
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The method `appendBuffer()` does not seem to exist on `object<BitWasp\Buffertools\Parser>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53		}
54
55		return $parser->getBuffer();
56		}
57		}
58

Bit-Wasp / bitcoin-php

Pull Request — master (#446)

ScriptWitnessSerializer::serialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like