CompactSignature::__construct() - Code Metrics - Inspection of "phpstan: initial runs, and add to CI" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#745)

by thomas

created 2018-11-29 01:25 UTC

CompactSignature::__construct() A

↳ Parent: CompactSignature

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3.0015

Importance

Changes

Metric	Value
cc	3
nc	2
nop	4
dl	0
loc	24
ccs	17
cts	18
cp	0.9444
crap	3.0015
rs	9.536
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Signature;

use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Adapter\EcAdapter;
use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Serializer\Signature\CompactSignatureSerializer;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;

class CompactSignature extends Signature implements CompactSignatureInterface
{
    /**
     * @var resource
     */
    private $resource;

    /**
     * @var bool
     */
    private $compressed;

    /**
     * @var int
     */
    private $recid;

    /**
     * @var EcAdapter
     */
    private $ecAdapter;


    /**
     * @param EcAdapter $ecAdapter
     * @param resource $secp256k1_ecdsa_signature_t
     * @param int $recid
     * @param bool $compressed
     */
    public function __construct(EcAdapter $ecAdapter, $secp256k1_ecdsa_signature_t, int $recid, bool $compressed)
    {
        if (!is_resource($secp256k1_ecdsa_signature_t)
            || SECP256K1_TYPE_RECOVERABLE_SIG !== get_resource_type($secp256k1_ecdsa_signature_t)
        ) {
            throw new \RuntimeException('CompactSignature: must pass recoverable signature resource');
        }

        $ser = '';
        $recidout = 0;
        secp256k1_ecdsa_recoverable_signature_serialize_compact($ecAdapter->getContext(), $ser, $recidout, $secp256k1_ecdsa_signature_t);
        list ($r, $s) = array_map(
            function ($val) {
                return (new Buffer($val))->getGmp();
            },
            str_split($ser, 32)
        );

        $this->resource = $secp256k1_ecdsa_signature_t;
        $this->recid = $recid;
        $this->compressed = $compressed;
        $this->ecAdapter = $ecAdapter;
        parent::__construct($ecAdapter, $r, $s, $secp256k1_ecdsa_signature_t);
    }

    /**
     * @return Signature
     */
    public function convert(): Signature
    {
        $sig_t = '';
        /** @var resource $sig_t */
        secp256k1_ecdsa_recoverable_signature_convert($this->ecAdapter->getContext(), $sig_t, $this->resource);
        return new Signature($this->ecAdapter, $this->getR(), $this->getS(), $sig_t);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @return resource
     */
    public function getResource()
    {
        return $this->resource;
    }

    /**
     * @return int
     */
    public function getRecoveryId(): int
    {
        return $this->recid;
    }

    /**
     * @return int
     */
    public function getFlags(): int
    {
        return $this->getRecoveryId() + 27 + ($this->isCompressed() ? 4 : 0);
    }

    /**
     * @return bool
     */
    public function isCompressed(): bool
    {
        return $this->compressed;
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer(): BufferInterface
    {
        return (new CompactSignatureSerializer($this->ecAdapter))->serialize($this);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Signature;
6
7		use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Adapter\EcAdapter;
8		use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Serializer\Signature\CompactSignatureSerializer;
9		use BitWasp\Buffertools\Buffer;
10		use BitWasp\Buffertools\BufferInterface;
11
12		class CompactSignature extends Signature implements CompactSignatureInterface
13		{
14		/**
15		* @var resource
16		*/
17		private $resource;
18
19		/**
20		* @var bool
21		*/
22		private $compressed;
23
24		/**
25		* @var int
26		*/
27		private $recid;
28
29		/**
30		* @var EcAdapter
31		*/
32		private $ecAdapter;
		0 ignored issues – show Comprehensibility introduced 2016-06-17 17:50 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
33
34		/**
35		* @param EcAdapter $ecAdapter
36		* @param resource $secp256k1_ecdsa_signature_t
37		* @param int $recid
38		* @param bool $compressed
39		*/
40	7	public function __construct(EcAdapter $ecAdapter, $secp256k1_ecdsa_signature_t, int $recid, bool $compressed)
41		{
42	7	if (!is_resource($secp256k1_ecdsa_signature_t)
43	7	\|\| SECP256K1_TYPE_RECOVERABLE_SIG !== get_resource_type($secp256k1_ecdsa_signature_t)
44		) {
45		throw new \RuntimeException('CompactSignature: must pass recoverable signature resource');
46		}
47
48	7	$ser = '';
49	7	$recidout = 0;
50	7	secp256k1_ecdsa_recoverable_signature_serialize_compact($ecAdapter->getContext(), $ser, $recidout, $secp256k1_ecdsa_signature_t);
51	7	list ($r, $s) = array_map(
52	7	function ($val) {
53	7	return (new Buffer($val))->getGmp();
54	7	},
55	7	str_split($ser, 32)
56		);
57
58	7	$this->resource = $secp256k1_ecdsa_signature_t;
59	7	$this->recid = $recid;
60	7	$this->compressed = $compressed;
61	7	$this->ecAdapter = $ecAdapter;
62	7	parent::__construct($ecAdapter, $r, $s, $secp256k1_ecdsa_signature_t);
63	7	}
64
65		/**
66		* @return Signature
67		*/
68		public function convert(): Signature
69		{
70		$sig_t = '';
71		/** @var resource $sig_t */
72		secp256k1_ecdsa_recoverable_signature_convert($this->ecAdapter->getContext(), $sig_t, $this->resource);
73		return new Signature($this->ecAdapter, $this->getR(), $this->getS(), $sig_t);
		0 ignored issues – show Bug introduced 2018-07-12 16:31 UTC by Report Bug Copy Issue Report It seems like `$sig_t` defined by `''` on line `70` can also be of type `null`; however, `BitWasp\Bitcoin\Crypto\E...ignature::__construct()` does only seem to accept `resource`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
74		}
75
76		/**
77		* @return resource
78		*/
79	6	public function getResource()
80		{
81	6	return $this->resource;
82		}
83
84		/**
85		* @return int
86		*/
87	5	public function getRecoveryId(): int
88		{
89	5	return $this->recid;
90		}
91
92		/**
93		* @return int
94		*/
95	5	public function getFlags(): int
96		{
97	5	return $this->getRecoveryId() + 27 + ($this->isCompressed() ? 4 : 0);
98		}
99
100		/**
101		* @return bool
102		*/
103	6	public function isCompressed(): bool
104		{
105	6	return $this->compressed;
106		}
107
108		/**
109		* @return BufferInterface
110		*/
111	5	public function getBuffer(): BufferInterface
112		{
113	5	return (new CompactSignatureSerializer($this->ecAdapter))->serialize($this);
114		}
115		}
116

Bit-Wasp / bitcoin-php

Pull Request — master (#745)

CompactSignature::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like