Connector::connect() - Code Metrics - Inspection of "Remove PacketHandler - part of cleaning up code" - Bit-Wasp/bitcoin-p2p-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#45)

by thomas

created 2016-03-12 18:03 UTC

Connector::connect() A

↳ Parent: Connector

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	1

<?php

namespace BitWasp\Bitcoin\Networking\Peer;

use BitWasp\Bitcoin\Networking\Messages\Factory as MsgFactory;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddressInterface;
use React\Dns\Resolver\Resolver;
use React\EventLoop\LoopInterface;
use React\Stream\Stream;

class Connector extends \React\SocketClient\Connector
{
    /**
     * @var ConnectionParams
     */
    private $params;

    /**
     * @var MsgFactory
     */
    private $msgs;

    /**
     * @var LoopInterface
     */
    private $loop;


    /**
     * Connector constructor.
     * @param MsgFactory $msgs
     * @param ConnectionParams $params
     * @param LoopInterface $loop
     * @param Resolver $resolver
     */
    public function __construct(MsgFactory $msgs, ConnectionParams $params, LoopInterface $loop, Resolver $resolver)
    {
        $this->params = $params;
        $this->msgs = $msgs;
        $this->loop = $loop;

        parent::__construct($loop, $resolver);
    }

    /**
     * @param NetworkAddressInterface $remotePeer
     * @return \React\Promise\PromiseInterface|static
     */
    public function rawConnect(NetworkAddressInterface $remotePeer)
    {
        return $this
            ->create($remotePeer->getIp(), $remotePeer->getPort())
            ->then(function (Stream $stream) {
                $peer = new Peer($this->msgs, $this->loop);
                $peer->setupStream($stream);
                return $peer;
            });
    }

    /**
     * @param NetworkAddressInterface $remotePeer
     * @return \React\Promise\PromiseInterface|static
     */
    public function connect(NetworkAddressInterface $remotePeer)
    {
        return $this
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->rawConnect($remotePeer)
            ->then(function (Peer $peer) use ($remotePeer) {
                return $peer->outboundHandshake($remotePeer, $this->params);
            });
    }
}


1			<?php
2
3			namespace BitWasp\Bitcoin\Networking\Peer;
4
5			use BitWasp\Bitcoin\Networking\Messages\Factory as MsgFactory;
6			use BitWasp\Bitcoin\Networking\Structure\NetworkAddressInterface;
7			use React\Dns\Resolver\Resolver;
8			use React\EventLoop\LoopInterface;
9			use React\Stream\Stream;
10
11			class Connector extends \React\SocketClient\Connector
12			{
13			/**
14			* @var ConnectionParams
15			*/
16			private $params;
17
18			/**
19			* @var MsgFactory
20			*/
21			private $msgs;
22
23			/**
24			* @var LoopInterface
25			*/
26			private $loop;
			0 ignored issues – show Comprehensibility introduced 2016-03-12 18:40 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
27
28			/**
29			* Connector constructor.
30			* @param MsgFactory $msgs
31			* @param ConnectionParams $params
32			* @param LoopInterface $loop
33			* @param Resolver $resolver
34			*/
35			public function __construct(MsgFactory $msgs, ConnectionParams $params, LoopInterface $loop, Resolver $resolver)
36			{
37			$this->params = $params;
38			$this->msgs = $msgs;
39			$this->loop = $loop;
40
41			parent::__construct($loop, $resolver);
42			}
43
44			/**
45			* @param NetworkAddressInterface $remotePeer
46			* @return \React\Promise\PromiseInterface\|static
47			*/
48			public function rawConnect(NetworkAddressInterface $remotePeer)
49			{
50			return $this
51			->create($remotePeer->getIp(), $remotePeer->getPort())
52			->then(function (Stream $stream) {
53			$peer = new Peer($this->msgs, $this->loop);
54			$peer->setupStream($stream);
55			return $peer;
56			});
57			}
58
59			/**
60			* @param NetworkAddressInterface $remotePeer
61			* @return \React\Promise\PromiseInterface\|static
62			*/
63			public function connect(NetworkAddressInterface $remotePeer)
64			{
65			return $this
			0 ignored issues – show Bug introduced 2016-03-12 18:40 UTC by Report Bug Copy Issue Report The method `then` does only exist in `React\Promise\PromiseInterface`, but not in `BitWasp\Bitcoin\Networking\Peer\Connector`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
66			->rawConnect($remotePeer)
67			->then(function (Peer $peer) use ($remotePeer) {
68			return $peer->outboundHandshake($remotePeer, $this->params);
69			});
70			}
71			}
72

Bit-Wasp / bitcoin-p2p-php

Pull Request — master (#45)

Connector::connect() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like