Version::__construct() - Code Metrics - Inspection of "Merge pull request #61 from afk11/use-IpInterface" - Bit-Wasp/bitcoin-p2p-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c10a8...999ca2 )

by thomas

created 2016-03-30 01:59 UTC

Version::__construct() B

↳ Parent: Version

Complexity

Conditions	4
Paths	8

Size

Total Lines	34
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	4.1106

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	34
ccs	17
cts	21
cp	0.8095
rs	8.5806
cc	4
eloc	27
nc	8
nop	9
crap	4.1106

How to fix Many Parameters

<?php

namespace BitWasp\Bitcoin\Networking\Messages;

use BitWasp\Bitcoin\Networking\Message;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddressInterface;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddressTimestamp;
use BitWasp\Bitcoin\Networking\Serializer\Message\VersionSerializer;
use BitWasp\Bitcoin\Networking\Serializer\Structure\NetworkAddressSerializer;
use BitWasp\Buffertools\Buffer;
use BitWasp\Bitcoin\Crypto\Random\Random;
use BitWasp\Bitcoin\Networking\NetworkSerializable;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddress;
use BitWasp\Buffertools\BufferInterface;

class Version extends NetworkSerializable
{
    /**
     * @var int|string
     */
    private $version;

    /**
     * @var int
     */
    private $services;

    /**
     * @var int|string
     */
    private $timestamp;

    /**
     * @var NetworkAddressInterface
     */
    private $addrRecv;

    /**
     * @var NetworkAddressInterface
     */
    private $addrFrom;

    /**
     * @var BufferInterface
     */
    private $userAgent;

    /**
     * @var int|string
     */
    private $startHeight;

    /**
     * @var bool
     */
    private $relay;

    /**
     * @var integer|string
     */
    private $nonce;

    /**
     * @param int $version
     * @param int $services
     * @param int $timestamp
     * @param NetworkAddressInterface $addrRecv
     * @param NetworkAddressInterface $addrFrom
     * @param int $nonce
     * @param BufferInterface $userAgent
     * @param int $startHeight
     * @param bool $relay
     */
    public function __construct(
        $version,
        $services,
        $timestamp,
        NetworkAddressInterface $addrRecv,
        NetworkAddressInterface $addrFrom,
        $nonce,
        BufferInterface $userAgent,
        $startHeight,
        $relay
    ) {

        if ($addrRecv instanceof NetworkAddressTimestamp) {
            $addrRecv = $addrRecv->withoutTimestamp();
        }
        if ($addrFrom instanceof NetworkAddressTimestamp) {
            $addrFrom = $addrFrom->withoutTimestamp();
        }

        $random = new Random();
        $this->nonce = $random->bytes(8)->getInt();
        $this->version = $version;
        $this->services = $services;
        $this->timestamp = $timestamp;
        $this->addrRecv = $addrRecv;
        $this->nonce = $nonce;
        $this->addrFrom = $addrFrom;
        $this->userAgent = $userAgent;
        $this->startHeight = $startHeight;
        if (! is_bool($relay)) {
            throw new \InvalidArgumentException('Relay must be a boolean');
        }
        $this->relay = $relay;
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Network\NetworkSerializableInterface::getNetworkCommand()
     */
    public function getNetworkCommand()
    {
        return Message::VERSION;
    }

    /**
     * @return Buffer|int|string
     */
    public function getNonce()
    {
        return $this->nonce;
    }

    /**
     * @return int|string
     */
    public function getVersion()
    {
        return $this->version;
    }

    /**
     * @return int
     */
    public function getServices()
    {
        return $this->services;
    }

    /**
     * @return int|string
     */
    public function getTimestamp()
    {
        return $this->timestamp;
    }

    /**
     * @return NetworkAddress
     */
    public function getRecipientAddress()
    {
        return $this->addrRecv;
    }

    /**
     * @return NetworkAddress
     */
    public function getSenderAddress()
    {
        return $this->addrFrom;
    }

    /**
     * @return BufferInterface
     */
    public function getUserAgent()
    {
        return $this->userAgent;
    }

    /**
     * @return int|string
     */
    public function getStartHeight()
    {
        return $this->startHeight;
    }

    /**
     * @return bool
     */
    public function getRelay()
    {
        return $this->relay;
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer()
    {
        return (new VersionSerializer(new NetworkAddressSerializer()))->serialize($this);
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Networking\Messages;
4
5		use BitWasp\Bitcoin\Networking\Message;
6		use BitWasp\Bitcoin\Networking\Structure\NetworkAddressInterface;
7		use BitWasp\Bitcoin\Networking\Structure\NetworkAddressTimestamp;
8		use BitWasp\Bitcoin\Networking\Serializer\Message\VersionSerializer;
9		use BitWasp\Bitcoin\Networking\Serializer\Structure\NetworkAddressSerializer;
10		use BitWasp\Buffertools\Buffer;
11		use BitWasp\Bitcoin\Crypto\Random\Random;
12		use BitWasp\Bitcoin\Networking\NetworkSerializable;
13		use BitWasp\Bitcoin\Networking\Structure\NetworkAddress;
14		use BitWasp\Buffertools\BufferInterface;
15
16		class Version extends NetworkSerializable
17		{
18		/**
19		* @var int\|string
20		*/
21		private $version;
22
23		/**
24		* @var int
25		*/
26		private $services;
27
28		/**
29		* @var int\|string
30		*/
31		private $timestamp;
32
33		/**
34		* @var NetworkAddressInterface
35		*/
36		private $addrRecv;
37
38		/**
39		* @var NetworkAddressInterface
40		*/
41		private $addrFrom;
42
43		/**
44		* @var BufferInterface
45		*/
46		private $userAgent;
47
48		/**
49		* @var int\|string
50		*/
51		private $startHeight;
52
53		/**
54		* @var bool
55		*/
56		private $relay;
57
58		/**
59		* @var integer\|string
60		*/
61		private $nonce;
62
63		/**
64		* @param int $version
65		* @param int $services
66		* @param int $timestamp
67		* @param NetworkAddressInterface $addrRecv
68		* @param NetworkAddressInterface $addrFrom
69		* @param int $nonce
70		* @param BufferInterface $userAgent
71		* @param int $startHeight
72		* @param bool $relay
73		*/
74	63	public function __construct(
75		$version,
76		$services,
77		$timestamp,
78		NetworkAddressInterface $addrRecv,
79		NetworkAddressInterface $addrFrom,
80		$nonce,
81		BufferInterface $userAgent,
82		$startHeight,
83		$relay
84		) {
85
86	63	if ($addrRecv instanceof NetworkAddressTimestamp) {
87		$addrRecv = $addrRecv->withoutTimestamp();
88		}
89	63	if ($addrFrom instanceof NetworkAddressTimestamp) {
90		$addrFrom = $addrFrom->withoutTimestamp();
91		}
92
93	63	$random = new Random();
94	63	$this->nonce = $random->bytes(8)->getInt();
95	63	$this->version = $version;
96	63	$this->services = $services;
97	63	$this->timestamp = $timestamp;
98	63	$this->addrRecv = $addrRecv;
99	63	$this->nonce = $nonce;
100	63	$this->addrFrom = $addrFrom;
101	63	$this->userAgent = $userAgent;
102	63	$this->startHeight = $startHeight;
103	63	if (! is_bool($relay)) {
104	3	throw new \InvalidArgumentException('Relay must be a boolean');
105		}
106	60	$this->relay = $relay;
107	60	}
108
109		/**
110		* {@inheritdoc}
111		* @see \BitWasp\Bitcoin\Network\NetworkSerializableInterface::getNetworkCommand()
112		*/
113	24	public function getNetworkCommand()
114		{
115	24	return Message::VERSION;
116		}
117
118		/**
119		* @return Buffer\|int\|string
120		*/
121	24	public function getNonce()
122		{
123	24	return $this->nonce;
124		}
125
126		/**
127		* @return int\|string
128		*/
129	27	public function getVersion()
130		{
131	27	return $this->version;
132		}
133
134		/**
135		* @return int
136		*/
137	24	public function getServices()
138		{
139	24	return $this->services;
140		}
141
142		/**
143		* @return int\|string
144		*/
145	27	public function getTimestamp()
146		{
147	27	return $this->timestamp;
148		}
149
150		/**
151		* @return NetworkAddress
152		*/
153	30	public function getRecipientAddress()
154		{
155	30	return $this->addrRecv;
156		}
157
158		/**
159		* @return NetworkAddress
160		*/
161	39	public function getSenderAddress()
162		{
163	39	return $this->addrFrom;
164		}
165
166		/**
167		* @return BufferInterface
168		*/
169	27	public function getUserAgent()
170		{
171	27	return $this->userAgent;
172		}
173
174		/**
175		* @return int\|string
176		*/
177	30	public function getStartHeight()
178		{
179	30	return $this->startHeight;
180		}
181
182		/**
183		* @return bool
184		*/
185	27	public function getRelay()
186		{
187	27	return $this->relay;
188		}
189
190		/**
191		* @return BufferInterface
192		*/
193	21	public function getBuffer()
194		{
195	21	return (new VersionSerializer(new NetworkAddressSerializer()))->serialize($this);
196		}
197		}
198

Bit-Wasp / bitcoin-p2p-php

Push — master ( 4c10a8...999ca2 )

Version::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like