Ping::getBuffer() - Code Metrics - Inspection of "some more php7 type hints and tweaks, extract immu..." - Bit-Wasp/bitcoin-p2p-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3dc4f8...535c32 )

by thomas

created 2018-03-29 20:28 UTC

Ping::getBuffer() A

↳ Parent: Ping

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Networking\Messages;

use BitWasp\Bitcoin\Crypto\Random\Random;
use BitWasp\Bitcoin\Networking\Message;
use BitWasp\Bitcoin\Networking\NetworkSerializable;
use BitWasp\Bitcoin\Networking\Serializer\Message\PingSerializer;
use BitWasp\Buffertools\BufferInterface;

class Ping extends NetworkSerializable
{
    /**
     * @var int
     */
    private $nonce;

    /**
     * Ping constructor.
     * @param int $nonce
     */
    public function __construct(int $nonce)
    {
        $this->nonce = $nonce;
    }

    /**
     * @param Random $random
     * @return Ping
     * @throws \BitWasp\Bitcoin\Exceptions\RandomBytesFailure
     */
    public static function generate(Random $random): Ping
    {
        $nonce = (int) $random->bytes(8)->getInt();
        return new Ping($nonce);
    }

    /**
     * @return string
     */
    public function getNetworkCommand(): string
    {
        return Message::PING;
    }

    /**
     * @return int
     */
    public function getNonce()
    {
        return $this->nonce;
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer(): BufferInterface
    {
        return (new PingSerializer())->serialize($this);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Networking\Messages;
6
7		use BitWasp\Bitcoin\Crypto\Random\Random;
8		use BitWasp\Bitcoin\Networking\Message;
9		use BitWasp\Bitcoin\Networking\NetworkSerializable;
10		use BitWasp\Bitcoin\Networking\Serializer\Message\PingSerializer;
11		use BitWasp\Buffertools\BufferInterface;
12
13		class Ping extends NetworkSerializable
14		{
15		/**
16		* @var int
17		*/
18		private $nonce;
19
20		/**
21	9	* Ping constructor.
22		* @param int $nonce
23	9	*/
24	9	public function __construct(int $nonce)
25		{
26		$this->nonce = $nonce;
27		}
28
29	9	/**
30		* @param Random $random
31	9	* @return Ping
32		* @throws \BitWasp\Bitcoin\Exceptions\RandomBytesFailure
33		*/
34		public static function generate(Random $random): Ping
35		{
36		$nonce = (int) $random->bytes(8)->getInt();
37	18	return new Ping($nonce);
38		}
39	18
40		/**
41		* @return string
42		*/
43		public function getNetworkCommand(): string
44		{
45	9	return Message::PING;
46		}
47	9
48		/**
49		* @return int
50		*/
51		public function getNonce()
52		{
53		return $this->nonce;
54		}
55
56		/**
57		* @return BufferInterface
58		*/
59		public function getBuffer(): BufferInterface
60		{
61		return (new PingSerializer())->serialize($this);
62		}
63		}
64

Bit-Wasp / bitcoin-p2p-php

Push — master ( 3dc4f8...535c32 )

Ping::getBuffer() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like