Version::__construct() - Code Metrics - Bit-Wasp/bitcoin-p2p-php - Measure and Improve Code Quality continuously with Scrutinizer

Version::__construct() A
last analyzed 2019-01-16 18:45 UTC

↳ Parent: Version

Complexity

Conditions	3
Paths	4

Size

Total Lines	30
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	3.0017

Importance

Changes

Metric	Value
cc	3
eloc	15
nc	4
nop	9
dl	0
loc	30
ccs	16
cts	17
cp	0.9412
crap	3.0017
rs	9.7666
c	0
b	0
f	0

How to fix Many Parameters

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Networking\Messages;

use BitWasp\Bitcoin\Crypto\Random\Random;
use BitWasp\Bitcoin\Networking\Message;
use BitWasp\Bitcoin\Networking\NetworkSerializable;
use BitWasp\Bitcoin\Networking\Serializer\Message\VersionSerializer;
use BitWasp\Bitcoin\Networking\Serializer\Structure\NetworkAddressSerializer;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddress;
use BitWasp\Bitcoin\Networking\Structure\NetworkAddressTimestamp;
use BitWasp\Buffertools\BufferInterface;

class Version extends NetworkSerializable
{
    /**
     * Identifies protocol version being used by the node
     * @var int
     */
    private $version;

    /**
     * bitfield of features to be enabled for this connection
     * @var int
     */
    private $services;

    /**
     * standard UNIX timestamp in seconds
     * @var int
     */
    private $timestamp;

    /**
     * The network address of the node receiving this message
     * @var NetworkAddress
     */
    private $addrRecv;

    // The fields after this require version >= 106

    /**
     *  The network address of the node emitting this message
     * @var NetworkAddress
     */
    private $addrFrom;

    /**
     * Node random nonce, randomly generated every time a
     * version packet is sent. This nonce is used to detect
     * connections to self.
     * @var int
     */
    private $nonce;

    /**
     * User agent
     * @var BufferInterface
     */
    private $userAgent;

    /**
     * The last block received by the emitting node
     * @var int
     */
    private $startHeight;

    // Fields below require version >= 70001

    /**
     * Whether the remote peer should announce relayed transactions or not.
     * @var bool
     */
    private $relay;

    /**
     * Version constructor.
     * @param int $version
     * @param int $services
     * @param int $timestamp
     * @param NetworkAddress $addrRecv
     * @param NetworkAddress $addrFrom
     * @param int $nonce
     * @param BufferInterface $userAgent
     * @param int $startHeight
     * @param bool $relay
     * @throws \BitWasp\Bitcoin\Exceptions\RandomBytesFailure
     */
    public function __construct(
        int $version,
        int $services,
        int $timestamp,
        NetworkAddress $addrRecv,
        NetworkAddress $addrFrom,
        int $nonce,
        BufferInterface $userAgent,
        int $startHeight,
        bool $relay
    ) {

        if ($addrRecv instanceof NetworkAddressTimestamp) {
            $addrRecv = $addrRecv->withoutTimestamp();
        }
        if ($addrFrom instanceof NetworkAddressTimestamp) {
            $addrFrom = $addrFrom->withoutTimestamp();
        }

        $random = new Random();
        $this->nonce = (int) $random->bytes(8)->getInt();
        $this->version = $version;
        $this->services = $services;
        $this->timestamp = $timestamp;
        $this->addrRecv = $addrRecv;
        $this->nonce = $nonce;
        $this->addrFrom = $addrFrom;
        $this->userAgent = $userAgent;
        $this->startHeight = $startHeight;
        $this->relay = $relay;
    }

    /**
     * {@inheritdoc}
     * @see https://en.bitcoin.it/wiki/Protocol_documentation#version
     * @see \BitWasp\Bitcoin\Network\NetworkSerializableInterface::getNetworkCommand()
     */
    public function getNetworkCommand(): string
    {
        return Message::VERSION;
    }

    /**
     * @return int
     */
    public function getNonce(): int
    {
        return $this->nonce;
    }

    /**
     * @return int
     */
    public function getVersion(): int
    {
        return $this->version;
    }

    /**
     * @return int
     */
    public function getServices(): int
    {
        return $this->services;
    }

    /**
     * @return int
     */
    public function getTimestamp(): int
    {
        return $this->timestamp;
    }

    /**
     * @return NetworkAddress
     */
    public function getRecipientAddress(): NetworkAddress
    {
        return $this->addrRecv;
    }

    /**
     * @return NetworkAddress
     */
    public function getSenderAddress(): NetworkAddress
    {
        return $this->addrFrom;
    }

    /**
     * @return BufferInterface
     */
    public function getUserAgent(): BufferInterface
    {
        return $this->userAgent;
    }

    /**
     * @return int
     */
    public function getStartHeight(): int
    {
        return $this->startHeight;
    }

    /**
     * @return bool
     */
    public function getRelay(): bool
    {
        return $this->relay;
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer(): BufferInterface
    {
        return (new VersionSerializer(new NetworkAddressSerializer()))->serialize($this);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Networking\Messages;
6
7		use BitWasp\Bitcoin\Crypto\Random\Random;
8		use BitWasp\Bitcoin\Networking\Message;
9		use BitWasp\Bitcoin\Networking\NetworkSerializable;
10		use BitWasp\Bitcoin\Networking\Serializer\Message\VersionSerializer;
11		use BitWasp\Bitcoin\Networking\Serializer\Structure\NetworkAddressSerializer;
12		use BitWasp\Bitcoin\Networking\Structure\NetworkAddress;
13		use BitWasp\Bitcoin\Networking\Structure\NetworkAddressTimestamp;
14		use BitWasp\Buffertools\BufferInterface;
15
16		class Version extends NetworkSerializable
17		{
18		/**
19		* Identifies protocol version being used by the node
20		* @var int
21		*/
22		private $version;
23
24		/**
25		* bitfield of features to be enabled for this connection
26		* @var int
27		*/
28		private $services;
29
30		/**
31		* standard UNIX timestamp in seconds
32		* @var int
33		*/
34		private $timestamp;
35
36		/**
37		* The network address of the node receiving this message
38		* @var NetworkAddress
39		*/
40		private $addrRecv;
41
42		// The fields after this require version >= 106
43
44		/**
45		* The network address of the node emitting this message
46		* @var NetworkAddress
47		*/
48		private $addrFrom;
49
50		/**
51		* Node random nonce, randomly generated every time a
52		* version packet is sent. This nonce is used to detect
53		* connections to self.
54		* @var int
55		*/
56		private $nonce;
57
58		/**
59		* User agent
60		* @var BufferInterface
61		*/
62		private $userAgent;
63
64		/**
65		* The last block received by the emitting node
66		* @var int
67		*/
68		private $startHeight;
69
70		// Fields below require version >= 70001
71
72		/**
73		* Whether the remote peer should announce relayed transactions or not.
74	63	* @var bool
75		*/
76		private $relay;
77
78		/**
79		* Version constructor.
80		* @param int $version
81		* @param int $services
82		* @param int $timestamp
83		* @param NetworkAddress $addrRecv
84		* @param NetworkAddress $addrFrom
85		* @param int $nonce
86	63	* @param BufferInterface $userAgent
87		* @param int $startHeight
88		* @param bool $relay
89	63	* @throws \BitWasp\Bitcoin\Exceptions\RandomBytesFailure
90		*/
91		public function __construct(
92		int $version,
93	63	int $services,
94	63	int $timestamp,
95	63	NetworkAddress $addrRecv,
96	63	NetworkAddress $addrFrom,
97	63	int $nonce,
98	63	BufferInterface $userAgent,
99	63	int $startHeight,
100	63	bool $relay
101	63	) {
102	63
103	63	if ($addrRecv instanceof NetworkAddressTimestamp) {
104	3	$addrRecv = $addrRecv->withoutTimestamp();
105		}
106	60	if ($addrFrom instanceof NetworkAddressTimestamp) {
107	60	$addrFrom = $addrFrom->withoutTimestamp();
108		}
109
110		$random = new Random();
111		$this->nonce = (int) $random->bytes(8)->getInt();
112		$this->version = $version;
113	24	$this->services = $services;
114		$this->timestamp = $timestamp;
115	24	$this->addrRecv = $addrRecv;
116		$this->nonce = $nonce;
117		$this->addrFrom = $addrFrom;
118		$this->userAgent = $userAgent;
119		$this->startHeight = $startHeight;
120		$this->relay = $relay;
121	24	}
122
123	24	/**
124		* {@inheritdoc}
125		* @see https://en.bitcoin.it/wiki/Protocol_documentation#version
126		* @see \BitWasp\Bitcoin\Network\NetworkSerializableInterface::getNetworkCommand()
127		*/
128		public function getNetworkCommand(): string
129	27	{
130		return Message::VERSION;
131	27	}
132
133		/**
134		* @return int
135		*/
136		public function getNonce(): int
137	24	{
138		return $this->nonce;
139	24	}
140
141		/**
142		* @return int
143		*/
144		public function getVersion(): int
145	27	{
146		return $this->version;
147	27	}
148
149		/**
150		* @return int
151		*/
152		public function getServices(): int
153	30	{
154		return $this->services;
155	30	}
156
157		/**
158		* @return int
159		*/
160		public function getTimestamp(): int
161	39	{
162		return $this->timestamp;
163	39	}
164
165		/**
166		* @return NetworkAddress
167		*/
168		public function getRecipientAddress(): NetworkAddress
169	27	{
170		return $this->addrRecv;
171	27	}
172
173		/**
174		* @return NetworkAddress
175		*/
176		public function getSenderAddress(): NetworkAddress
177	30	{
178		return $this->addrFrom;
179	30	}
180
181		/**
182		* @return BufferInterface
183		*/
184		public function getUserAgent(): BufferInterface
185	27	{
186		return $this->userAgent;
187	27	}
188
189		/**
190		* @return int
191		*/
192		public function getStartHeight(): int
193	21	{
194		return $this->startHeight;
195	21	}
196
197		/**
198		* @return bool
199		*/
200		public function getRelay(): bool
201		{
202		return $this->relay;
203		}
204
205		/**
206		* @return BufferInterface
207		*/
208		public function getBuffer(): BufferInterface
209		{
210		return (new VersionSerializer(new NetworkAddressSerializer()))->serialize($this);
211		}
212		}
213

Bit-Wasp / bitcoin-p2p-php

Version::__construct() A last analyzed 2019-01-16 18:45 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

Version::__construct() A
last analyzed 2019-01-16 18:45 UTC