Issues in MatchHandler.php (master) - Issues in master - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

Issues (272)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/library/Handlers/MatchHandler.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GolfLeague\Handlers;

use GolfLeague\Storage\Round\RoundRepository;


/**
 * MatchHandler Connection Class
 *
 * This class subscribes to events in related to match creation
 *
 * @author          Michael Schmidt
 */
class MatchHandler
{
    /**
     * Create a new instance of the MatchHandler
     *
     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
     * @return void

     */
    public function __construct(RoundRepository $roundRepo)
    {
        $this->roundRepo= $roundRepo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    } // End of __construct

    /**
     * Create an initial round for each player after a new match is created
     *
     * @param  Match $match
     * @return void
     */
    public function handle($match)
    {
        //for each player create an initial round
        $input = array(
        'date' => $match['date'],
         'course_id' => $match['course'],

         'match_id' => $match['match_id'],
         'score' => 0,
         'esc' => 0
         );
         foreach($match['player'] as $player){
             $input['player_id'] = $player['player_id'];
             //If team match then add team id to $input array
             if(isset($player['team'])){
                 $input['team_id'] = $player['team'];
             }
             $this->roundRepo->create($input);
         }

    }

    /**
     * Register the listeners for the subscriber.
     *
     * @param  Illuminate\Events\Dispatcher $events
     * @return array
     */
    public function subscribe($events)
    {
        $events->listen('match.create', 'GolfLeague\Handlers\MatchHandler');
    }
}


1			<?php
2
3			namespace GolfLeague\Handlers;
4
5			use GolfLeague\Storage\Round\RoundRepository;
6
7
8			/**
9			* MatchHandler Connection Class
10			*
11			* This class subscribes to events in related to match creation
12			*
13			* @author Michael Schmidt
14			*/
15			class MatchHandler
16			{
17			/**
18			* Create a new instance of the MatchHandler
19			*
20			* @param GolfLeague\Storage\Round\RoundRepository $roundRepo
21			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-01-06 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
22			*/
23			public function __construct(RoundRepository $roundRepo)
24			{
25			$this->roundRepo= $roundRepo;
			0 ignored issues – show Bug introduced 2016-01-06 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `roundRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			} // End of __construct
27
28			/**
29			* Create an initial round for each player after a new match is created
30			*
31			* @param Match $match
32			* @return void
33			*/
34			public function handle($match)
35			{
36			//for each player create an initial round
37			$input = array(
38			'date' => $match['date'],
39			'course_id' => $match['course'],
40
41			'match_id' => $match['match_id'],
42			'score' => 0,
43			'esc' => 0
44			);
45			foreach($match['player'] as $player){
46			$input['player_id'] = $player['player_id'];
47			//If team match then add team id to $input array
48			if(isset($player['team'])){
49			$input['team_id'] = $player['team'];
50			}
51			$this->roundRepo->create($input);
52			}
53
54			}
55
56			/**
57			* Register the listeners for the subscriber.
58			*
59			* @param Illuminate\Events\Dispatcher $events
60			* @return array
61			*/
62			public function subscribe($events)
63			{
64			$events->listen('match.create', 'GolfLeague\Handlers\MatchHandler');
65			}
66			}
67

BigBad / golfleague

Issues (272)

Security Analysis not enabled

app/library/Handlers/MatchHandler.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like