Issues in MatchesController.php (master) - Issues in master - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

Issues (272)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/controllers/MatchesController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use GolfLeague\Services\MatchService as MatchService;
use GolfLeague\Storage\Match\MatchRepository as MatchRepository;
use Carbon\Carbon;

class MatchesController extends \BaseController {
namespace YourVendor;

class YourClass { }


    public function __construct(MatchService $match, MatchRepository $matchRepo)
    {
        $this->match = $match;
		$this->matchRepo = $matchRepo;
    }

	/**
	 * Display a listing of the resource.
	 *
	 * @return Response
	 */
	public function index()
	{
		return $this->matchRepo->all();
	}


	/**
	 * Show the form for creating a new resource.
	 *
	 * @return Response
	 */
	public function create()
	{
		$view = View::make('creatematch');
        return $view;
	}

	/**
	 * Store a newly created resource in storage.
	 *
	 * @return Response
	 */
	public function store()
	{
	    $input = Input::all();
		return $this->match->create($input);
	}


	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function show($id)
	{
		return $this->matchRepo->get($id);
	}


	/**
	 * Show the form for editing the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function edit($id)
	{

        $enterView = 'EnterTeamMatch';
	    $data = $this->match->get($id);
        $view = View::make($enterView, $data);
        return $view;

	    // Logic to allow editable for day of match only
		$today = Carbon::today();
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        $teamMatchDate = new Carbon('first day of January 2017');
		$matchDate = new Carbon($data['date']);

		if($matchDate >= $teamMatchDate){
		    $enterView = 'EnterTeamMatch';
        }

		if($today <= $matchDate){
			//Show Editable View
			$view = View::make($enterView, $data);
			return $view;
		}
		else {
			//Show Readonly View
			$view = View::make('ViewMatch', $data);
			return $view;
		}
	}


	/**
	 * Update the specified resource in storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function update($id)
	{
		//
	}


	/**
	 * Remove the specified resource from storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function destroy($id)
	{
		return $this->matchRepo->delete($id);
	}

}


1			<?php
2
3			use GolfLeague\Services\MatchService as MatchService;
4			use GolfLeague\Storage\Match\MatchRepository as MatchRepository;
5			use Carbon\Carbon;
6
7			class MatchesController extends \BaseController {
			0 ignored issues – show Coding Style Compatibility introduced 2017-04-24 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8
9
10			public function __construct(MatchService $match, MatchRepository $matchRepo)
11			{
12			$this->match = $match;
13			$this->matchRepo = $matchRepo;
14			}
15
16			/**
17			* Display a listing of the resource.
18			*
19			* @return Response
20			*/
21			public function index()
22			{
23			return $this->matchRepo->all();
24			}
25
26
27			/**
28			* Show the form for creating a new resource.
29			*
30			* @return Response
31			*/
32			public function create()
33			{
34			$view = View::make('creatematch');
35			return $view;
36			}
37
38			/**
39			* Store a newly created resource in storage.
40			*
41			* @return Response
42			*/
43			public function store()
44			{
45			$input = Input::all();
46			return $this->match->create($input);
47			}
48
49
50			/**
51			* Display the specified resource.
52			*
53			* @param int $id
54			* @return Response
55			*/
56			public function show($id)
57			{
58			return $this->matchRepo->get($id);
59			}
60
61
62			/**
63			* Show the form for editing the specified resource.
64			*
65			* @param int $id
66			* @return Response
67			*/
68			public function edit($id)
69			{
70
71			$enterView = 'EnterTeamMatch';
72			$data = $this->match->get($id);
73			$view = View::make($enterView, $data);
74			return $view;
75
76			// Logic to allow editable for day of match only
77			$today = Carbon::today();
			0 ignored issues – show Unused Code introduced 2017-04-24 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `// Logic to allow editab...Carbon\Carbon::today();` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
78
79			$teamMatchDate = new Carbon('first day of January 2017');
80			$matchDate = new Carbon($data['date']);
81
82			if($matchDate >= $teamMatchDate){
83			$enterView = 'EnterTeamMatch';
84			}
85
86			if($today <= $matchDate){
87			//Show Editable View
88			$view = View::make($enterView, $data);
89			return $view;
90			}
91			else {
92			//Show Readonly View
93			$view = View::make('ViewMatch', $data);
94			return $view;
95			}
96			}
97
98
99			/**
100			* Update the specified resource in storage.
101			*
102			* @param int $id
103			* @return Response
104			*/
105			public function update($id)
106			{
107			//
108			}
109
110
111			/**
112			* Remove the specified resource from storage.
113			*
114			* @param int $id
115			* @return Response
116			*/
117			public function destroy($id)
118			{
119			return $this->matchRepo->delete($id);
120			}
121
122			}
123

BigBad / golfleague

Issues (272)

Security Analysis not enabled

app/controllers/MatchesController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like