for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php namespace GolfLeague\Storage\Ctp;
use \Ctp as Ctp;
class EloquentCtpRepository implements CtpRepository
{
/*Return Score collections that include:
* Player Name
* Date
* Total
* Course
* Multideminsional Array of Hole Numbers and scores *
**/
public function all()
return Ctp::all();
}
public function find($id)
return Ctp::find($id);
//Find Ctps by Player Id
public function findByPlayer($playerId)
return Ctp::with('player', 'hole', 'match')->where('player_id', '=', $playerId)->get();
public function findByHole($holeId)
return Ctp::with('player', 'hole')->where('hole_id', '=', $holeId)->get();
public function findByMatch($matchId)
return Ctp::with('player', 'hole')->where('match_id', '=', $matchId)->get();
public function create($input)
return Ctp::create($input);
//pass this a Ctp Eloquent object and replace it in database
public function update($ctp)
$updateCtp = Ctp::find($ctp->id);
$updateCtp
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$updateCtp = $ctp;
$updateCtp->save();
BigBad /
golfleague
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.