FinalizeHandler::handle() - Code Metrics - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

FinalizeHandler::handle() F
last analyzed 2017-05-30 15:22 UTC

↳ Parent: FinalizeHandler

Complexity

Conditions	11
Paths	324

Size

Total Lines	88
Code Lines	54

Duplication

Lines	56
Ratio	63.64 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	56
loc	88
rs	3.8181
cc	11
eloc	54
nc	324
nop	1

How to fix Long Method Complexity

<?php

namespace GolfLeague\Handlers;

use GolfLeague\Storage\Round\RoundRepository;
use \Ctp;
use \Netwinner;
use \Grosswinner;
use \Skin;
use \Player;

/**
 * MatchHandler Connection Class
 *
 * This class subscribes to events in related to match creation
 *
 * @author          Michael Schmidt
 */
class FinalizeHandler
{
    /**
     * Create a new instance of the MatchHandler
     *
     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
     * @return void

     */
    public function __construct(RoundRepository $roundRepo)
    {
        $this->roundRepo= $roundRepo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    } // End of __construct

    /**
     * Create an initial round for each player after a new match is created
     *
     * @param  Match $match
     * @return void
     */
    public function handle($match)
    {
        //for the match get ctps, netwinner, grosswinner, and skins
        //calculate winnings
        //store in the pivot table match_player for the given player

        $winningPlayers = array();
        $i = 1;

        $ctpWinners = Ctp::where('match_id', '=', $match->id)->get();
        foreach($ctpWinners as $key => $ctpWinner){

            $playerExists = $this->recursive_array_search($ctpWinner->player_id, $winningPlayers);
            //if player is already there add money here to other money
            if($playerExists){
                $winningPlayers[$i]['player_id'] = $ctpWinner->player_id;
                $winningPlayers[$i]['money'] = ($ctpWinner->money + $winningPlayers[$playerExists]['money']);
                unset($winningPlayers[$playerExists]);
            }
            else {
                $winningPlayers[$i]['player_id'] = $ctpWinner->player_id;
                $winningPlayers[$i]['money'] = $ctpWinner->money;
            }
            $i++;
        }

        $netWinners = Netwinner::where('match_id', '=', $match->id)->get();
        foreach($netWinners as $key => $netWinner){

            $playerExists = $this->recursive_array_search($netWinner->player_id, $winningPlayers);
            //if player is already there add money here to other money
            if($playerExists){
                $winningPlayers[$i]['player_id'] = $netWinner->player_id;
                $winningPlayers[$i]['money'] = ($netWinner->money + $winningPlayers[$playerExists]['money']);
                unset($winningPlayers[$playerExists]);
            }
            else{
                $winningPlayers[$i]['player_id'] = $netWinner->player_id;
                $winningPlayers[$i]['money'] = $netWinner->money;
            }
            $i++;
        }

        $grossWinners = Grosswinner::where('match_id', '=', $match->id)->get();
        foreach($grossWinners as $key => $grossWinner){

            $playerExists = $this->recursive_array_search($grossWinner->player_id, $winningPlayers);
            //if player is already there add money here to other money
            if($playerExists){
                $winningPlayers[$i]['player_id'] = $grossWinner->player_id;
                $winningPlayers[$i]['money'] = ($grossWinner->money + $winningPlayers[$playerExists]['money']);
                unset($winningPlayers[$playerExists]);
            }
            else{
                $winningPlayers[$i]['player_id'] = $grossWinner->player_id;
                $winningPlayers[$i]['money'] = $grossWinner->money;
            }
            $i++;
        }

        $skinWinners = Skin::where('match_id', '=', $match->id)->get();
        foreach($skinWinners as $key => $skinWinner){

            $playerExists = $this->recursive_array_search($skinWinner->player_id, $winningPlayers);
            //if player is already there add money here to other money
            if($playerExists){
                $winningPlayers[$i]['player_id'] = $skinWinner->player_id;
                $winningPlayers[$i]['money'] = ($skinWinner->money + $winningPlayers[$playerExists]['money']);
                unset($winningPlayers[$playerExists]);
            }
            else{
                $winningPlayers[$i]['player_id'] = $skinWinner->player_id;
                $winningPlayers[$i]['money'] = $skinWinner->money;
            }
            $i++;
        }

        //Consolidate any multiple instances of a player
        foreach ($winningPlayers as $key => $winningPlayer){
            array_search($winningPlayer['player_id'], $winningPlayers);
        }

        foreach ($winningPlayers as $key => $player){
            $currentPlayer = Player::find($player['player_id']);
            $attributes = array(
                "winnings" => $player['money']
            );
            $currentPlayer->matches()->updateExistingPivot($match->id, $attributes); //save match_player pivot data
        }// End foreach


    }

    /**
     * Register the listeners for the subscriber.
     *
     * @param  Illuminate\Events\Dispatcher $events
     * @return array
     */
    public function subscribe($events)
    {
        $events->listen('match.finalize', 'GolfLeague\Handlers\FinalizeHandler');
    }

    public function recursive_array_search($needle,$haystack) {
        foreach($haystack as $key=>$value) {
            $current_key=$key;
            if($needle===$value || (is_array($value) && $this->recursive_array_search($needle,$value) !== false)) {
                return $current_key;
            }
        }
        return false;
    }
}


1		<?php
2
3		namespace GolfLeague\Handlers;
4
5		use GolfLeague\Storage\Round\RoundRepository;
6		use \Ctp;
7		use \Netwinner;
8		use \Grosswinner;
9		use \Skin;
10		use \Player;
11
12		/**
13		* MatchHandler Connection Class
14		*
15		* This class subscribes to events in related to match creation
16		*
17		* @author Michael Schmidt
18		*/
19		class FinalizeHandler
20		{
21		/**
22		* Create a new instance of the MatchHandler
23		*
24		* @param GolfLeague\Storage\Round\RoundRepository $roundRepo
25		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-01-06 18:34 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
26		*/
27		public function __construct(RoundRepository $roundRepo)
28		{
29		$this->roundRepo= $roundRepo;
		0 ignored issues – show Bug introduced 2016-01-06 18:34 UTC by Report Bug Copy Issue Report The property `roundRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30		} // End of __construct
31
32		/**
33		* Create an initial round for each player after a new match is created
34		*
35		* @param Match $match
36		* @return void
37		*/
38		public function handle($match)
39		{
40		//for the match get ctps, netwinner, grosswinner, and skins
41		//calculate winnings
42		//store in the pivot table match_player for the given player
43
44		$winningPlayers = array();
45		$i = 1;
46
47		$ctpWinners = Ctp::where('match_id', '=', $match->id)->get();
48	View Code Duplication	foreach($ctpWinners as $key => $ctpWinner){
		0 ignored issues – show Duplication introduced 2016-04-26 13:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		$playerExists = $this->recursive_array_search($ctpWinner->player_id, $winningPlayers);
50		//if player is already there add money here to other money
51		if($playerExists){
52		$winningPlayers[$i]['player_id'] = $ctpWinner->player_id;
53		$winningPlayers[$i]['money'] = ($ctpWinner->money + $winningPlayers[$playerExists]['money']);
54		unset($winningPlayers[$playerExists]);
55		}
56		else {
57		$winningPlayers[$i]['player_id'] = $ctpWinner->player_id;
58		$winningPlayers[$i]['money'] = $ctpWinner->money;
59		}
60		$i++;
61		}
62
63		$netWinners = Netwinner::where('match_id', '=', $match->id)->get();
64	View Code Duplication	foreach($netWinners as $key => $netWinner){
		0 ignored issues – show Duplication introduced 2016-04-26 13:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		$playerExists = $this->recursive_array_search($netWinner->player_id, $winningPlayers);
66		//if player is already there add money here to other money
67		if($playerExists){
68		$winningPlayers[$i]['player_id'] = $netWinner->player_id;
69		$winningPlayers[$i]['money'] = ($netWinner->money + $winningPlayers[$playerExists]['money']);
70		unset($winningPlayers[$playerExists]);
71		}
72		else{
73		$winningPlayers[$i]['player_id'] = $netWinner->player_id;
74		$winningPlayers[$i]['money'] = $netWinner->money;
75		}
76		$i++;
77		}
78
79		$grossWinners = Grosswinner::where('match_id', '=', $match->id)->get();
80	View Code Duplication	foreach($grossWinners as $key => $grossWinner){
		0 ignored issues – show Duplication introduced 2016-04-26 13:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		$playerExists = $this->recursive_array_search($grossWinner->player_id, $winningPlayers);
82		//if player is already there add money here to other money
83		if($playerExists){
84		$winningPlayers[$i]['player_id'] = $grossWinner->player_id;
85		$winningPlayers[$i]['money'] = ($grossWinner->money + $winningPlayers[$playerExists]['money']);
86		unset($winningPlayers[$playerExists]);
87		}
88		else{
89		$winningPlayers[$i]['player_id'] = $grossWinner->player_id;
90		$winningPlayers[$i]['money'] = $grossWinner->money;
91		}
92		$i++;
93		}
94
95		$skinWinners = Skin::where('match_id', '=', $match->id)->get();
96	View Code Duplication	foreach($skinWinners as $key => $skinWinner){
		0 ignored issues – show Duplication introduced 2016-04-26 13:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		$playerExists = $this->recursive_array_search($skinWinner->player_id, $winningPlayers);
98		//if player is already there add money here to other money
99		if($playerExists){
100		$winningPlayers[$i]['player_id'] = $skinWinner->player_id;
101		$winningPlayers[$i]['money'] = ($skinWinner->money + $winningPlayers[$playerExists]['money']);
102		unset($winningPlayers[$playerExists]);
103		}
104		else{
105		$winningPlayers[$i]['player_id'] = $skinWinner->player_id;
106		$winningPlayers[$i]['money'] = $skinWinner->money;
107		}
108		$i++;
109		}
110
111		//Consolidate any multiple instances of a player
112		foreach ($winningPlayers as $key => $winningPlayer){
113		array_search($winningPlayer['player_id'], $winningPlayers);
114		}
115
116		foreach ($winningPlayers as $key => $player){
117		$currentPlayer = Player::find($player['player_id']);
118		$attributes = array(
119		"winnings" => $player['money']
120		);
121		$currentPlayer->matches()->updateExistingPivot($match->id, $attributes); //save match_player pivot data
122		}// End foreach
123
124
125		}
126
127		/**
128		* Register the listeners for the subscriber.
129		*
130		* @param Illuminate\Events\Dispatcher $events
131		* @return array
132		*/
133		public function subscribe($events)
134		{
135		$events->listen('match.finalize', 'GolfLeague\Handlers\FinalizeHandler');
136		}
137
138		public function recursive_array_search($needle,$haystack) {
139		foreach($haystack as $key=>$value) {
140		$current_key=$key;
141		if($needle===$value \|\| (is_array($value) && $this->recursive_array_search($needle,$value) !== false)) {
142		return $current_key;
143		}
144		}
145		return false;
146		}
147		}
148

BigBad / golfleague

FinalizeHandler::handle() F last analyzed 2017-05-30 15:22 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

FinalizeHandler::handle() F
last analyzed 2017-05-30 15:22 UTC