TournamentLeaderboardController::edit()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 1
nc 1
nop 1
1
<?php
2
3
use GolfLeague\Tournament\TournamentLeaderboardService as TournamentLeaderboardService;
4
5
class TournamentLeaderboardController extends \BaseController {
0 ignored issues
show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
6
7
	public function __construct(TournamentLeaderboardService $tournamentLeaderboard)
8
	{
9
		$this->tournamentLeaderboard = $tournamentLeaderboard;
10
	}
11
12
	/**
13
	 * Display a listing of the resource.
14
	 *
15
	 * @return Response
16
	 */
17
	public function index()
18
	{
19
		//
20
	}
21
22
23
	/**
24
	 * Show the form for creating a new resource.
25
	 *
26
	 * @return Response
27
	 */
28
	public function create()
29
	{
30
		//
31
	}
32
33
34
	/**
35
	 * Store a newly created resource in storage.
36
	 *
37
	 * @return Response
38
	 */
39
	public function store()
40
	{
41
		//
42
	}
43
44
45
	/**
46
	 * Display the specified resource.
47
	 *
48
	 * @param  int  $id
49
	 * @return Response
50
	 */
51
	public function show($id)
52
	{
53
		$data['data'] =$this->tournamentLeaderboard->get($id);
0 ignored issues
show
Coding Style Comprehensibility introduced by
$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
54
		return $data;
55
	}
56
57
58
	/**
59
	 * Show the form for editing the specified resource.
60
	 *
61
	 * @param  int  $id
62
	 * @return Response
63
	 */
64
	public function edit($id)
65
	{
66
		//
67
	}
68
69
70
	/**
71
	 * Update the specified resource in storage.
72
	 *
73
	 * @param  int  $id
74
	 * @return Response
75
	 */
76
	public function update($id)
77
	{
78
		//
79
	}
80
81
82
	/**
83
	 * Remove the specified resource from storage.
84
	 *
85
	 * @param  int  $id
86
	 * @return Response
87
	 */
88
	public function destroy($id)
89
	{
90
		//
91
	}
92
93
94
}
95