LeagueStatisticsController::netScoresLeague() - Code Metrics - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

LeagueStatisticsController::netScoresLeague() A
last analyzed 2017-05-30 15:22 UTC

↳ Parent: LeagueStatisticsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

use GolfLeague\Statistics\League\LeagueStatistics as LeagueStatistics;

class LeagueStatisticsController extends \BaseController {
namespace YourVendor;

class YourClass { }

	public function __construct(LeagueStatistics $leagueStatistics)
    {
        $this->leagueStatistics = $leagueStatistics;
    }

    /**
	 * Display a listing of the resource.
	 *
	 * @return Response
	 */
	public function index()
	{
		return View::make('leagueStatistics');
	}


	/**
	 * Show the form for creating a new resource.
	 *
	 * @return Response
	 */
	public function create()
	{
		//
	}


	/**
	 * Store a newly created resource in storage.
	 *
	 * @return Response
	 */
	public function store()
	{
		//
	}


	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function show($id)
	{
        return $this->leagueStatistics{$id}(Input::get('year'));
	}


	/**
	 * Show the form for editing the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function edit($id)
	{
		return $id;
	}


	/**
	 * Update the specified resource in storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function update($id)
	{
		//
	}


	/**
	 * Remove the specified resource from storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function destroy($id)
	{
		//
	}

	public function netScores()
	{
		return $this->leagueStatistics->netCumulativeByPlayer(2);
		//return $this->leagueStatistics->netScoresByPlayerTop(2,5);

		//return $this->leagueStatistics->netScoresByPlayer(1);

	}

	public function netScoresLeague()
	{
		return $this->leagueStatistics->netScoresLeague();
	}

	public function netScoresLeagueTop($top)
	{
		return $this->leagueStatistics->netScoresLeagueTop($top);
	}

	public function netCumulativeByPlayer($playerId)
	{
		return $this->leagueStatistics->netCumulativeByPlayer($playerId);
	}

	public function netCumulative()
	{
		return $this->leagueStatistics->netCumulative();
	}

	public function netCumulativeByPlayerTop($playerId, $top)
	{
		return $this->leagueStatistics->netCumulativeByPlayerTop($playerId, $top);
	}

	public function netCumulativeTop($top)
	{
		$data['data'] = $this->leagueStatistics->netCumulativeTop($top);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		return $data;
	}

	public function netCumulativeTopYear($top, $year)
	{
		$data['data'] = $this->leagueStatistics->netCumulativeTopYear($top, $year);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		return $data;
	}

}


1			<?php
2
3			use GolfLeague\Statistics\League\LeagueStatistics as LeagueStatistics;
4
5			class LeagueStatisticsController extends \BaseController {
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-06 18:36 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6
7			public function __construct(LeagueStatistics $leagueStatistics)
8			{
9			$this->leagueStatistics = $leagueStatistics;
10			}
11
12			/**
13			* Display a listing of the resource.
14			*
15			* @return Response
16			*/
17			public function index()
18			{
19			return View::make('leagueStatistics');
20			}
21
22
23			/**
24			* Show the form for creating a new resource.
25			*
26			* @return Response
27			*/
28			public function create()
29			{
30			//
31			}
32
33
34			/**
35			* Store a newly created resource in storage.
36			*
37			* @return Response
38			*/
39			public function store()
40			{
41			//
42			}
43
44
45			/**
46			* Display the specified resource.
47			*
48			* @param int $id
49			* @return Response
50			*/
51			public function show($id)
52			{
53			return $this->leagueStatistics{$id}(Input::get('year'));
54			}
55
56
57			/**
58			* Show the form for editing the specified resource.
59			*
60			* @param int $id
61			* @return Response
62			*/
63			public function edit($id)
64			{
65			return $id;
66			}
67
68
69			/**
70			* Update the specified resource in storage.
71			*
72			* @param int $id
73			* @return Response
74			*/
75			public function update($id)
76			{
77			//
78			}
79
80
81			/**
82			* Remove the specified resource from storage.
83			*
84			* @param int $id
85			* @return Response
86			*/
87			public function destroy($id)
88			{
89			//
90			}
91
92			public function netScores()
93			{
94			return $this->leagueStatistics->netCumulativeByPlayer(2);
95			//return $this->leagueStatistics->netScoresByPlayerTop(2,5);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-08 16:29 UTC by Report Bug Copy Issue Report `77%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
96			//return $this->leagueStatistics->netScoresByPlayer(1);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-08 16:29 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97			}
98
99			public function netScoresLeague()
100			{
101			return $this->leagueStatistics->netScoresLeague();
102			}
103
104			public function netScoresLeagueTop($top)
105			{
106			return $this->leagueStatistics->netScoresLeagueTop($top);
107			}
108
109			public function netCumulativeByPlayer($playerId)
110			{
111			return $this->leagueStatistics->netCumulativeByPlayer($playerId);
112			}
113
114			public function netCumulative()
115			{
116			return $this->leagueStatistics->netCumulative();
117			}
118
119			public function netCumulativeByPlayerTop($playerId, $top)
120			{
121			return $this->leagueStatistics->netCumulativeByPlayerTop($playerId, $top);
122			}
123
124			public function netCumulativeTop($top)
125			{
126			$data['data'] = $this->leagueStatistics->netCumulativeTop($top);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-11 03:39 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
127			return $data;
128			}
129
130			public function netCumulativeTopYear($top, $year)
131			{
132			$data['data'] = $this->leagueStatistics->netCumulativeTopYear($top, $year);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-11 03:39 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
133			return $data;
134			}
135
136			}
137

BigBad / golfleague

LeagueStatisticsController::netScoresLeague() A last analyzed 2017-05-30 15:22 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

LeagueStatisticsController::netScoresLeague() A
last analyzed 2017-05-30 15:22 UTC