SkinsController - Code Metrics - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

SkinsController A
last analyzed 2017-05-30 15:22 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	35
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	index()	4	1
A	show()	7	1

<?php

use GolfLeague\Statistics\League\LeagueStatistics as LeagueStatistics;


class SkinsController extends \BaseController {
namespace YourVendor;

class YourClass { }

	public function __construct(LeagueStatistics $leagueStatistics)
    {
		$this->leagueStatistics = $leagueStatistics;
    }

    /**
	 * Display a listing of the resource.
	 *
	 * @return Response
	 */
	public function index()
	{
		//may use for get all
	}


	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function show($id)
	{
		$results  = $this->leagueStatistics->mostSkinsByYear($id);
		$newvalue = array_values( (array)$results );
		$data['data'] = $newvalue;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		return $data;
	}



}


1			<?php
2
3			use GolfLeague\Statistics\League\LeagueStatistics as LeagueStatistics;
4
5
6			class SkinsController extends \BaseController {
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-06 18:36 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7
8			public function __construct(LeagueStatistics $leagueStatistics)
9			{
10			$this->leagueStatistics = $leagueStatistics;
11			}
12
13			/**
14			* Display a listing of the resource.
15			*
16			* @return Response
17			*/
18			public function index()
19			{
20			//may use for get all
21			}
22
23
24			/**
25			* Display the specified resource.
26			*
27			* @param int $id
28			* @return Response
29			*/
30			public function show($id)
31			{
32			$results = $this->leagueStatistics->mostSkinsByYear($id);
33			$newvalue = array_values( (array)$results );
34			$data['data'] = $newvalue;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-06 18:34 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
35			return $data;
36			}
37
38
39
40			}
41

BigBad / golfleague

SkinsController A last analyzed 2017-05-30 15:22 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

SkinsController A
last analyzed 2017-05-30 15:22 UTC