LeaderboardController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	show()	0	7	1
A	edit()	0	4	1
A	update()	0	4	1
A	destroy()	0	4	1

<?php

use GolfLeague\Storage\Leaderboard\LeaderboardRepository as LeaderboardRepository;

class LeaderboardController extends \BaseController {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	public function __construct(LeaderboardRepository $leaderboardRepo)
    {
        $this->leaderboardRepo = $leaderboardRepo;
    }
	/**
	 * Display a listing of the resource.
	 *
	 * @return Response
	 */
	public function index()
	{
		return View::make('leaderboard');
	}

	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id

There is no parameter named $id. Was it maybe removed?

	 * @return Response
	 */
	public function show($year)
	{
		$results  = $this->leaderboardRepo->get($year);
		$newvalue = array_values( (array)$results );
		$data['data'] = $newvalue;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

		return $data;
	}


	/**
	 * Show the form for editing the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function edit($id)
	{
		//
	}


	/**
	 * Update the specified resource in storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function update($id)
	{
		//
	}


	/**
	 * Remove the specified resource from storage.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function destroy($id)
	{
		//
	}


}