EnterScoresController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	4	1
C	view()	0	63	10

<?php

class EnterScoresController extends \BaseController {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * Display a listing of the resource.
     *
     * @return Response
     */
    public function view()
    {
        /*

56% of this comment could be valid code. Did you maybe forget this after debugging?

		foreach (Score::with('player')->get() as $score) {
			echo $score->player->name . "<br>";
		}
		*/
	$holescores = Holescore::with('hole')->where('created_at', '>=', '2015-04-28')->get();
	$count = $holescores->count();

		$eagles = 0;
		$birdies = 0;
		$pars = 0;
		$bogeys = 0;
		$doubleBogeys = 0;
		$triples = 0;
		$others = 0;
		$holes = 1;
		foreach (Holescore::with('hole')->where('created_at', '>=', '2015-04-28')->get() as $holescore) {
			$diff = ($holescore->score) - ($holescore->hole->par);

			switch ($diff) {
				case -2:
					$eagles++;
					break;
				case -1:
					$birdies++;
					break;
				case 0:
					$pars++;
					break;
				case 1:
					$bogeys++;
					break;
				case 2:
					$doubleBogeys++;
					break;
				case 3:
					$triples++;
					break;
				case ($diff > 3):
					$others++;
					break;
			}
			$holes++;
			//echo $holescore->hole->number .  " score = " . $holescore->score ." " . $diff . "<br>";

38% of this comment could be valid code. Did you maybe forget this after debugging?

		}
		echo "Number of holes played by all = " . $count . "<br>";
		echo "Number of birdies =" . $birdies . "     " . round($birdies/$count,2) . "%<br>";
		echo "Number of pars = " . $pars . "     " . round($pars/$count,2) . "%<br>";
		echo "Number of bogeys =" . $bogeys . "     " . round($bogeys/$count,2) . "%<br>";
		echo "Number of double bogeys = " . $doubleBogeys . "     " . round($doubleBogeys/$count,2) . "%<br>";
		echo "Number of triples =" . $triples . "     " . round($triples/$count,2) . "%<br>";
		echo "Number of others = " . $others . "     " . round($others/$count,2) . "%<br>";
		exit();

The method view() contains an exit expression.

		$scores = Score::where('player_id', '=', 2)->orderBy('date', 'desc')->take(20)->get();

$scores = \Score::where('player_id', '=', 2)->orderBy('date', 'desc')->take(20)->get(); does not seem to be reachable.

		foreach( $scores->id as $scoreId) {
			$holescores[$score_id] = Holescore::where('score_id', '=', $scoreId)->get();
		}
		return $scores;
    }

    /**

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return Response
     */
    public function destroy($id)
    {
        //
    }

}