EquitableScoreControl::getMaxAllowableHoleScore() - Code Metrics - Inspection of "Update to Handicap code" - BigBad/GLsoftware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e64d7a...236403 )

by Michael

created 2016-08-24 20:18 UTC

EquitableScoreControl::getMaxAllowableHoleScore() B

↳ Parent: EquitableScoreControl

Complexity

Conditions	9
Paths	6

Size

Total Lines	20
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
ccs	16
cts	16
cp	1
rs	7.756
cc	9
eloc	17
nc	6
nop	2
crap	9

<?php
/**
 * Created by PhpStorm.
 * User: michaelschmidt
 * Date: 8/17/16
 * Time: 9:44 PM
 */

namespace GLsoftware\Golf;


class EquitableScoreControl
{
    private $escResultArray;


    // expecting an object or array GrossScore
    // with par and score for 18 or 9 holes
    public function adjustScores(array $scores, $courseHandicap)

    {
        foreach($scores as $score){


        }
    }

    // Using a players course handicap which is a whole number
    public function getMaxAllowableHoleScore($par, $courseHandicap)
    {
        switch(true) {
            case ($courseHandicap <= 9):
                $maxScore = $par + 2;
                break;
            case (($courseHandicap > 9) && ($courseHandicap < 20)): //10-19
                $maxScore = 7;
                break;
            case (($courseHandicap >= 20) && ($courseHandicap < 30))://20-29
                $maxScore = 8;
                break;
            case (($courseHandicap >= 30) && ($courseHandicap < 40))://30-39
                $maxScore = 9;
                break;
            case ($courseHandicap >= 40):
                $maxScore = 10;
        }
        return $maxScore;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: michaelschmidt
5		* Date: 8/17/16
6		* Time: 9:44 PM
7		*/
8
9		namespace GLsoftware\Golf;
10
11
12		class EquitableScoreControl
13		{
14		private $escResultArray;
		0 ignored issues – show Unused Code introduced 2016-08-24 20:22 UTC by Report Bug Copy Issue Report The property `$escResultArray` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16		// expecting an object or array GrossScore
17		// with par and score for 18 or 9 holes
18		public function adjustScores(array $scores, $courseHandicap)
		0 ignored issues – show Unused Code introduced 2016-08-24 20:22 UTC by Report Bug Copy Issue Report The parameter `$courseHandicap` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
19		{
20		foreach($scores as $score){
		0 ignored issues – show Unused Code introduced 2016-08-24 20:22 UTC by Report Bug Copy Issue Report This `foreach` statement is empty and can be removed. This check looks for `foreach` loops that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. Consider removing the loop. Loading history...
21
22		}
23		}
24
25		// Using a players course handicap which is a whole number
26	1	public function getMaxAllowableHoleScore($par, $courseHandicap)
27		{
28		switch(true) {
29	1	case ($courseHandicap <= 9):
30	1	$maxScore = $par + 2;
31	1	break;
32	1	case (($courseHandicap > 9) && ($courseHandicap < 20)): //10-19
33	1	$maxScore = 7;
34	1	break;
35	1	case (($courseHandicap >= 20) && ($courseHandicap < 30))://20-29
36	1	$maxScore = 8;
37	1	break;
38	1	case (($courseHandicap >= 30) && ($courseHandicap < 40))://30-39
39	1	$maxScore = 9;
40	1	break;
41	1	case ($courseHandicap >= 40):
42	1	$maxScore = 10;
43		}
44	1	return $maxScore;
		0 ignored issues – show Bug introduced 2016-08-18 03:25 UTC by Report Bug Copy Issue Report The variable `$maxScore` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
45		}
46		}
47

BigBad / GLsoftware

Push — master ( e64d7a...236403 )

EquitableScoreControl::getMaxAllowableHoleScore() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like