BiffBangPow\SSMonitor\Client\Core\ClientCommon

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getClientName()	0	6	2
A	getClientTitle()	0	6	2

<?php

namespace BiffBangPow\SSMonitor\Client\Core;

trait ClientCommon
{

    /**
     * Get the client name/identifier for this client module
     * @return string
     * @throws \Exception
     */
    public function getClientName(): string
    {
        if ($this->clientName === '') {
            throw new \Exception("No client name defined for monitoring client");
        }
        return $this->clientName;
    }

    /**
     * Get the friendly name for this client module
     * @return string
     * @throws \Exception
     */
    public function getClientTitle(): string
    {
        if ($this->config()->get('client_title')) {

It seems like config() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->config()->get('client_title');
        }
        return $this->getClientName();
    }

}