OpauthMemberLoginFormExtension::forgotPassword() - Code Metrics - BetterBrief/silverstripe-opauth - Measure and Improve Code Quality continuously with Scrutinizer

OpauthMemberLoginFormExtension::forgotPassword() A
last analyzed 2016-07-15 13:20 UTC

↳ Parent: OpauthMemberLoginFormExtension

Complexity

Conditions	4
Paths	3

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
rs	9.2
cc	4
eloc	14
nc	3
nop	1

<?php
class OpauthMemberLoginFormExtension extends Extension {
namespace YourVendor;

class YourClass { }

	/**
	 * @config
	 * @var boolean
	 */
	private static $allow_password_reset = true;


	/**
	 * Deny password resets
	 * 
	 * @param Member $member
	 * @return boolean
	 */
	public function forgotPassword($member) {
		if(Config::inst()->get('OpauthMemberLoginFormExtension', 'allow_password_reset')) {
			return null;
		}

		$identity = OpauthIdentity::get()->find('MemberID', $member->ID);
		if(!$member->Password && $identity) {
			$this->owner->sessionMessage(
				_t(
					'OpauthMemberLoginFormExtension.NoResetPassword',
					'Can\'t reset password for accounts registered through {provider}',
					array('provider' => $identity->Provider)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				),
				'bad'
			);
			return false;
		} else {
			return null;
		}
	}

}

1			<?php
2			class OpauthMemberLoginFormExtension extends Extension {
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-03 23:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
3
4			/**
5			* @config
6			* @var boolean
7			*/
8			private static $allow_password_reset = true;
			0 ignored issues – show Unused Code introduced 2015-12-03 23:54 UTC by Report Bug Copy Issue Report The property `$allow_password_reset` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10			/**
11			* Deny password resets
12			*
13			* @param Member $member
14			* @return boolean
15			*/
16			public function forgotPassword($member) {
17			if(Config::inst()->get('OpauthMemberLoginFormExtension', 'allow_password_reset')) {
18			return null;
19			}
20
21			$identity = OpauthIdentity::get()->find('MemberID', $member->ID);
22			if(!$member->Password && $identity) {
23			$this->owner->sessionMessage(
24			_t(
25			'OpauthMemberLoginFormExtension.NoResetPassword',
26			'Can\'t reset password for accounts registered through {provider}',
27			array('provider' => $identity->Provider)
			0 ignored issues – show Documentation introduced 2015-12-03 23:54 UTC by Report Bug Copy Issue Report `array('provider' => $identity->Provider)` is of type `array<string,?,{"provider":"?"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			),
29			'bad'
30			);
31			return false;
32			} else {
33			return null;
34			}
35			}
36
37			}

BetterBrief / silverstripe-opauth

OpauthMemberLoginFormExtension::forgotPassword() A last analyzed 2016-07-15 13:20 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

OpauthMemberLoginFormExtension::forgotPassword() A
last analyzed 2016-07-15 13:20 UTC