check_databases_compatibility() - Code Metrics - Inspection of "Fixes Django 1.8 compatibility." - noripyt/django-cachalot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce9ec0...f82c48 )

by Bertrand

created 2017-06-04 17:27 UTC

check_databases_compatibility() D

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
c	1
b	0
f	0
dl	0
loc	53
rs	4.9852

How to fix Long Method

from django import VERSION as django_version
from django.apps import AppConfig
from django.conf import settings
from django.core.checks import register, Tags, Warning, Error
from cachalot.utils import ITERABLES

from .monkey_patch import patch
from .settings import (
    cachalot_settings, SUPPORTED_CACHE_BACKENDS, SUPPORTED_DATABASE_ENGINES,
    SUPPORTED_ONLY)


DJANGO_GTE_1_10 = django_version[:2] >= (1, 10)


@register(*((Tags.caches, Tags.compatibility)
            if DJANGO_GTE_1_10 else (Tags.compatibility,)))
def check_cache_compatibility(app_configs, **kwargs):
    cache = settings.CACHES[cachalot_settings.CACHALOT_CACHE]
    cache_backend = cache['BACKEND']
    if cache_backend not in SUPPORTED_CACHE_BACKENDS:
        return [Warning(
            'Cache backend %r is not supported by django-cachalot.'
            % cache_backend,
            hint='Switch to a supported cache backend '
                 'like Redis or Memcached.',
            id='cachalot.W001')]
    return []


@register(*((Tags.database, Tags.compatibility)
            if DJANGO_GTE_1_10 else (Tags.compatibility,)))
def check_databases_compatibility(app_configs, **kwargs):
    errors = []
    databases = settings.DATABASES
    original_enabled_databases = getattr(settings, 'CACHALOT_DATABASES',
                                         SUPPORTED_ONLY)
    enabled_databases = cachalot_settings.CACHALOT_DATABASES
    if original_enabled_databases == SUPPORTED_ONLY:
        if not cachalot_settings.CACHALOT_DATABASES:
            errors.append(Warning(
                'None of the configured databases are supported '
                'by django-cachalot.',
                hint='Use a supported database, or remove django-cachalot, or '
                     'put at least one database alias in `CACHALOT_DATABASES` '
                     'to force django-cachalot to use it.',
                id='cachalot.W002'
            ))
    elif enabled_databases.__class__ in ITERABLES:
        for db_alias in enabled_databases:
            if db_alias in databases:
                engine = databases[db_alias]['ENGINE']
                if engine not in SUPPORTED_DATABASE_ENGINES:
                    errors.append(Warning(
                        'Database engine %r is not supported '
                        'by django-cachalot.' % engine,
                        hint='Switch to a supported database engine.',
                        id='cachalot.W003'
                    ))
            else:
                errors.append(Error(
                    'Database alias %r from `CACHALOT_DATABASES` '
                    'is not defined in `DATABASES`.' % db_alias,
                    hint='Change `CACHALOT_DATABASES` to be compliant with'
                         '`CACHALOT_DATABASES`',
                    id='cachalot.E001',
                ))

        if not enabled_databases:
            errors.append(Warning(
                'Django-cachalot is useless because no database '
                'is configured in `CACHALOT_DATABASES`.',
                hint='Reconfigure django-cachalot or remove it.',
                id='cachalot.W004'
            ))
    else:
        errors.append(Error(
            "`CACHALOT_DATABASES` must be either %r or a list, tuple, "
            "frozenset or set of database aliases." % SUPPORTED_ONLY,
            hint='Remove `CACHALOT_DATABASES` or change it.',
            id='cachalot.E002',
        ))
    return errors


class CachalotConfig(AppConfig):
    name = 'cachalot'
    patched = False

    def ready(self):
        cachalot_settings.load()

        if not self.patched:
            patch()
            self.patched = True


1			from django import VERSION as django_version
2			from django.apps import AppConfig
3			from django.conf import settings
4			from django.core.checks import register, Tags, Warning, Error
5			from cachalot.utils import ITERABLES
6
7			from .monkey_patch import patch
8			from .settings import (
9			cachalot_settings, SUPPORTED_CACHE_BACKENDS, SUPPORTED_DATABASE_ENGINES,
10			SUPPORTED_ONLY)
11
12
13			DJANGO_GTE_1_10 = django_version[:2] >= (1, 10)
14
15
16			@register(*((Tags.caches, Tags.compatibility)
17			if DJANGO_GTE_1_10 else (Tags.compatibility,)))
18			def check_cache_compatibility(app_configs, **kwargs):
19			cache = settings.CACHES[cachalot_settings.CACHALOT_CACHE]
20			cache_backend = cache['BACKEND']
21			if cache_backend not in SUPPORTED_CACHE_BACKENDS:
22			return [Warning(
23			'Cache backend %r is not supported by django-cachalot.'
24			% cache_backend,
25			hint='Switch to a supported cache backend '
26			'like Redis or Memcached.',
27			id='cachalot.W001')]
28			return []
29
30
31			@register(*((Tags.database, Tags.compatibility)
32			if DJANGO_GTE_1_10 else (Tags.compatibility,)))
33			def check_databases_compatibility(app_configs, **kwargs):
34			errors = []
35			databases = settings.DATABASES
36			original_enabled_databases = getattr(settings, 'CACHALOT_DATABASES',
37			SUPPORTED_ONLY)
38			enabled_databases = cachalot_settings.CACHALOT_DATABASES
39			if original_enabled_databases == SUPPORTED_ONLY:
40			if not cachalot_settings.CACHALOT_DATABASES:
41			errors.append(Warning(
42			'None of the configured databases are supported '
43			'by django-cachalot.',
44			hint='Use a supported database, or remove django-cachalot, or '
45			'put at least one database alias in `CACHALOT_DATABASES` '
46			'to force django-cachalot to use it.',
47			id='cachalot.W002'
48			))
49			elif enabled_databases.__class__ in ITERABLES:
50			for db_alias in enabled_databases:
51			if db_alias in databases:
52			engine = databases[db_alias]['ENGINE']
53			if engine not in SUPPORTED_DATABASE_ENGINES:
54			errors.append(Warning(
55			'Database engine %r is not supported '
56			'by django-cachalot.' % engine,
57			hint='Switch to a supported database engine.',
58			id='cachalot.W003'
59			))
60			else:
61			errors.append(Error(
62			'Database alias %r from `CACHALOT_DATABASES` '
63			'is not defined in `DATABASES`.' % db_alias,
64			hint='Change `CACHALOT_DATABASES` to be compliant with'
65			'`CACHALOT_DATABASES`',
66			id='cachalot.E001',
67			))
68
69			if not enabled_databases:
70			errors.append(Warning(
71			'Django-cachalot is useless because no database '
72			'is configured in `CACHALOT_DATABASES`.',
73			hint='Reconfigure django-cachalot or remove it.',
74			id='cachalot.W004'
75			))
76			else:
77			errors.append(Error(
78			"`CACHALOT_DATABASES` must be either %r or a list, tuple, "
79			"frozenset or set of database aliases." % SUPPORTED_ONLY,
80			hint='Remove `CACHALOT_DATABASES` or change it.',
81			id='cachalot.E002',
82			))
83			return errors
84
85
86			class CachalotConfig(AppConfig):
87			name = 'cachalot'
88			patched = False
89
90			def ready(self):
91			cachalot_settings.load()
92
93			if not self.patched:
94			patch()
95			self.patched = True
96

noripyt / django-cachalot

Push — master ( ce9ec0...f82c48 )

check_databases_compatibility() D

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like