DebugNodeVisitor::enterNode() - Code Metrics - Benoth/static-reflection - Measure and Improve Code Quality continuously with Scrutinizer

DebugNodeVisitor::enterNode() A
last analyzed 2016-05-18 18:35 UTC

↳ Parent: DebugNodeVisitor

Complexity

Conditions	4
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	9.2
cc	4
eloc	2
nc	1
nop	1

<?php

namespace Benoth\StaticReflection\Parser;

use PhpParser\Node as NodeInterface;
use PhpParser\NodeVisitorAbstract;

/**
 * @codeCoverageIgnore
 */
class DebugNodeVisitor extends NodeVisitorAbstract
{
    protected $level = 0;

    public function enterNode(NodeInterface $node)
    {
        $this->debug(str_repeat('  ', ++$this->level).$node->getType().(property_exists($node, 'name') ? ' '.(method_exists($node->name, 'toString') ? $node->name->toString() : $node->name) : '').(method_exists($node, 'getLine') ? ' L:'.$node->getLine() : '').PHP_EOL);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function leaveNode(NodeInterface $node)
    {
        --$this->level;
    }

    public function beforeTraverse(array $nodes)
    {
        $this->level = 0;
        $this->debug('BeforeTraverse'.PHP_EOL);
    }

    public function afterTraverse(array $nodes)
    {
        $this->level = 0;
        $this->debug('AfterTraverse'.PHP_EOL);
    }

    /**
     * @param string $text
     */
    protected function debug($text)
    {
        echo $text;
    }
}


1			<?php
2
3			namespace Benoth\StaticReflection\Parser;
4
5			use PhpParser\Node as NodeInterface;
6			use PhpParser\NodeVisitorAbstract;
7
8			/**
9			* @codeCoverageIgnore
10			*/
11			class DebugNodeVisitor extends NodeVisitorAbstract
12			{
13			protected $level = 0;
14
15			public function enterNode(NodeInterface $node)
16			{
17			$this->debug(str_repeat(' ', ++$this->level).$node->getType().(property_exists($node, 'name') ? ' '.(method_exists($node->name, 'toString') ? $node->name->toString() : $node->name) : '').(method_exists($node, 'getLine') ? ' L:'.$node->getLine() : '').PHP_EOL);
			0 ignored issues – show Bug introduced 2016-05-18 12:13 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `PhpParser\Node` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
18			}
19
20			public function leaveNode(NodeInterface $node)
21			{
22			--$this->level;
23			}
24
25			public function beforeTraverse(array $nodes)
26			{
27			$this->level = 0;
28			$this->debug('BeforeTraverse'.PHP_EOL);
29			}
30
31			public function afterTraverse(array $nodes)
32			{
33			$this->level = 0;
34			$this->debug('AfterTraverse'.PHP_EOL);
35			}
36
37			/**
38			* @param string $text
39			*/
40			protected function debug($text)
41			{
42			echo $text;
43			}
44			}
45

Benoth / static-reflection

DebugNodeVisitor::enterNode() A last analyzed 2016-05-18 18:35 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

DebugNodeVisitor::enterNode() A
last analyzed 2016-05-18 18:35 UTC