Issues in UsageValidator.php (master) - Issues in master - Benestar/asparagus - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/UsageValidator.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Asparagus;

use RangeException;

/**
 * Package-private class to validate the usage of variables and prefixes.
 *
 * @license GNU GPL v2+
 * @author Bene* < [email protected] >
 */
class UsageValidator {

	/**
	 * @var string[] list of used variables without prefixes
	 */
	private $usedVariables = array();

	/**
	 * @var string[] list of defined variables without prefixes
	 */
	private $definedVariables = array();

	/**
	 * @var string[] list of used prefixes
	 */
	private $usedPrefixes = array();

	/**
	 * @var string[] list of defined prefixes
	 */
	private $definedPrefixes = array();

	/**
	 * @var RegexHelper
	 */
	private $regexHelper;

	public function __construct() {
		$this->regexHelper = new RegexHelper();
	}

	/**
	 * Trackes the list of variables as used.
	 *
	 * @param string[]|string $variables list of variables without prefixes
	 */
	public function trackUsedVariables( $variables ) {
		if ( !is_array( $variables ) ) {
			$variables = $this->matchVariables( $variables );
		}

		$this->usedVariables = array_unique( array_merge( $this->usedVariables, $variables ) );

	}

	/**
	 * Trackes the list of variables as defined.
	 *
	 * @param string[]|string $variables list of variables without prefixes
	 */
	public function trackDefinedVariables( $variables )  {
		if ( !is_array( $variables ) ) {
			$variables = $this->matchVariables( $variables );
		}

		$this->definedVariables = array_unique( array_merge( $this->definedVariables, $variables ) );

	}

	/**
	 * Trackes the list of prefixes as used.
	 *
	 * @param string[]|string $prefixes list of prefixes
	 */
	public function trackUsedPrefixes( $prefixes )  {
		if ( !is_array( $prefixes ) ) {
			$prefixes = $this->matchPrefixes( $prefixes );
		}

		$this->usedPrefixes = array_merge( $this->usedPrefixes, $prefixes );

	}

	/**
	 * Trackes the list of prefixes as defined.
	 *
	 * @param string[]|string $prefixes list of prefixes
	 */
	public function trackDefinedPrefixes( $prefixes )  {
		if ( !is_array( $prefixes ) ) {
			$prefixes = $this->matchPrefixes( $prefixes );
		}

		$this->definedPrefixes = array_merge( $this->definedPrefixes, $prefixes );

	}

	private function matchVariables( $expression ) {
		return $this->regexHelper->getMatches( '(^|\W)(?<!AS )\{variable}', $expression, 2 );
	}

	private function matchPrefixes( $expression ) {
		return $this->regexHelper->getMatches( '(^|\W)(\{prefix}):\{name}', $expression, 2 );
	}

	/**
	 * Validates the variables and prefixes tracked.
	 *
	 * @throws RangeException
	 */
	public function validate() {
		$this->validatePrefixes();
		$this->validateVariables();
	}

	private function validatePrefixes() {
		$diff = array_diff( $this->usedPrefixes, $this->definedPrefixes );
		if ( !empty( $diff ) ) {
			throw new RangeException( 'The prefixes ' . implode( ', ', $diff ) . ' aren\'t defined for this query.' );
		}
	}

	private function validateVariables() {
		$diff = array_diff( $this->usedVariables, $this->definedVariables );
		if ( !empty( $diff ) ) {
			throw new RangeException( 'The variables ?' . implode( ', ?', $diff ) . ' don\'t occur in this query.' );
		}
	}

}


1			<?php
2
3			namespace Asparagus;
4
5			use RangeException;
6
7			/**
8			* Package-private class to validate the usage of variables and prefixes.
9			*
10			* @license GNU GPL v2+
11			* @author Bene* < [email protected] >
12			*/
13			class UsageValidator {
14
15			/**
16			* @var string[] list of used variables without prefixes
17			*/
18			private $usedVariables = array();
19
20			/**
21			* @var string[] list of defined variables without prefixes
22			*/
23			private $definedVariables = array();
24
25			/**
26			* @var string[] list of used prefixes
27			*/
28			private $usedPrefixes = array();
29
30			/**
31			* @var string[] list of defined prefixes
32			*/
33			private $definedPrefixes = array();
34
35			/**
36			* @var RegexHelper
37			*/
38			private $regexHelper;
39
40			public function __construct() {
41			$this->regexHelper = new RegexHelper();
42			}
43
44			/**
45			* Trackes the list of variables as used.
46			*
47			* @param string[]\|string $variables list of variables without prefixes
48			*/
49			public function trackUsedVariables( $variables ) {
50			if ( !is_array( $variables ) ) {
51			$variables = $this->matchVariables( $variables );
52			}
53
54			$this->usedVariables = array_unique( array_merge( $this->usedVariables, $variables ) );
			0 ignored issues – show Documentation Bug introduced 2016-01-20 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_unique(array_merge...Variables, $variables))` of type `array` is incompatible with the declared type `array<integer,string>` of property `$usedVariables`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
55			}
56
57			/**
58			* Trackes the list of variables as defined.
59			*
60			* @param string[]\|string $variables list of variables without prefixes
61			*/
62			public function trackDefinedVariables( $variables ) {
63			if ( !is_array( $variables ) ) {
64			$variables = $this->matchVariables( $variables );
65			}
66
67			$this->definedVariables = array_unique( array_merge( $this->definedVariables, $variables ) );
			0 ignored issues – show Documentation Bug introduced 2016-01-20 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_unique(array_merge...Variables, $variables))` of type `array` is incompatible with the declared type `array<integer,string>` of property `$definedVariables`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
68			}
69
70			/**
71			* Trackes the list of prefixes as used.
72			*
73			* @param string[]\|string $prefixes list of prefixes
74			*/
75			public function trackUsedPrefixes( $prefixes ) {
76			if ( !is_array( $prefixes ) ) {
77			$prefixes = $this->matchPrefixes( $prefixes );
78			}
79
80			$this->usedPrefixes = array_merge( $this->usedPrefixes, $prefixes );
			0 ignored issues – show Documentation Bug introduced 2016-01-20 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_merge($this->usedPrefixes, $prefixes)` of type `array` is incompatible with the declared type `array<integer,string>` of property `$usedPrefixes`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
81			}
82
83			/**
84			* Trackes the list of prefixes as defined.
85			*
86			* @param string[]\|string $prefixes list of prefixes
87			*/
88			public function trackDefinedPrefixes( $prefixes ) {
89			if ( !is_array( $prefixes ) ) {
90			$prefixes = $this->matchPrefixes( $prefixes );
91			}
92
93			$this->definedPrefixes = array_merge( $this->definedPrefixes, $prefixes );
			0 ignored issues – show Documentation Bug introduced 2016-01-20 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_merge($this->definedPrefixes, $prefixes)` of type `array` is incompatible with the declared type `array<integer,string>` of property `$definedPrefixes`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
94			}
95
96			private function matchVariables( $expression ) {
97			return $this->regexHelper->getMatches( '(^\|\W)(?<!AS )\{variable}', $expression, 2 );
98			}
99
100			private function matchPrefixes( $expression ) {
101			return $this->regexHelper->getMatches( '(^\|\W)(\{prefix}):\{name}', $expression, 2 );
102			}
103
104			/**
105			* Validates the variables and prefixes tracked.
106			*
107			* @throws RangeException
108			*/
109			public function validate() {
110			$this->validatePrefixes();
111			$this->validateVariables();
112			}
113
114			private function validatePrefixes() {
115			$diff = array_diff( $this->usedPrefixes, $this->definedPrefixes );
116			if ( !empty( $diff ) ) {
117			throw new RangeException( 'The prefixes ' . implode( ', ', $diff ) . ' aren\'t defined for this query.' );
118			}
119			}
120
121			private function validateVariables() {
122			$diff = array_diff( $this->usedVariables, $this->definedVariables );
123			if ( !empty( $diff ) ) {
124			throw new RangeException( 'The variables ?' . implode( ', ?', $diff ) . ' don\'t occur in this query.' );
125			}
126			}
127
128			}
129

Benestar / asparagus

Issues (10)

Security Analysis no request data

src/UsageValidator.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like