It seems like null === $anId ? \Ramsey...4()->toString() : $anId can also be of type double or boolean. However, the property $id is declared as type string|integer. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
46
}
47
48
/**
49
* Gets the id.
50
*
51
* @return string|int
52
*/
53
public function id()
54
{
55
return $this->id;
56
}
57
58
/**
59
* Method that checks if the id given is equal to the current.
60
*
61
* @param UserId $anId The id
62
*
63
* @return bool
64
*/
65
public function equals(UserId $anId)
66
{
67
return $this->id() === $anId->id();
68
}
69
70
/**
71
* Magic method that represents the user id in string format.
This check compares the return type specified in the @return annotation of a function
or method doc comment with the types returned by the function and raises an issue if they
mismatch.
BenGorUser /
User
Loading history...
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.