Conditions | 1 |
Paths | 1 |
Total Lines | 135 |
Code Lines | 80 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
180 | private function eventBus(ContainerBuilder $container, $file) |
||
181 | { |
||
182 | $busId = 'bengor.file.simple_bus_' . $file . '_event_bus'; |
||
183 | $middlewareTag = 'bengor_file_' . $file . '_event_bus_middleware'; |
||
184 | $subscriberTag = 'bengor_file_' . $file . '_event_subscriber'; |
||
185 | |||
186 | // Define the event bus for the given file type |
||
187 | // The middleware tag string will be later used to add |
||
188 | // required middleware to this specific event bus |
||
189 | $container->setDefinition( |
||
190 | $busId, |
||
191 | (new Definition( |
||
192 | MessageBusSupportingMiddleware::class |
||
193 | ))->addTag('message_bus', [ |
||
194 | 'type' => 'event', |
||
195 | 'middleware_tag' => $middlewareTag, |
||
196 | ])->setPublic(false) |
||
197 | ); |
||
198 | |||
199 | // Find services tagged with $middlewareTag string and add |
||
200 | // them to the current file type's event bus |
||
201 | (new ConfigureMiddlewares($busId, $middlewareTag))->process($container); |
||
202 | |||
203 | // Declares callable resolver for the current file type's event bus |
||
204 | $container->setDefinition( |
||
205 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.callable_resolver', |
||
206 | (new Definition( |
||
207 | ServiceLocatorAwareCallableResolver::class, [ |
||
208 | [ |
||
209 | new Reference('service_container'), 'get', |
||
210 | ], |
||
211 | ] |
||
212 | ))->setPublic(false) |
||
213 | ); |
||
214 | |||
215 | // Declares class based event name resolver for the current file type's event bus |
||
216 | $container->setDefinition( |
||
217 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.class_based_event_name_resolver', |
||
218 | (new Definition( |
||
219 | ClassBasedNameResolver::class |
||
220 | ))->setPublic(false) |
||
221 | ); |
||
222 | |||
223 | // Declares the event subscribers collection for the current file type's event bus, |
||
224 | // will contain the association between events an subscribers |
||
225 | $container->setDefinition( |
||
226 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.event_subscribers_collection', |
||
227 | (new Definition( |
||
228 | CallableCollection::class, [ |
||
229 | [], |
||
230 | $container->getDefinition( |
||
231 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.callable_resolver' |
||
232 | ), |
||
233 | ] |
||
234 | ))->setPublic(false) |
||
235 | ); |
||
236 | |||
237 | // Declares the subscriber resolver with the NameResolver |
||
238 | // strategy and SubscriberCollection key values for Event => Subscriber |
||
239 | $container->setDefinition( |
||
240 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.event_subscribers_resolver', |
||
241 | (new Definition( |
||
242 | NameBasedMessageSubscriberResolver::class, [ |
||
243 | $container->getDefinition( |
||
244 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.class_based_event_name_resolver' |
||
245 | ), |
||
246 | $container->getDefinition( |
||
247 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.event_subscribers_collection' |
||
248 | ), |
||
249 | ] |
||
250 | ))->setPublic(false) |
||
251 | ); |
||
252 | |||
253 | // Declares the Subscriber |
||
254 | $container |
||
255 | ->findDefinition( |
||
256 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.delegates_to_message_handler_middleware' |
||
257 | ) |
||
258 | ->addArgument( |
||
259 | $container->getDefinition( |
||
260 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.event_subscribers_resolver' |
||
261 | ) |
||
262 | )->setPublic(false); |
||
263 | |||
264 | // Declares the tag that will be used to associate the |
||
265 | // subscribers to the current file type's event bus |
||
266 | (new RegisterSubscribers( |
||
267 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.event_subscribers_collection', |
||
268 | $subscriberTag, |
||
269 | 'subscribes_to' |
||
270 | ))->process($container); |
||
271 | |||
272 | // Decorate SimpleBus' event bus with BenGorFile's event bus |
||
273 | $container->setDefinition( |
||
274 | 'bengor_file.' . $file . '.event_bus', |
||
275 | new Definition( |
||
276 | SimpleBusFileEventBus::class, [ |
||
277 | $container->getDefinition($busId), |
||
278 | ] |
||
279 | ) |
||
280 | ); |
||
281 | |||
282 | // All about aggregate recorded message |
||
283 | $container->setDefinition( |
||
284 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.aggregates_recorded_messages', |
||
285 | new Definition( |
||
286 | AggregatesRecordedMessages::class, [ |
||
287 | [], |
||
288 | ] |
||
289 | ) |
||
290 | )->setPublic(false); |
||
291 | $container |
||
292 | ->findDefinition( |
||
293 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.handles_recorded_messages_middleware' |
||
294 | ) |
||
295 | ->setArguments([ |
||
296 | $container->getDefinition( |
||
297 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.aggregates_recorded_messages' |
||
298 | ), |
||
299 | $container->getDefinition($busId), |
||
300 | ])->setPublic(false); |
||
301 | (new RegisterMessageRecorders( |
||
302 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.aggregates_recorded_messages', |
||
303 | 'event_recorder' |
||
304 | ))->process($container); |
||
305 | |||
306 | CompilerPassUtil::prependBeforeOptimizationPass( |
||
307 | $container, |
||
308 | new AddMiddlewareTags( |
||
309 | 'bengor_file.simple_bus_bridge_bundle.' . $file . '_event_bus.handles_recorded_messages_middleware', |
||
310 | ['command'], |
||
311 | 200 |
||
312 | ) |
||
313 | ); |
||
314 | } |
||
315 | } |
||
316 |