SqlListOfIdsSpecification::__construct() - Code Metrics - Inspection of "Added List files of ids query" - BenGorFile/File - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( adef2f...37f76d )

by Beñat

created 2017-11-30 22:14 UTC

SqlListOfIdsSpecification::__construct() A

↳ Parent: SqlListOfIdsSpecification

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	3

<?php

/*
 * This file is part of the BenGorFile package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace BenGorFile\File\Infrastructure\Persistence\Sql;

/**
 * @author Beñat Espiña <[email protected]>
 */
class SqlListOfIdsSpecification implements SqlQuerySpecification, SqlCountSpecification
{
    private $ids;
    private $offset;
    private $limit;

    public function __construct(array $ids, $offset, $limit)
    {
        $this->ids = $ids;
        $this->offset = $offset;
        $this->limit = $limit;
    }

    public function buildQuery()

    {
        $whereClause = $this->buildWhere();
        $limitClause = $this->buildLimit();
        $query = "SELECT * FROM file f $whereClause ORDER BY f.updated_on DESC $limitClause";
        $parameters = $this->buildParameters();

        return [$query, $parameters];
    }

    public function buildCount()

    {
        $whereClause = $this->buildWhere();
        $limitClause = $this->buildLimit();
        $query = "SELECT COUNT(*) FROM file f $whereClause ORDER BY f.updated_on DESC $limitClause";

        return [$query, $this->buildParameters()];
    }

    private function buildWhere()
    {
        $whereClause = !empty($this->ids) ? 'WHERE f.id IN (:ids) ' : '';

        return $whereClause;
    }

    private function buildLimit()
    {
        $limitClause = $this->limit > 0 ? 'LIMIT :limit OFFSET :offset' : '';

        return $limitClause;
    }

    private function buildParameters()
    {
        $parameters = [];
        if (!empty($this->name)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $parameters = array_merge([':ids' => implode(',', $this->ids)], $parameters);
        }

        if ($this->limit > 0) {
            $parameters = array_merge([':limit' => $this->limit, ':offset' => $this->offset], $parameters);
        }

        return $parameters;
    }
}


1		<?php
2
3		/*
4		* This file is part of the BenGorFile package.
5		*
6		* (c) Beñat Espiña <[email protected]>
7		* (c) Gorka Laucirica <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		namespace BenGorFile\File\Infrastructure\Persistence\Sql;
14
15		/**
16		* @author Beñat Espiña <[email protected]>
17		*/
18		class SqlListOfIdsSpecification implements SqlQuerySpecification, SqlCountSpecification
19		{
20		private $ids;
21		private $offset;
22		private $limit;
23
24		public function __construct(array $ids, $offset, $limit)
25		{
26		$this->ids = $ids;
27		$this->offset = $offset;
28		$this->limit = $limit;
29		}
30
31	View Code Duplication	public function buildQuery()
		0 ignored issues – show Duplication introduced 2017-11-30 22:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$whereClause = $this->buildWhere();
34		$limitClause = $this->buildLimit();
35		$query = "SELECT * FROM file f $whereClause ORDER BY f.updated_on DESC $limitClause";
36		$parameters = $this->buildParameters();
37
38		return [$query, $parameters];
39		}
40
41	View Code Duplication	public function buildCount()
		0 ignored issues – show Duplication introduced 2017-11-30 22:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$whereClause = $this->buildWhere();
44		$limitClause = $this->buildLimit();
45		$query = "SELECT COUNT(*) FROM file f $whereClause ORDER BY f.updated_on DESC $limitClause";
46
47		return [$query, $this->buildParameters()];
48		}
49
50		private function buildWhere()
51		{
52		$whereClause = !empty($this->ids) ? 'WHERE f.id IN (:ids) ' : '';
53
54		return $whereClause;
55		}
56
57		private function buildLimit()
58		{
59		$limitClause = $this->limit > 0 ? 'LIMIT :limit OFFSET :offset' : '';
60
61		return $limitClause;
62		}
63
64		private function buildParameters()
65		{
66		$parameters = [];
67		if (!empty($this->name)) {
		0 ignored issues – show Bug introduced 2017-11-30 22:16 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
68		$parameters = array_merge([':ids' => implode(',', $this->ids)], $parameters);
69		}
70
71		if ($this->limit > 0) {
72		$parameters = array_merge([':limit' => $this->limit, ':offset' => $this->offset], $parameters);
73		}
74
75		return $parameters;
76		}
77		}
78

BenGorFile / File

Push — master ( adef2f...37f76d )

SqlListOfIdsSpecification::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like