Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like JsonContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use JsonContext, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class JsonContext extends BaseContext |
||
| 15 | { |
||
| 16 | protected $inspector; |
||
| 17 | |||
| 18 | protected $httpCallResultPool; |
||
| 19 | |||
| 20 | public function __construct(HttpCallResultPool $httpCallResultPool, $evaluationMode = 'javascript') |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Checks, that the response is correct JSON |
||
| 28 | * |
||
| 29 | * @Then the response should be in JSON |
||
| 30 | */ |
||
| 31 | public function theResponseShouldBeInJson() |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Checks, that the response is not correct JSON |
||
| 38 | * |
||
| 39 | * @Then the response should not be in JSON |
||
| 40 | */ |
||
| 41 | public function theResponseShouldNotBeInJson() |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Checks, that given JSON node is equal to given value |
||
| 51 | * |
||
| 52 | * @Then the JSON node :node should be equal to :text |
||
| 53 | */ |
||
| 54 | public function theJsonNodeShouldBeEqualTo($node, $text) |
||
| 66 | |||
| 67 | /** |
||
| 68 | * Checks, that given JSON nodes are equal to givens values |
||
| 69 | * |
||
| 70 | * @Then the JSON nodes should be equal to: |
||
| 71 | */ |
||
| 72 | public function theJsonNodesShouldBeEqualTo(TableNode $nodes) |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Checks, that given JSON node matches given pattern |
||
| 81 | * |
||
| 82 | * @Then the JSON node :node should match :pattern |
||
| 83 | */ |
||
| 84 | public function theJsonNodeShouldMatch($node, $pattern) |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Checks, that given JSON node is null |
||
| 99 | * |
||
| 100 | * @Then the JSON node :node should be null |
||
| 101 | */ |
||
| 102 | public function theJsonNodeShouldBeNull($node) |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Checks, that given JSON node is not null. |
||
| 117 | * |
||
| 118 | * @Then the JSON node :node should not be null |
||
| 119 | */ |
||
| 120 | public function theJsonNodeShouldNotBeNull($node) |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Checks, that given JSON node is true |
||
| 129 | * |
||
| 130 | * @Then the JSON node :node should be true |
||
| 131 | */ |
||
| 132 | public function theJsonNodeShouldBeTrue($node) |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Checks, that given JSON node is false |
||
| 147 | * |
||
| 148 | * @Then the JSON node :node should be false |
||
| 149 | */ |
||
| 150 | public function theJsonNodeShouldBeFalse($node) |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Checks, that given JSON node is equal to the given string |
||
| 165 | * |
||
| 166 | * @Then the JSON node :node should be equal to the string :text |
||
| 167 | */ |
||
| 168 | View Code Duplication | public function theJsonNodeShouldBeEqualToTheString($node, $text) |
|
| 180 | |||
| 181 | /** |
||
| 182 | * Checks, that given JSON node is equal to the given number |
||
| 183 | * |
||
| 184 | * @Then the JSON node :node should be equal to the number :number |
||
| 185 | */ |
||
| 186 | View Code Duplication | public function theJsonNodeShouldBeEqualToTheNumber($node, $number) |
|
| 198 | |||
| 199 | /** |
||
| 200 | * Checks, that given JSON node has N element(s) |
||
| 201 | * |
||
| 202 | * @Then the JSON node :node should have :count element(s) |
||
| 203 | */ |
||
| 204 | public function theJsonNodeShouldHaveElements($node, $count) |
||
| 212 | |||
| 213 | /** |
||
| 214 | * Checks, that given JSON node contains given value |
||
| 215 | * |
||
| 216 | * @Then the JSON node :node should contain :text |
||
| 217 | */ |
||
| 218 | View Code Duplication | public function theJsonNodeShouldContain($node, $text) |
|
| 226 | |||
| 227 | /** |
||
| 228 | * Checks, that given JSON nodes contains values |
||
| 229 | * |
||
| 230 | * @Then the JSON nodes should contain: |
||
| 231 | */ |
||
| 232 | public function theJsonNodesShouldContain(TableNode $nodes) |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Checks, that given JSON node does not contain given value |
||
| 241 | * |
||
| 242 | * @Then the JSON node :node should not contain :text |
||
| 243 | */ |
||
| 244 | View Code Duplication | public function theJsonNodeShouldNotContain($node, $text) |
|
| 252 | |||
| 253 | /** |
||
| 254 | * Checks, that given JSON nodes does not contain given value |
||
| 255 | * |
||
| 256 | * @Then the JSON nodes should not contain: |
||
| 257 | */ |
||
| 258 | public function theJsonNodesShouldNotContain(TableNode $nodes) |
||
| 264 | |||
| 265 | /** |
||
| 266 | * Checks, that given JSON node exist |
||
| 267 | * |
||
| 268 | * @Then the JSON node :name should exist |
||
| 269 | */ |
||
| 270 | public function theJsonNodeShouldExist($name) |
||
| 281 | |||
| 282 | /** |
||
| 283 | * Checks, that given JSON node does not exist |
||
| 284 | * |
||
| 285 | * @Then the JSON node :name should not exist |
||
| 286 | */ |
||
| 287 | public function theJsonNodeShouldNotExist($name) |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @Then the JSON should be valid according to this schema: |
||
| 296 | */ |
||
| 297 | public function theJsonShouldBeValidAccordingToThisSchema(PyStringNode $schema) |
||
| 304 | |||
| 305 | /** |
||
| 306 | * @Then the JSON should be invalid according to this schema: |
||
| 307 | */ |
||
| 308 | public function theJsonShouldBeInvalidAccordingToThisSchema(PyStringNode $schema) |
||
| 314 | |||
| 315 | /** |
||
| 316 | * @Then the JSON should be valid according to the schema :filename |
||
| 317 | */ |
||
| 318 | public function theJsonShouldBeValidAccordingToTheSchema($filename) |
||
| 330 | |||
| 331 | /** |
||
| 332 | * @Then the JSON should be invalid according to the schema :filename |
||
| 333 | */ |
||
| 334 | public function theJsonShouldBeInvalidAccordingToTheSchema($filename) |
||
| 342 | |||
| 343 | /** |
||
| 344 | * @Then the JSON should be equal to: |
||
| 345 | */ |
||
| 346 | public function theJsonShouldBeEqualTo(PyStringNode $content) |
||
| 362 | |||
| 363 | /** |
||
| 364 | * @Then print last JSON response |
||
| 365 | */ |
||
| 366 | public function printLastJsonResponse() |
||
| 371 | |||
| 372 | /** |
||
| 373 | * Checks, that response JSON matches with a swagger dump |
||
| 374 | * |
||
| 375 | * @Then the JSON should be valid according to swagger :dumpPath dump schema :schemaName |
||
| 376 | */ |
||
| 377 | public function theJsonShouldBeValidAccordingToTheSwaggerSchema($dumpPath, $schemaName) |
||
| 393 | |||
| 394 | /** |
||
| 395 | * Checks if the json node value is a boolean not an integer. |
||
| 396 | * |
||
| 397 | * @Then the JSON node :name should be a boolean |
||
| 398 | */ |
||
| 399 | public function theJSONNodeShouldBeaBoolean($node) |
||
| 405 | |||
| 406 | /** |
||
| 407 | * Checks if the json node value is an integer. |
||
| 408 | * |
||
| 409 | * @Then the JSON node :name should be an integer |
||
| 410 | */ |
||
| 411 | public function theJSONNodeShouldBeanInteger($node) |
||
| 417 | |||
| 418 | /** |
||
| 419 | * |
||
| 420 | * Checks, that response JSON not matches with a swagger dump |
||
| 421 | * |
||
| 422 | * @Then the JSON should not be valid according to swagger :dumpPath dump schema :schemaName |
||
| 423 | */ |
||
| 424 | public function theJsonShouldNotBeValidAccordingToTheSwaggerSchema($dumpPath, $schemaName) |
||
| 430 | |||
| 431 | |||
| 432 | |||
| 433 | protected function getJson() |
||
| 437 | |||
| 438 | private function checkSchemaFile($filename) |
||
| 446 | } |
||
| 447 |