BrowserKit - Code Metrics - Inspection of "New namespace \Behatch" - Behatch/contexts - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 873f60...3697fd )

by San

created 2015-12-08 21:23 UTC

BrowserKit A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	102
Duplicated Lines	21.57 %

Coupling/Cohesion

Components	1
Dependencies	3

Metric	Value
wmc	15
lcom	1
cbo	3
dl	22
loc	102
rs	10

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getMethod()	0	5	1
A	getUri()	0	5	1
A	getServer()	0	5	1
A	getParameters()	0	5	1
A	getRequest()	11	11	2
A	getContent()	0	4	1
A	send()	0	10	1
A	setHttpHeader()	11	11	2
A	getHttpHeaders()	0	7	1
A	getHttpHeader()	0	20	3

How to fix Duplicated Code

<?php

namespace Behatch\HttpCall\Request;

use Behat\Mink\Mink;

class BrowserKit
{
    protected $mink;

    public function __construct(Mink $mink)
    {
        $this->mink = $mink;
    }

    public function getMethod()
    {
        return $this->getRequest()
            ->getMethod();
    }

    public function getUri()
    {
        return $this->getRequest()
            ->getUri();
    }

    public function getServer()
    {
        return $this->getRequest()
            ->getServer();
    }

    public function getParameters()
    {
        return $this->getRequest()
            ->getParameters();
    }

    protected function getRequest()

    {
        $client = $this->mink->getSession()->getDriver()->getClient();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        // BC layer for BrowserKit 2.2.x and older
        if (method_exists($client, 'getInternalRequest')) {
            $request = $client->getInternalRequest();
        } else {
            $request = $client->getRequest();
        }
        return $request;
    }

    public function getContent()
    {
        return $this->mink->getSession()->getPage()->getContent();
    }

    public function send($method, $url, $parameters = [], $files = [], $content = null, $headers = [])
    {
        $client = $this->mink->getSession()->getDriver()->getClient();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $client->followRedirects(false);
        $client->request($method, $url, $parameters, $files, $headers, $content);
        $client->followRedirects(true);

        return $this->mink->getSession()->getPage();
    }

    public function setHttpHeader($name, $value)

    {
        $client = $this->mink->getSession()->getDriver()->getClient();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        // Use for goutte Driver only
        if (method_exists($client, 'setHeader')) {
            $client->setHeader($name, $value);
        } else {
            // Browserkit
            $client->setServerParameter($name, $value);
        }
    }

    public function getHttpHeaders()
    {
        return array_change_key_case(
            $this->mink->getSession()->getResponseHeaders(),
            CASE_LOWER
        );
    }

    public function getHttpHeader($name)
    {
        $name = strtolower($name);
        $headers = $this->getHttpHeaders();

        if (isset($headers[$name])) {
            if (is_array($headers[$name])) {
                $value = implode(', ', $headers[$name]);
            }
            else {
                $value = $headers[$name];
            }
        }
        else {
            throw new \OutOfBoundsException(
                "The header '$name' doesn't exist"
            );
        }
        return $value;
    }
}


1		<?php
2
3		namespace Behatch\HttpCall\Request;
4
5		use Behat\Mink\Mink;
6
7		class BrowserKit
8		{
9		protected $mink;
10
11		public function __construct(Mink $mink)
12		{
13		$this->mink = $mink;
14		}
15
16		public function getMethod()
17		{
18		return $this->getRequest()
19		->getMethod();
20		}
21
22		public function getUri()
23		{
24		return $this->getRequest()
25		->getUri();
26		}
27
28		public function getServer()
29		{
30		return $this->getRequest()
31		->getServer();
32		}
33
34		public function getParameters()
35		{
36		return $this->getRequest()
37		->getParameters();
38		}
39
40	View Code Duplication	protected function getRequest()
		0 ignored issues – show Duplication introduced 2015-12-01 20:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$client = $this->mink->getSession()->getDriver()->getClient();
		0 ignored issues – show Bug introduced 2015-12-01 20:19 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Behat\Mink\Driver\DriverInterface` as the method `getClient()` does only exist in the following implementations of said interface: `Behat\Mink\Driver\BrowserKitDriver`, `Behat\Mink\Driver\GoutteDriver`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43		// BC layer for BrowserKit 2.2.x and older
44		if (method_exists($client, 'getInternalRequest')) {
45		$request = $client->getInternalRequest();
46		} else {
47		$request = $client->getRequest();
48		}
49		return $request;
50		}
51
52		public function getContent()
53		{
54		return $this->mink->getSession()->getPage()->getContent();
55		}
56
57		public function send($method, $url, $parameters = [], $files = [], $content = null, $headers = [])
58		{
59		$client = $this->mink->getSession()->getDriver()->getClient();
		0 ignored issues – show Bug introduced 2015-12-01 20:19 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Behat\Mink\Driver\DriverInterface` as the method `getClient()` does only exist in the following implementations of said interface: `Behat\Mink\Driver\BrowserKitDriver`, `Behat\Mink\Driver\GoutteDriver`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
60
61		$client->followRedirects(false);
62		$client->request($method, $url, $parameters, $files, $headers, $content);
63		$client->followRedirects(true);
64
65		return $this->mink->getSession()->getPage();
66		}
67
68	View Code Duplication	public function setHttpHeader($name, $value)
		0 ignored issues – show Duplication introduced 2015-12-01 20:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		{
70		$client = $this->mink->getSession()->getDriver()->getClient();
		0 ignored issues – show Bug introduced 2015-12-01 20:19 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Behat\Mink\Driver\DriverInterface` as the method `getClient()` does only exist in the following implementations of said interface: `Behat\Mink\Driver\BrowserKitDriver`, `Behat\Mink\Driver\GoutteDriver`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
71		// Use for goutte Driver only
72		if (method_exists($client, 'setHeader')) {
73		$client->setHeader($name, $value);
74		} else {
75		// Browserkit
76		$client->setServerParameter($name, $value);
77		}
78		}
79
80		public function getHttpHeaders()
81		{
82		return array_change_key_case(
83		$this->mink->getSession()->getResponseHeaders(),
84		CASE_LOWER
85		);
86		}
87
88		public function getHttpHeader($name)
89		{
90		$name = strtolower($name);
91		$headers = $this->getHttpHeaders();
92
93		if (isset($headers[$name])) {
94		if (is_array($headers[$name])) {
95		$value = implode(', ', $headers[$name]);
96		}
97		else {
98		$value = $headers[$name];
99		}
100		}
101		else {
102		throw new \OutOfBoundsException(
103		"The header '$name' doesn't exist"
104		);
105		}
106		return $value;
107		}
108		}
109

Behatch / contexts

Push — 3.x ( 873f60...3697fd )

BrowserKit A

Complexity

Size/Duplication

Coupling/Cohesion

11 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like