Conditions | 1 |
Paths | 1 |
Total Lines | 78 |
Code Lines | 71 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
45 | protected function getCapabilitiesNode() |
||
46 | { |
||
47 | $node = parent::getCapabilitiesNode(); |
||
48 | |||
49 | $node |
||
50 | ->children() |
||
51 | ->scalarNode('automationName')->defaultValue('Appium')->end() |
||
52 | ->scalarNode('platformName')->end() |
||
53 | ->scalarNode('platformVersion')->end() |
||
54 | ->scalarNode('deviceName')->end() |
||
55 | ->scalarNode('app')->end() |
||
56 | ->scalarNode('browserName')->end() |
||
57 | ->scalarNode('newCommandTimeout')->end() |
||
58 | ->booleanNode('autoLaunch')->end() |
||
59 | ->scalarNode('language')->end() |
||
60 | ->scalarNode('locale')->end() |
||
61 | ->scalarNode('udid')->end() |
||
62 | ->scalarNode('orientation')->end() |
||
63 | ->booleanNode('autoWebview')->end() |
||
64 | ->booleanNode('noReset')->end() |
||
65 | ->booleanNode('fullReset')->end() |
||
66 | //ANDROID ONLY |
||
67 | ->scalarNode('appActivity')->end() |
||
68 | ->scalarNode('appPackage')->end() |
||
69 | ->scalarNode('appWaitActivity')->end() |
||
70 | ->scalarNode('appWaitPackage')->end() |
||
71 | ->scalarNode('deviceReadyTimeout')->end() |
||
72 | ->scalarNode('androidCoverage')->end() |
||
73 | ->scalarNode('androidDeviceReadyTimeout')->end() |
||
74 | ->scalarNode('androidDeviceSocket')->end() |
||
75 | ->scalarNode('avd')->end() |
||
76 | ->scalarNode('avdLaunchTimeout')->end() |
||
77 | ->scalarNode('avdReadyTimeout')->end() |
||
78 | ->scalarNode('avdArgs')->end() |
||
79 | ->scalarNode('keystorePassword')->end() |
||
80 | ->scalarNode('keystorePath')->end() |
||
81 | ->scalarNode('keyAlias')->end() |
||
82 | ->scalarNode('keyPassword')->end() |
||
83 | ->scalarNode('chromedriverExecutable')->end() |
||
84 | ->scalarNode('autoWebviewTimeout')->end() |
||
85 | ->scalarNode('intentAction')->end() |
||
86 | ->scalarNode('intentCategory')->end() |
||
87 | ->scalarNode('intentFlags')->end() |
||
88 | ->scalarNode('optionalIntentArguments')->end() |
||
89 | ->booleanNode('enablePerformanceLogging')->end() |
||
90 | ->booleanNode('useKeystore')->end() |
||
91 | ->booleanNode('stopAppOnReset')->end() |
||
92 | ->booleanNode('unicodeKeyboard')->end() |
||
93 | ->booleanNode('resetKeyboard')->end() |
||
94 | ->booleanNode('noSign')->end() |
||
95 | ->booleanNode('ignoreUnimportantViews')->end() |
||
96 | // IOS ONLY |
||
97 | ->scalarNode('calendarFormat')->end() |
||
98 | ->scalarNode('bundleId')->end() |
||
99 | ->scalarNode('udid')->end() |
||
100 | ->scalarNode('launchTimeout')->end() |
||
101 | ->scalarNode('localizableStringsDir')->end() |
||
102 | ->scalarNode('processArguments')->end() |
||
103 | ->scalarNode('interKeyDelay')->end() |
||
104 | ->scalarNode('sendKeyStrategy')->end() |
||
105 | ->scalarNode('screenshotWaitTimeout')->end() |
||
106 | ->scalarNode('waitForAppScript')->end() |
||
107 | ->booleanNode('locationServicesEnabled')->end() |
||
108 | ->booleanNode('locationServicesAuthorized')->end() |
||
109 | ->booleanNode('autoAcceptAlerts')->end() |
||
110 | ->booleanNode('autoDismissAlerts')->end() |
||
111 | ->booleanNode('nativeInstrumentsLib')->end() |
||
112 | ->booleanNode('nativeWebTap')->end() |
||
113 | ->booleanNode('safariAllowPopups')->end() |
||
114 | ->booleanNode('safariIgnoreFraudWarning')->end() |
||
115 | ->booleanNode('safariOpenLinksInBackground')->end() |
||
116 | ->booleanNode('keepKeyChains')->end() |
||
117 | ->booleanNode('showIOSLog')->end() |
||
118 | ->end() |
||
119 | ; |
||
120 | |||
121 | return $node; |
||
122 | } |
||
123 | } |
||
124 |