FeatureNode::__construct() - Code Metrics - Inspection of "Correctly filter features, now that the base path..." - Behat/Gherkin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#129)

by Pieter

created 2017-09-14 09:27 UTC

FeatureNode::__construct() B

↳ Parent: FeatureNode

Complexity

Conditions	2
Paths	2

Size

Total Lines	25
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	13
cts	13
cp	1
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	21
nc	2
nop	9
crap	2

How to fix Many Parameters

<?php

/*
 * This file is part of the Behat Gherkin.
 * (c) Konstantin Kudryashov <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Behat\Gherkin\Node;

/**
 * Represents Gherkin Feature.
 *
 * @author Konstantin Kudryashov <[email protected]>
 */
class FeatureNode implements KeywordNodeInterface, TaggedNodeInterface
{
    /**
     * @var null|string
     */
    private $title;
    /**
     * @var null|string
     */
    private $description;
    /**
     * @var string[]
     */
    private $tags = array();
    /**
     * @var null|BackgroundNode
     */
    private $background;
    /**
     * @var ScenarioInterface[]
     */
    private $scenarios = array();
    /**
     * @var string
     */
    private $keyword;
    /**
     * @var string
     */
    private $language;
    /**
     * @var null|string
     */
    private $file;
    /**
     * @var integer
     */
    private $line;

    /**
     * Initializes feature.
     *
     * @param null|string         $title
     * @param null|string         $description
     * @param string[]            $tags
     * @param null|BackgroundNode $background
     * @param ScenarioInterface[] $scenarios
     * @param string              $keyword
     * @param string              $language
     * @param null|string         $file        The absolute path to the feature file.
     * @param integer             $line
     */
    public function __construct(
        $title,
        $description,
        array $tags,
        BackgroundNode $background = null,
        array $scenarios,
// $a must always be passed; it's default value is never used.
function someFunction($a = 5, $b) { }
        $keyword,
        $language,
        $file,
        $line
    ) {
        // Verify that the feature file is an absolute path.
        if (realpath($file) === FALSE) {

            throw new \InvalidArgumentException('The file should be an absolute path.');
        }
        $this->title = $title;
        $this->description = $description;
        $this->tags = $tags;
        $this->background = $background;
        $this->scenarios = $scenarios;
        $this->keyword = $keyword;
        $this->language = $language;
        $this->file = $file;
        $this->line = $line;
    }

    /**
     * Returns node type string
     *
     * @return string
     */
    public function getNodeType()
    {
        return 'Feature';
    }

    /**
     * Returns feature title.
     *
     * @return null|string
     */
    public function getTitle()
    {
        return $this->title;
    }

    /**
     * Checks if feature has a description.
     *
     * @return Boolean
     */
    public function hasDescription()
    {
        return !empty($this->description);
    }

    /**
     * Returns feature description.
     *
     * @return null|string
     */
    public function getDescription()
    {
        return $this->description;
    }

    /**
     * Checks if feature is tagged with tag.
     *
     * @param string $tag
     *
     * @return Boolean
     */
    public function hasTag($tag)
    {
        return in_array($tag, $this->tags);
    }

    /**
     * Checks if feature has tags.
     *
     * @return Boolean
     */
    public function hasTags()
    {
        return 0 < count($this->tags);
    }

    /**
     * Returns feature tags.
     *
     * @return string[]
     */
    public function getTags()
    {
        return $this->tags;
    }

    /**
     * Checks if feature has background.
     *
     * @return Boolean
     */
    public function hasBackground()
    {
        return null !== $this->background;
    }

    /**
     * Returns feature background.
     *
     * @return null|BackgroundNode
     */
    public function getBackground()
    {
        return $this->background;
    }

    /**
     * Checks if feature has scenarios.
     *
     * @return Boolean
     */
    public function hasScenarios()
    {
        return 0 < count($this->scenarios);
    }

    /**
     * Returns feature scenarios.
     *
     * @return ScenarioInterface[]
     */
    public function getScenarios()
    {
        return $this->scenarios;
    }

    /**
     * Returns feature keyword.
     *
     * @return string
     */
    public function getKeyword()
    {
        return $this->keyword;
    }

    /**
     * Returns feature language.
     *
     * @return string
     */
    public function getLanguage()
    {
        return $this->language;
    }

    /**
     * Returns feature file as an absolute path.
     *
     * @return null|string
     */
    public function getFile()
    {
        return $this->file;
    }

    /**
     * Returns feature declaration line number.
     *
     * @return integer
     */
    public function getLine()
    {
        return $this->line;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Behat Gherkin.
5		* (c) Konstantin Kudryashov <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Behat\Gherkin\Node;
12
13		/**
14		* Represents Gherkin Feature.
15		*
16		* @author Konstantin Kudryashov <[email protected]>
17		*/
18		class FeatureNode implements KeywordNodeInterface, TaggedNodeInterface
19		{
20		/**
21		* @var null\|string
22		*/
23		private $title;
24		/**
25		* @var null\|string
26		*/
27		private $description;
28		/**
29		* @var string[]
30		*/
31		private $tags = array();
32		/**
33		* @var null\|BackgroundNode
34		*/
35		private $background;
36		/**
37		* @var ScenarioInterface[]
38		*/
39		private $scenarios = array();
40		/**
41		* @var string
42		*/
43		private $keyword;
44		/**
45		* @var string
46		*/
47		private $language;
48		/**
49		* @var null\|string
50		*/
51		private $file;
52		/**
53		* @var integer
54		*/
55		private $line;
56
57		/**
58		* Initializes feature.
59		*
60		* @param null\|string $title
61		* @param null\|string $description
62		* @param string[] $tags
63		* @param null\|BackgroundNode $background
64		* @param ScenarioInterface[] $scenarios
65		* @param string $keyword
66		* @param string $language
67		* @param null\|string $file The absolute path to the feature file.
68		* @param integer $line
69		*/
70	80	public function __construct(
71		$title,
72		$description,
73		array $tags,
74		BackgroundNode $background = null,
75		array $scenarios,
		0 ignored issues – show Coding Style introduced 2015-11-23 11:54 UTC by Report Bug Copy Issue Report Parameters which have default values should be placed at the end. If you place a parameter with a default value before a parameter with a default value, the default value of the first parameter will never be used as it will always need to be passed anyway: // $a must always be passed; it's default value is never used. function someFunction($a = 5, $b) { } Loading history...
76		$keyword,
77		$language,
78		$file,
79		$line
80		) {
81		// Verify that the feature file is an absolute path.
82	80	if (realpath($file) === FALSE) {
		0 ignored issues – show Coding Style introduced 2017-09-14 09:30 UTC by Report Bug Copy Issue Report `TRUE`, `FALSE` and `NULL` must be lowercase; expected `false`, but found `FALSE`. Loading history...
83	2	throw new \InvalidArgumentException('The file should be an absolute path.');
84		}
85	79	$this->title = $title;
86	79	$this->description = $description;
87	79	$this->tags = $tags;
88	79	$this->background = $background;
89	79	$this->scenarios = $scenarios;
90	79	$this->keyword = $keyword;
91	79	$this->language = $language;
92	79	$this->file = $file;
93	79	$this->line = $line;
94	79	}
95
96		/**
97		* Returns node type string
98		*
99		* @return string
100		*/
101	1	public function getNodeType()
102		{
103	1	return 'Feature';
104		}
105
106		/**
107		* Returns feature title.
108		*
109		* @return null\|string
110		*/
111	44	public function getTitle()
112		{
113	44	return $this->title;
114		}
115
116		/**
117		* Checks if feature has a description.
118		*
119		* @return Boolean
120		*/
121		public function hasDescription()
122		{
123		return !empty($this->description);
124		}
125
126		/**
127		* Returns feature description.
128		*
129		* @return null\|string
130		*/
131	45	public function getDescription()
132		{
133	45	return $this->description;
134		}
135
136		/**
137		* Checks if feature is tagged with tag.
138		*
139		* @param string $tag
140		*
141		* @return Boolean
142		*/
143		public function hasTag($tag)
144		{
145		return in_array($tag, $this->tags);
146		}
147
148		/**
149		* Checks if feature has tags.
150		*
151		* @return Boolean
152		*/
153	2	public function hasTags()
154		{
155	2	return 0 < count($this->tags);
156		}
157
158		/**
159		* Returns feature tags.
160		*
161		* @return string[]
162		*/
163	43	public function getTags()
164		{
165	43	return $this->tags;
166		}
167
168		/**
169		* Checks if feature has background.
170		*
171		* @return Boolean
172		*/
173	1	public function hasBackground()
174		{
175	1	return null !== $this->background;
176		}
177
178		/**
179		* Returns feature background.
180		*
181		* @return null\|BackgroundNode
182		*/
183	43	public function getBackground()
184		{
185	43	return $this->background;
186		}
187
188		/**
189		* Checks if feature has scenarios.
190		*
191		* @return Boolean
192		*/
193	2	public function hasScenarios()
194		{
195	2	return 0 < count($this->scenarios);
196		}
197
198		/**
199		* Returns feature scenarios.
200		*
201		* @return ScenarioInterface[]
202		*/
203	46	public function getScenarios()
204		{
205	46	return $this->scenarios;
206		}
207
208		/**
209		* Returns feature keyword.
210		*
211		* @return string
212		*/
213	40	public function getKeyword()
214		{
215	40	return $this->keyword;
216		}
217
218		/**
219		* Returns feature language.
220		*
221		* @return string
222		*/
223	41	public function getLanguage()
224		{
225	41	return $this->language;
226		}
227
228		/**
229		* Returns feature file as an absolute path.
230		*
231		* @return null\|string
232		*/
233	11	public function getFile()
234		{
235	11	return $this->file;
236		}
237
238		/**
239		* Returns feature declaration line number.
240		*
241		* @return integer
242		*/
243	48	public function getLine()
244		{
245	48	return $this->line;
246		}
247		}
248

Behat / Gherkin

Pull Request — master (#129)

FeatureNode::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like