UpstreamGherkinTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testGoodFeatures()	0	8	1
A	goodFeatures()	0	22	5

<?php

use Behat\Gherkin\Keywords\ArrayKeywords;

final class UpstreamGherkinTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private $notSupported = array(
        'good' => array(
            'descriptions',
            'docstrings',
            'incomplete_feature_3',
            'incomplete_scenario_outline',
            'readme_example',
            'rule',
            'scenario_outline',
            'scenario_outlines_with_tags',
            'several_examples',
            'spaces_in_language',
            'tags'
        )
    );

    /**
     * @dataProvider goodFeatures
     */
    public function testGoodFeatures($featureFile, $astFile)
    {
        $arrKeywords = include __DIR__ . '/../../i18n.php';
        $lexer  = new Behat\Gherkin\Lexer(new ArrayKeywords($arrKeywords));
        $parser = new Behat\Gherkin\Parser($lexer);

        $feature = $parser->parse(file_get_contents($featureFile));

$feature is not used, you could remove the assignment.

    }

    public function goodFeatures() : iterable
    {
       foreach (new FilesystemIterator(__DIR__ . '/../../gherkin_testdata/good') as $file) {

Blank line found at start of control structure

           if (in_array(preg_replace('/^.*\//', '', $file), $this->notSupported['good'])) {
               continue;
           }

           if (!preg_match('/(?<stem>.*)[.]feature$/', $file, $matches)) {
               continue;
           }

           if (in_array(preg_replace('/^.*\//', '', $matches['stem']), $this->notSupported['good'])) {
               continue;
           }

           yield $matches['stem'] => [
               $matches['stem'] . '.feature',
               $matches['stem'] . '.ast.ndjson'
           ];
       }
    }
}