Bowerphp\Package\Package

Complexity

Total Complexity

23

Size/Duplication

Total Lines	157
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

0

Importance

Changes	6
Bugs	2	Features	1

15 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	1
A	getVersion()	0	4	1
A	setVersion()	0	4	1
A	getRequiredVersionValue()	0	3	1
A	getRequiredVersionUrl()	0	3	1
A	getRequiredVersion()	0	4	1
A	setRequiredVersion()	0	4	1
A	setRepository()	0	7	3
A	getUniqueName()	0	4	1
A	setRequires()	0	4	1
A	getRequires()	0	9	3
A	setInfo()	0	4	1
A	getInfo()	0	4	1
A	__toString()	0	4	1
B	__construct()	0	18	5

<?php

namespace Bowerphp\Package;

use Bowerphp\Repository\RepositoryInterface;

/**
 * Package
 */
class Package implements PackageInterface
{
    protected $name;
    protected $repository;
    protected $requiredVersionValue;
    protected $requiredVersion;
    protected $requiredVersionUrl;
    protected $version;
    protected $requires = [];
    protected $info = [];

    /**
     * All descendants' constructors should call this parent constructor
     *
     * @param string $name            The package's name
     * @param string $requiredVersion E.g. 1.*
     * @param string $version         E.g. 1.2.3
     * @param array  $requires        The package's dependencies
     * @param array  $info            Package info (e.g. info from bower.json)
     */
    public function __construct($name, $requiredVersion = null, $version = null, $requires = [], $info = [])
    {
        $this->name = $name;
        $this->requiredVersion = $requiredVersion === 'master' ? '*' : $requiredVersion;
        
        $this->version = $version;
        if (!empty($requires)) {
            $this->requires = $requires;
        }
        if (!empty($info)) {
            $this->info = $info;
        }
        
        if(false!==($p=strpos($requiredVersion,'#'))){

Avoid variables with short names like $p. Configured minimum length is 2.

            $this->requiredVersionUrl = substr($requiredVersion,0,$p);
            $this->requiredVersion = substr($requiredVersion,$p+1);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * {@inheritdoc}
     */
    public function getVersion()
    {
        return $this->version;
    }

    /**
     * {@inheritdoc}
     */
    public function setVersion($version)
    {
        return $this->version = $version;
    }

    /**
     * {@inheritdoc}
     */
    public function getRequiredVersionValue(){
        return $this->requiredVersionValue;
    }
    public function getRequiredVersionUrl(){
        return $this->requiredVersionUrl;
    }
    public function getRequiredVersion()
    {
        return $this->requiredVersion;
    }

    /**
     * {@inheritdoc}
     */
    public function setRequiredVersion($version)
    {
        return $this->requiredVersion = $version;
    }

    /**
     * {@inheritdoc}
     */
    public function setRepository(RepositoryInterface $repository)
    {
        if ($this->repository && $repository !== $this->repository) {
            throw new \LogicException('A package can only be added to one repository');
        }
        $this->repository = $repository;
    }

    /**
     * Returns package unique name, constructed from name, version and release type.
     *
     * @return string
     */
    public function getUniqueName()
    {
        return $this->getName() . '-' . $this->getVersion();
    }

    /**
     * Set the required packages
     *
     * @param array $requires A set of package links
     */
    public function setRequires(array $requires = null)
    {
        $this->requires = $requires;

It seems like $requires can be null. However, the property $requires is declared as array. Maybe change the type of the property to array|null or add a type check?

    }

    /**
     * {@inheritdoc}
     */
    public function getRequires()
    {
        // see if there is some inside $this->info (e.g. from bower.json)
        if (empty($this->requires) && isset($this->info['dependencies'])) {
            $this->requires = $this->info['dependencies'];
        }

        return $this->requires;
    }

    /**
     * Set the info
     *
     * @param array $info
     */
    public function setInfo(array $info)
    {
        $this->info = $info;
    }

    /**
     * {@inheritdoc}
     */
    public function getInfo()
    {
        return $this->info;
    }

    /**
     * Converts the package into a readable and unique string
     *
     * @return string
     */
    public function __toString()
    {
        return $this->getUniqueName();
    }
}