ReadOnlyFallbackAdapter - Code Metrics - Inspection of "more test" - BePark/flysystem-fallback-to-read-only-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e53efb...f3ecaf )

by Grummfy

created 2017-05-06 00:25 UTC

ReadOnlyFallbackAdapter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	3
c	2
b	0
f	0
lcom	1
cbo	2
dl	0
loc	79
rs	10

3 Methods

Rating	Name	Size	Complexity
A	testAdapters()	11	1
B	testHasPath()	36	1
B	testWriteAndWriteStream()	27	1

<?php

namespace tests\units\BePark\Flysystem\ReadOnlyFallback;

use League\Flysystem\Config;

class ReadOnlyFallbackAdapter extends \atoum\test
{
	public function testAdapters()
	{
		$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
		$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');

		$this
			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
			->then
				->object($this->testedInstance->getMainAdapter())->isIdenticalTo($mainAdapter)
				->object($this->testedInstance->getReadOnlyAdapter())->isIdenticalTo($readOnlyAdapter);
	}

	public function testHasPath()
	{
		$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
		$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');

		$this
			->assert('test path existence on readOnly')
			->given(
				$this->newTestedInstance($mainAdapter, $readOnlyAdapter),
				$this->calling($readOnlyAdapter)->has = true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$this->calling($mainAdapter)->has = false
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			)
			->then
				->boolean($this->testedInstance->has('/foo'))->isTrue
				->mock($readOnlyAdapter)->receive('has')->withIdenticalArguments('/foo')->once
				->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once;

		$this
			->assert('test path existence on mainAdapter')
			->given($this->calling($mainAdapter)->has = true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			        $this->calling($readOnlyAdapter)->has = false)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->then
				->boolean($this->testedInstance->has('/foo'))->isTrue
				->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once
				->mock($readOnlyAdapter)->call('has')->never;


		$this
			->assert('test none existing path')
			->given($this->calling($mainAdapter)->has = false,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			        $this->calling($readOnlyAdapter)->has = false)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->then
				->boolean($this->testedInstance->has('/foo'))->isFalse
				->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once
				->mock($readOnlyAdapter)->receive('has')->withIdenticalArguments('/foo')->once;
	}

	public function testWriteAndWriteStream()
	{
		$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
		$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');

		$this->calling($mainAdapter)->write = true;
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->calling($readOnlyAdapter)->write = false;
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$this->calling($mainAdapter)->writeStream = true;
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->calling($readOnlyAdapter)->writeStream = false;
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$this
			->assert('test write')
			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
			->then
			->boolean($this->testedInstance->write('/foo', 'bar', new Config()))->isTrue
				->mock($readOnlyAdapter)->wasNotCalled
				->mock($mainAdapter)->receive('write')->withAtLeastArguments(['/foo', 'bar'])->once;

		$this
			->assert('test write stream')
			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
			->then
			->boolean($this->testedInstance->write('/foo', 'bar', new Config()))->isTrue
				->mock($readOnlyAdapter)->wasNotCalled
				->mock($mainAdapter)->receive('writeStream')->withAtLeastArguments(['/foo', 'bar'])->once;
	}
}


1			<?php
2
3			namespace tests\units\BePark\Flysystem\ReadOnlyFallback;
4
5			use League\Flysystem\Config;
6
7			class ReadOnlyFallbackAdapter extends \atoum\test
8			{
9			public function testAdapters()
10			{
11			$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
12			$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
13
14			$this
15			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
16			->then
17			->object($this->testedInstance->getMainAdapter())->isIdenticalTo($mainAdapter)
18			->object($this->testedInstance->getReadOnlyAdapter())->isIdenticalTo($readOnlyAdapter);
19			}
20
21			public function testHasPath()
22			{
23			$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
24			$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
25
26			$this
27			->assert('test path existence on readOnly')
28			->given(
29			$this->newTestedInstance($mainAdapter, $readOnlyAdapter),
30			$this->calling($readOnlyAdapter)->has = true,
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$readOnlyAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			$this->calling($mainAdapter)->has = false
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$mainAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			)
33			->then
34			->boolean($this->testedInstance->has('/foo'))->isTrue
35			->mock($readOnlyAdapter)->receive('has')->withIdenticalArguments('/foo')->once
36			->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once;
37
38			$this
39			->assert('test path existence on mainAdapter')
40			->given($this->calling($mainAdapter)->has = true,
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$mainAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			$this->calling($readOnlyAdapter)->has = false)
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$readOnlyAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			->then
43			->boolean($this->testedInstance->has('/foo'))->isTrue
44			->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once
45			->mock($readOnlyAdapter)->call('has')->never;
46
47
48			$this
49			->assert('test none existing path')
50			->given($this->calling($mainAdapter)->has = false,
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$mainAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51			$this->calling($readOnlyAdapter)->has = false)
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$readOnlyAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			->then
53			->boolean($this->testedInstance->has('/foo'))->isFalse
54			->mock($mainAdapter)->receive('has')->withIdenticalArguments('/foo')->once
55			->mock($readOnlyAdapter)->receive('has')->withIdenticalArguments('/foo')->once;
56			}
57
58			public function testWriteAndWriteStream()
59			{
60			$readOnlyAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
61			$mainAdapter = $this->newMockInstance('\League\Flysystem\AdapterInterface');
62
63			$this->calling($mainAdapter)->write = true;
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$mainAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64			$this->calling($readOnlyAdapter)->write = false;
			0 ignored issues – show Documentation introduced 2017-05-05 23:42 UTC by Report Bug Copy Issue Report `$readOnlyAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65
66			$this->calling($mainAdapter)->writeStream = true;
			0 ignored issues – show Documentation introduced 2017-05-06 00:27 UTC by Report Bug Copy Issue Report `$mainAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			$this->calling($readOnlyAdapter)->writeStream = false;
			0 ignored issues – show Documentation introduced 2017-05-06 00:27 UTC by Report Bug Copy Issue Report `$readOnlyAdapter` is of type `object\|null`, but the function expects a `object<mageekguy\atoum\mock\aggregator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68
69			$this
70			->assert('test write')
71			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
72			->then
73			->boolean($this->testedInstance->write('/foo', 'bar', new Config()))->isTrue
74			->mock($readOnlyAdapter)->wasNotCalled
75			->mock($mainAdapter)->receive('write')->withAtLeastArguments(['/foo', 'bar'])->once;
76
77			$this
78			->assert('test write stream')
79			->given($this->newTestedInstance($mainAdapter, $readOnlyAdapter))
80			->then
81			->boolean($this->testedInstance->write('/foo', 'bar', new Config()))->isTrue
82			->mock($readOnlyAdapter)->wasNotCalled
83			->mock($mainAdapter)->receive('writeStream')->withAtLeastArguments(['/foo', 'bar'])->once;
84			}
85			}
86

BePark / flysystem-fallback-to-read-only-adapter

Push — master ( e53efb...f3ecaf )

ReadOnlyFallbackAdapter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like