Complex classes like ReadOnlyFallbackAdapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ReadOnlyFallbackAdapter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class ReadOnlyFallbackAdapter implements AdapterInterface |
||
10 | { |
||
11 | protected $_readOnlyAdapter; |
||
12 | |||
13 | protected $_mainAdapter; |
||
14 | |||
15 | public function __construct(AdapterInterface $mainAdapter, AdapterInterface $readOnlyAdapter) |
||
20 | |||
21 | /** |
||
22 | * Returns the main adapter |
||
23 | * |
||
24 | * @return AdapterInterface |
||
25 | */ |
||
26 | public function getMainAdapter() |
||
30 | |||
31 | /** |
||
32 | * Returns the fallback adapter |
||
33 | * |
||
34 | * @return AdapterInterface |
||
35 | */ |
||
36 | public function getReadOnlyAdapter() |
||
40 | |||
41 | /** |
||
42 | * {@inheritdoc} |
||
43 | */ |
||
44 | public function write($path, $contents, Config $config) |
||
45 | { |
||
46 | return $this->_mainAdapter->write($path, $contents, $config); |
||
47 | } |
||
48 | |||
49 | /** |
||
50 | * {@inheritdoc} |
||
51 | */ |
||
52 | public function writeStream($path, $resource, Config $config) |
||
56 | |||
57 | /** |
||
58 | * {@inheritdoc} |
||
59 | */ |
||
60 | public function update($path, $contents, Config $config) |
||
66 | |||
67 | /** |
||
68 | * {@inheritdoc} |
||
69 | */ |
||
70 | public function updateStream($path, $resource, Config $config) |
||
76 | |||
77 | /** |
||
78 | * {@inheritdoc} |
||
79 | */ |
||
80 | public function rename($path, $newpath) |
||
87 | |||
88 | /** |
||
89 | * {@inheritdoc} |
||
90 | */ |
||
91 | public function copy($path, $newpath) |
||
98 | |||
99 | /** |
||
100 | * {@inheritdoc} |
||
101 | */ |
||
102 | public function delete($path) |
||
113 | |||
114 | /** |
||
115 | * {@inheritdoc} |
||
116 | */ |
||
117 | public function deleteDir($dirname) |
||
126 | |||
127 | /** |
||
128 | * {@inheritdoc} |
||
129 | */ |
||
130 | public function createDir($dirname, Config $config) |
||
134 | |||
135 | /** |
||
136 | * {@inheritdoc} |
||
137 | */ |
||
138 | public function setVisibility($path, $visibility) |
||
144 | |||
145 | /** |
||
146 | * {@inheritdoc} |
||
147 | */ |
||
148 | public function has($path) |
||
152 | |||
153 | /** |
||
154 | * {@inheritdoc} |
||
155 | */ |
||
156 | public function read($path) |
||
166 | |||
167 | /** |
||
168 | * {@inheritdoc} |
||
169 | */ |
||
170 | public function readStream($path) |
||
180 | |||
181 | //TODO |
||
182 | /** |
||
183 | * {@inheritdoc} |
||
184 | * @see https://github.com/Litipk/flysystem-fallback-adapter/blob/master/src/FallbackAdapter.php#L259 |
||
185 | */ |
||
186 | public function listContents($directory = '', $recursive = false) |
||
209 | |||
210 | /** |
||
211 | * {@inheritdoc} |
||
212 | */ |
||
213 | public function getMetadata($path) |
||
223 | |||
224 | /** |
||
225 | * {@inheritdoc} |
||
226 | */ |
||
227 | public function getSize($path) |
||
237 | |||
238 | /** |
||
239 | * {@inheritdoc} |
||
240 | */ |
||
241 | public function getMimetype($path) |
||
251 | |||
252 | /** |
||
253 | * {@inheritdoc} |
||
254 | */ |
||
255 | public function getTimestamp($path) |
||
265 | |||
266 | /** |
||
267 | * {@inheritdoc} |
||
268 | */ |
||
269 | public function getVisibility($path) |
||
279 | |||
280 | /** |
||
281 | * Make resource available for modification on the new adapter |
||
282 | * @param string $path |
||
283 | * @return bool |
||
284 | */ |
||
285 | protected function _backportFromReadOnly($path) |
||
308 | } |
||
309 |