Basster / lazy-response-bundle

src/Response/Handler/TwigResponseHandler.php

<?php
declare(strict_types=1);

namespace Basster\LazyResponseBundle\Response\Handler;

use Basster\LazyResponseBundle\Response\LazyResponseInterface;
use Basster\LazyResponseBundle\Response\TemplateResponse;
use Symfony\Component\HttpFoundation\Response;
use Twig\Environment;

/**
 * Class TemplateResponseHandler.
 */
final class TwigResponseHandler extends AbstractLazyResponseHandler
{
    public function __construct(private Environment $twig)

The parameter $twig is not used and could be removed.

    {
    }

    protected function isSupported(LazyResponseInterface $controllerResult): bool
    {
        return $controllerResult instanceof TemplateResponse;
    }

    /**
     * @param TemplateResponse $controllerResult
     *
     * @psalm-suppress MoreSpecificImplementedParamType
     *
     * @throws \Twig\Error\LoaderError
     * @throws \Twig\Error\RuntimeError
     * @throws \Twig\Error\SyntaxError
     */
    protected function generateResponse(LazyResponseInterface $controllerResult): Response
    {
        return new Response($this->twig->render($controllerResult->getTemplate(), $controllerResult->getData()), $controllerResult->getStatusCode(), $controllerResult->getHeaders());

The method getHeaders() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Basster\LazyResponseBundle\Response\LazyResponseInterface.

The method getTemplate() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. It seems like you code against a sub-type of Basster\LazyResponseBundle\Response\LazyResponseInterface such as Basster\LazyResponseBundle\Response\TemplateResponse.

The method getData() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. It seems like you code against a sub-type of Basster\LazyResponseBundle\Response\LazyResponseInterface such as Basster\LazyResponseBundle\Response\TemplateResponse or Basster\LazyResponseBundle\Response\JsonSerializeResponse.

    }
}