Basster\LazyResponseBundle\Response\Handler\RedirectResponseHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	isSupported()	0	3	1
A	generateResponse()	0	9	1
A	__construct()	0	2	1

<?php
declare(strict_types=1);

namespace Basster\LazyResponseBundle\Response\Handler;

use Basster\LazyResponseBundle\Response\LazyResponseInterface;
use Basster\LazyResponseBundle\Response\RedirectResponse;
use Symfony\Component\HttpFoundation\RedirectResponse as SymfonyRedirectResponse;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\RouterInterface;

/**
 * Class RedirectResponseHandler.
 */
final class RedirectResponseHandler extends AbstractLazyResponseHandler
{
    public function __construct(private RouterInterface $router)

The parameter $router is not used and could be removed.

    {
    }

    protected function isSupported(LazyResponseInterface $controllerResult): bool
    {
        return $controllerResult instanceof RedirectResponse;
    }

    /**
     * @param RedirectResponse $controllerResult
     *
     * @psalm-suppress MoreSpecificImplementedParamType
     */
    protected function generateResponse(LazyResponseInterface $controllerResult): Response
    {
        return new SymfonyRedirectResponse(
            $this->router->generate(
                $controllerResult->getRouteName(),

The method getRouteName() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. It seems like you code against a sub-type of Basster\LazyResponseBundle\Response\LazyResponseInterface such as Basster\LazyResponseBundle\Response\RedirectResponse.

                $controllerResult->getRouteParams()

The method getRouteParams() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. It seems like you code against a sub-type of Basster\LazyResponseBundle\Response\LazyResponseInterface such as Basster\LazyResponseBundle\Response\RedirectResponse.

            ),
            $controllerResult->getStatusCode(),
            $controllerResult->getHeaders()

The method getHeaders() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Basster\LazyResponseBundle\Response\LazyResponseInterface.

        );
    }
}