Basster\LazyResponseBundle\Response\Handler\JsonSerializeResponseHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	generateResponse()	0	7	1
A	isSupported()	0	3	1

<?php
declare(strict_types=1);

namespace Basster\LazyResponseBundle\Response\Handler;

use Basster\LazyResponseBundle\Response\JsonSerializeResponse;
use Basster\LazyResponseBundle\Response\LazyResponseInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\SerializerInterface;

/**
 * Class JsonSerializeResponseHandler.
 */
final class JsonSerializeResponseHandler extends AbstractLazyResponseHandler
{
    public function __construct(private SerializerInterface $serializer)

The parameter $serializer is not used and could be removed.

    {
    }

    /**
     * @param JsonSerializeResponse $controllerResult
     *
     * @psalm-suppress MoreSpecificImplementedParamType
     */
    protected function generateResponse(LazyResponseInterface $controllerResult): Response
    {
        return new JsonResponse(
            $this->serializer->serialize($controllerResult->getData(), 'json'),

The method getData() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. It seems like you code against a sub-type of Basster\LazyResponseBundle\Response\LazyResponseInterface such as Basster\LazyResponseBundle\Response\TemplateResponse or Basster\LazyResponseBundle\Response\JsonSerializeResponse.

            $controllerResult->getStatusCode(),
            $controllerResult->getHeaders(),

The method getHeaders() does not exist on Basster\LazyResponseBundle\Response\LazyResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Basster\LazyResponseBundle\Response\LazyResponseInterface.

            true
        );
    }

    protected function isSupported(LazyResponseInterface $controllerResult): bool
    {
        return $controllerResult instanceof JsonSerializeResponse;
    }
}