Game.js ➔ ??? - Code Metrics - Inspection of "major changes to logic and structure" - Barelydead/oop-chess - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( add66c...3bf222 )

by Christofer

created 2017-12-29 12:35 UTC

Game.js ➔ ??? B

↳ Parent: src/chess/Game.js

Complexity

Conditions	5
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	34
CRAP Score	5

Importance

Changes	5
Bugs	0	Features	2

Metric	Value
cc	5
c	5
b	0
f	2
nc	16
nop	3
dl	0
loc	52
ccs	34
cts	34
cp	1
crap	5
rs	8.6868

How to fix Long Method

const Player = require("./Player");
const Board = require("./Board");


/**
 * The game module
 * @module
 */
"use strict";

/**
 * The main module that executes the game
 */
class Game {
    /**
     * Init board with all player pieces
     * @param {object} - Preset gameboard Object

     */
    init(preset = null, name1 = "player1", name2 = "player2") {
        this.p1 = new Player("white", name1);
        this.p2 = new Player("black", name2);
        this.board = new Board();
        this.gameBoard = this.board.board;
        this.turn = this.p1.color;
        this.lastMove = null;
        this.NrOfmoves = 0;

        if (typeof preset !== "null") {
            this.bameBoard = preset;
        }
        //Pawns
        for (let i = 1; i <= 8; i++) {
            this.gameBoard["B"][i].piece = this.p1.pawns[i - 1];
        }

        for (let i = 1; i <= 8; i++) {
            this.gameBoard["G"][i].piece = this.p2.pawns[i - 1];
        }

        for (let i = 1; i <= 8; i++) {
            this.gameBoard["C"][i].piece = {color: "", symbol: "E"};
            this.gameBoard["D"][i].piece = {color: "", symbol: "E"};
            this.gameBoard["E"][i].piece = {color: "", symbol: "E"};
            this.gameBoard["F"][i].piece = {color: "", symbol: "E"};
        }

        // Rooks
        this.gameBoard["A"][1].piece = this.p1.rooks[0];
        this.gameBoard["A"][8].piece = this.p1.rooks[1];
        this.gameBoard["H"][1].piece = this.p2.rooks[0];
        this.gameBoard["H"][8].piece = this.p2.rooks[1];

        // Knights
        this.gameBoard["A"][2].piece = this.p1.knights[0];
        this.gameBoard["A"][7].piece = this.p1.knights[1];
        this.gameBoard["H"][2].piece = this.p2.knights[0];
        this.gameBoard["H"][7].piece = this.p2.knights[1];

        // Bishops
        this.gameBoard["A"][3].piece = this.p1.bishops[0];
        this.gameBoard["A"][6].piece = this.p1.bishops[1];
        this.gameBoard["H"][3].piece = this.p2.bishops[0];
        this.gameBoard["H"][6].piece = this.p2.bishops[1];

        // King Queen
        this.gameBoard["A"][4].piece = this.p1.king;
        this.gameBoard["A"][5].piece = this.p1.queen;
        this.gameBoard["H"][4].piece = this.p2.king;
        this.gameBoard["H"][5].piece = this.p2.queen;
    }


    /**
    * Move a boardpiece and call helpfunctions to check legality of the move
    * @return {Bool}, False if illegal move
    */
    movePiece(x, y, nx, ny) {
        let square = this.board.getSquare(x, y);
        let nSquare = this.board.getSquare(nx, ny);
        let take;

        if (nSquare.piece.symbol !== "E" && nSquare.piece.color !== square.piece.color) {
            console.log("Take")

            take=true
        }

        if (square.piece.symbol === "E") {
            console.log("no piece to move");
            return false
        }

        if (!square.piece.legalMove(x, y, nx, ny, take)) {

            console.log("piece cant move like that");
            return false;
        }

        if (square.piece.color !== this.turn) {
            console.log("Wrong player")
            return false
        }

        if (!this.board.checkDestination(this.turn, nx, ny)) {
            console.log("destination is not valid")
            return false
        }


        if (square.piece.symbol === "B") {
            if (!this.board.checkDiagonal(x, y, nx, ny)) {
                console.log("diagonal blocked");
                return false
            }
        } else if (square.piece.symbol === "R") {
            if (!this.board.checkRow(x, y, nx, ny)) {
                console.log("Row blocked");
                return false
            }
        } else if (square.piece.symbol === "Q") {
            let direction;
            direction = (x === nx || y == ny) ? "row" : "diagonal";
            if (direction === "row" && !this.board.checkRow(x, y, nx, ny)) {
                console.log("Row blocked");
                return false
            }
            if (direction === "diagonal" && !this.board.checkDiagonal(x, y, nx, ny)) {
                console.log("diagonal blocked");
                return false
            }
        }

        this.board.move(x, y, nx, ny);
        this.lastMove = [x, y, nx, ny];
        this.gameBoard[nx][ny].piece.moved += 1;
        this.nextPlayer();
        this.NrOfmoves += 1;

    }

    /**
    * Set next player
    * @return {null}
    */
    nextPlayer() {
        this.turn = this.turn === "black" ? "white" : "black";
    }

    /**
    * Show the status of the game
    * @return {object}
    */
    status() {
        return {
            "Player to act": this.turn,
            "White name": this.p1.name,
            "Black name": this.p2.name,
            "Last move": this.lastMove,
            "Board": this.board.getBoardArray()
        }
    }
}

module.exports = new Game();


1	1	const Player = require("./Player");
2	1	const Board = require("./Board");
3
4
5		/**
6		* The game module
7		* @module
8		*/
9	1	"use strict";
10
11		/**
12		* The main module that executes the game
13		*/
14		class Game {
15		/**
16		* Init board with all player pieces
17		* @param {object} - Preset gameboard Object
		0 ignored issues – show Documentation introduced 2017-12-29 12:36 UTC by Report Bug Copy Issue Report The parameter `-` does not exist. Did you maybe forget to remove this comment? Loading history...
18		*/
19		init(preset = null, name1 = "player1", name2 = "player2") {
20	2	this.p1 = new Player("white", name1);
21	2	this.p2 = new Player("black", name2);
22	2	this.board = new Board();
23	2	this.gameBoard = this.board.board;
24	2	this.turn = this.p1.color;
25	2	this.lastMove = null;
26	2	this.NrOfmoves = 0;
27
28	2	if (typeof preset !== "null") {
29	2	this.bameBoard = preset;
30		}
31		//Pawns
32	2	for (let i = 1; i <= 8; i++) {
33	16	this.gameBoard["B"][i].piece = this.p1.pawns[i - 1];
34		}
35
36	2	for (let i = 1; i <= 8; i++) {
37	16	this.gameBoard["G"][i].piece = this.p2.pawns[i - 1];
38		}
39
40	2	for (let i = 1; i <= 8; i++) {
41	16	this.gameBoard["C"][i].piece = {color: "", symbol: "E"};
42	16	this.gameBoard["D"][i].piece = {color: "", symbol: "E"};
43	16	this.gameBoard["E"][i].piece = {color: "", symbol: "E"};
44	16	this.gameBoard["F"][i].piece = {color: "", symbol: "E"};
45		}
46
47		// Rooks
48	2	this.gameBoard["A"][1].piece = this.p1.rooks[0];
49	2	this.gameBoard["A"][8].piece = this.p1.rooks[1];
50	2	this.gameBoard["H"][1].piece = this.p2.rooks[0];
51	2	this.gameBoard["H"][8].piece = this.p2.rooks[1];
52
53		// Knights
54	2	this.gameBoard["A"][2].piece = this.p1.knights[0];
55	2	this.gameBoard["A"][7].piece = this.p1.knights[1];
56	2	this.gameBoard["H"][2].piece = this.p2.knights[0];
57	2	this.gameBoard["H"][7].piece = this.p2.knights[1];
58
59		// Bishops
60	2	this.gameBoard["A"][3].piece = this.p1.bishops[0];
61	2	this.gameBoard["A"][6].piece = this.p1.bishops[1];
62	2	this.gameBoard["H"][3].piece = this.p2.bishops[0];
63	2	this.gameBoard["H"][6].piece = this.p2.bishops[1];
64
65		// King Queen
66	2	this.gameBoard["A"][4].piece = this.p1.king;
67	2	this.gameBoard["A"][5].piece = this.p1.queen;
68	2	this.gameBoard["H"][4].piece = this.p2.king;
69	2	this.gameBoard["H"][5].piece = this.p2.queen;
70		}
71
72
73		/**
74		* Move a boardpiece and call helpfunctions to check legality of the move
75		* @return {Bool}, False if illegal move
76		*/
77		movePiece(x, y, nx, ny) {
78		let square = this.board.getSquare(x, y);
79		let nSquare = this.board.getSquare(nx, ny);
80		let take;
81
82	4	if (nSquare.piece.symbol !== "E" && nSquare.piece.color !== square.piece.color) {
83		console.log("Take")
		0 ignored issues – show Debugging Code introduced 2017-12-29 12:36 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
84		take=true
85		}
86
87	2	if (square.piece.symbol === "E") {
88		console.log("no piece to move");
89		return false
90		}
91
92	2	if (!square.piece.legalMove(x, y, nx, ny, take)) {
		0 ignored issues – show Bug introduced 2017-12-29 12:36 UTC by Report Bug Copy Issue Report The variable `take` does not seem to be initialized in case `nSquare.piece.symbol !==... !== square.piece.color` on line `82` is `false`. Are you sure the function `legalMove` handles `undefined` variables? Loading history...
93		console.log("piece cant move like that");
94		return false;
95		}
96
97	2	if (square.piece.color !== this.turn) {
98		console.log("Wrong player")
99		return false
100		}
101
102	2	if (!this.board.checkDestination(this.turn, nx, ny)) {
103		console.log("destination is not valid")
104		return false
105		}
106
107
108	2	if (square.piece.symbol === "B") {
109	2	if (!this.board.checkDiagonal(x, y, nx, ny)) {
110		console.log("diagonal blocked");
111		return false
112		}
113	2	} else if (square.piece.symbol === "R") {
114	2	if (!this.board.checkRow(x, y, nx, ny)) {
115		console.log("Row blocked");
116		return false
117		}
118	2	} else if (square.piece.symbol === "Q") {
119		let direction;
120	4	direction = (x === nx \|\| y == ny) ? "row" : "diagonal";
121	4	if (direction === "row" && !this.board.checkRow(x, y, nx, ny)) {
122		console.log("Row blocked");
123		return false
124		}
125	4	if (direction === "diagonal" && !this.board.checkDiagonal(x, y, nx, ny)) {
126		console.log("diagonal blocked");
127		return false
128		}
129		}
130
131		this.board.move(x, y, nx, ny);
132		this.lastMove = [x, y, nx, ny];
133		this.gameBoard[nx][ny].piece.moved += 1;
134		this.nextPlayer();
135		this.NrOfmoves += 1;
		0 ignored issues – show Best Practice introduced 2017-12-29 12:36 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
136		}
137
138		/**
139		* Set next player
140		* @return {null}
141		*/
142		nextPlayer() {
143	2	this.turn = this.turn === "black" ? "white" : "black";
144		}
145
146		/**
147		* Show the status of the game
148		* @return {object}
149		*/
150		status() {
151		return {
152		"Player to act": this.turn,
153		"White name": this.p1.name,
154		"Black name": this.p2.name,
155		"Last move": this.lastMove,
156		"Board": this.board.getBoardArray()
157		}
158		}
159		}
160
161		module.exports = new Game();
162

Barelydead / oop-chess

Push — master ( add66c...3bf222 )

Game.js ➔ ??? B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like