Column::__construct() - Code Metrics - Inspection of "make sure to not add the extension twice" - Baptouuuu/Spreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1718fc...f98f5b )

by Baptiste

created 2016-07-16 14:09 UTC

Column::__construct() A

↳ Parent: Column

Complexity

Conditions	4
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	13
Ratio	100 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	13
loc	13
ccs	8
cts	8
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	2
nop	2
crap	4

<?php
declare(strict_types = 1);

namespace Spreadsheet;

use Spreadsheet\Exception\InvalidArgumentException;
use Innmind\Immutable\MapInterface;

final class Column implements ColumnInterface
{
    private $identifier;
    private $cells;

    public function __construct($identifier, MapInterface $cells)
    {
        if (
            !is_scalar($identifier) ||
            (string) $cells->keyType() !== 'scalar' ||
            (string) $cells->valueType() !== CellInterface::class
        ) {
            throw new InvalidArgumentException;
        }

        $this->identifier = $identifier;
        $this->cells = $cells;
    }

    /**
     * {@inheritdoc}
     */
    public function identifier()
    {
        return $this->identifier;
    }

    /**
     * {@inheritdoc}
     */
    public function cells(): MapInterface
    {
        return $this->cells;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Spreadsheet;
5
6			use Spreadsheet\Exception\InvalidArgumentException;
7			use Innmind\Immutable\MapInterface;
8
9		View Code Duplication	final class Column implements ColumnInterface
10			{
11			private $identifier;
12			private $cells;
13
14	14		public function __construct($identifier, MapInterface $cells)
15			{
16			if (
17	14		!is_scalar($identifier) \|\|
18	13		(string) $cells->keyType() !== 'scalar' \|\|
19	14		(string) $cells->valueType() !== CellInterface::class
20			) {
21	2		throw new InvalidArgumentException;
22			}
23
24	12		$this->identifier = $identifier;
25	12		$this->cells = $cells;
26	12		}
27
28			/**
29			* {@inheritdoc}
30			*/
31	1		public function identifier()
32			{
33	1		return $this->identifier;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39	12		public function cells(): MapInterface
40			{
41	12		return $this->cells;
42			}
43			}
44

Baptouuuu / Spreadsheet

Push — master ( 1718fc...f98f5b )

Column::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like