Issues in Requester.php (master) - Issues in master - BaguettePHP/mastodon-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Requester.php (14 issues)

Labels

Severity

Major 14

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Baguette\Mastodon;

use Baguette\Mastodon\Client;
use Baguette\Mastodon\Entity;
use Baguette\Mastodon\Service\SessionStorage;
use Baguette\Mastodon\Service\Toot;
use Psr\Http\Message\ResponseInterface;
use Respect\Validation\Validator as v;

/**
 * Mastodon Anthorization object factory
 *
 * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md
 * @author    USAMI Kenta <[email protected]>
 * @copyright 2017 Baguette HQ
 * @license   https://www.gnu.org/licenses/gpl-3.0.html GPL-3.0
 */
class Requester
{
    //
    // Account API
    //

    /**
     * Fetching an account
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#fetching-an-account
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  int            $id
     * @return Entity\Account
     */
    public static function getAccount(Client $client, SessionStorage $session, $id)
    {
        v::intVal()->min(0)->assert($id);

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            Entity\Account::class,
            $client->requestAPI('GET', sprintf('/api/v1/accounts/%d', $id), [], $session)
        );
    }

    /**
     * Getting the current user
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#getting-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @return Entity\Account
     */
    public static function getAccountCurrentUser(Client $client, SessionStorage $session)
    {
        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            Entity\Account::class,
            $client->requestAPI('GET', '/api/v1/accounts/verify_credentials', [], $session)
        );
    }

    /**
     * Updating the current user
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#updating-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  array          $update_data
     * @return Entity\Account
     */
    public static function updateAccount(Client $client, SessionStorage $session, $update_data)
    {
        $form_params = [];

        if (isset($update_data['display_name'])) {
            v::stringType()->assert($update_data['display_name']);
            $form_params['display_name'] = (string)$update_data['display_name'];
        }

        if (isset($update_data['note'])) {
            v::stringType()->assert($update_data['note']);
            $form_params['note'] = (string)$update_data['note'];
        }

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            Entity\Account::class,
            $client->requestAPI('PATCH', '/api/v1/accounts/update_credentials', [
                'form_params' => $form_params
            ], $session)
        );
    }

    /**
     * Getting an account's followers
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#updating-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  int            $account_id
     * @return Entity\Account[]
     */
    public static function getAccountFollowers(Client $client, SessionStorage $session, $account_id)
    {
        v::intVal()->assert($account_id);

        $query = [];

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            [Entity\Account::class],
            $client->requestAPI('GET', sprintf('/api/v1/accounts/%d/followers', $account_id), [
                'query' => $query
            ], $session)
        );
    }

    /**
     * Fetching a user's blocks
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#updating-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  array          $options
     * @return Entity\Account[]
     */
    public static function getBlocks(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
            v::intVal()->min(0)->assert($options['max_id']);
            $query['max_id'] = $options['max_id'];
        }

        if (isset($options['since_id'])) {
            v::intVal()->min(0)->assert($options['since_id']);
            $query['since_id'] = $options['since_id'];
        }

        if (isset($options['limit'])) {
            v::intVal()->min(0)->assert($options['limit']);
            $query['limit'] = $options['limit'];
        }

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            [Entity\Account::class],
            $client->requestAPI('GET', '/api/v1/blocks', [
                'query' => $query,
            ], $session)
        );
    }

    /**
     * Fetching a user's favourites
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#updating-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  array          $options
     * @return Entity\Status[]
     */
    public static function getFavourites(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
            v::intVal()->min(0)->assert($options['max_id']);
            $query['max_id'] = $options['max_id'];
        }

        if (isset($options['since_id'])) {
            v::intVal()->min(0)->assert($options['since_id']);
            $query['since_id'] = $options['since_id'];
        }

        if (isset($options['limit'])) {
            v::intVal()->min(0)->assert($options['limit']);
            $query['limit'] = $options['limit'];
        }

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            [Entity\Status::class],
            $client->requestAPI('GET', '/api/v1/favourites', [
                'query' => $query,
            ], $session)
        );
    }

    /**
     * Fetching a list of follow requests
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#fetching-a-list-of-follow-requests
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  array          $options
     * @return Entity\Accounts[]
     */
    public static function getFollowRequests(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
            v::intVal()->min(0)->assert($options['max_id']);
            $query['max_id'] = $options['max_id'];
        }

        if (isset($options['since_id'])) {
            v::intVal()->min(0)->assert($options['since_id']);
            $query['since_id'] = $options['since_id'];
        }

        if (isset($options['limit'])) {
            v::intVal()->min(0)->assert($options['limit']);
            $query['limit'] = $options['limit'];
        }

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            [Entity\Account::class],
            $client->requestAPI('GET', '/api/v1/follow_requests', [
                'query' => $query,
            ], $session)
        );
    }

    //
    // Status API
    //

    /**
     * Posting a new status
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#posting-a-new-status
     * @param Toot $toot
     * @return Entity\Account
     */
    public static function postStatus(Client $client, SessionStorage $session, Toot $toot)
    {
        $form_params = [
            'status' => $toot->toot_string,
        ];

        if ($toot->sensitive) {
            $form_params['sensitive'] = 'true';
        }

        if ($toot->in_reply_to_id) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $form_params['in_reply_to_id'] = $toot->in_reply_to_id;
        }

        if (count($toot->media_ids) > 0) {
            $form_params['media_ids'] = $toot->media_ids;
        }

        if ($toot->visibility === null) {
            $form_params['visibility'] = $toot->visibility;
        }

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            Entity\Status::class,
            $client->requestAPI('POST', '/api/v1/statuses', [
                'form_params' => $form_params
            ], $session)
        );
    }

    //
    // Timelines API
    //

    

    //
    // Utility method
    //

    /**
     * Getting an account's followers
     *
     * @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#updating-the-current-user
     * @param  Client         $client
     * @param  SessionStorage $session
     * @param  int            $status_id
     * @return Entity\Account[]
     */
    public static function getStatus(Client $client, SessionStorage $session, $status_id)
    {
        v::intVal()->assert($status_id);

        return static::map(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            Entity\Status::class,
            $client->requestAPI('GET', sprintf('/api/v1/statuses/%d', $status_id), [], $session)
        );
    }

    /**
     * @param  string|string[]   $class
     * @param  ResponseInterface $response
     * @return Entity\Entity|Entity\Entity[]
     */
    private static function map($class, ResponseInterface $response)
    {
        return Entity\map(
            $class,
            \GuzzleHttp\json_decode($response->getBody(), true)
        );
    }
}


1			<?php
2
3			namespace Baguette\Mastodon;
4
5			use Baguette\Mastodon\Client;
6			use Baguette\Mastodon\Entity;
7			use Baguette\Mastodon\Service\SessionStorage;
8			use Baguette\Mastodon\Service\Toot;
9			use Psr\Http\Message\ResponseInterface;
10			use Respect\Validation\Validator as v;
11
12			/**
13			* Mastodon Anthorization object factory
14			*
15			* @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md
16			* @author USAMI Kenta <[email protected]>
17			* @copyright 2017 Baguette HQ
18			* @license https://www.gnu.org/licenses/gpl-3.0.html GPL-3.0
19			*/
20			class Requester
21			{
22			//
23			// Account API
24			//
25
26			/**
27			* Fetching an account
28			*
29			* @see https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#fetching-an-account
30			* @param Client $client
31			* @param SessionStorage $session
32			* @param int $id
33			* @return Entity\Account
34			*/
35	1	View Code Duplication	public static function getAccount(Client $client, SessionStorage $session, $id)
36			{
37	1		v::intVal()->min(0)->assert($id);
38
39	1		return static::map(
			0 ignored issues – show Bug introduced 2017-05-05 05:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `map()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `map()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history... Bug Compatibility introduced 2017-05-05 05:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `static::map(\Baguette\Ma...), array(), $session));` of type `object\|array` adds the type `array` to the return on line 39 which is incompatible with the return type documented by `Baguette\Mastodon\Requester::getAccount` of type `Baguette\Mastodon\Entity\Account`. Loading history...

BaguettePHP / mastodon-api

Issues (76)

Security Analysis not enabled

src/Requester.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like